Git log: commit 82ad4ac09b916e6e72fc4364b9b5a9f7ba4c1299
Merge: 5c8417e 091c7bb
Author: Marc Haber <mh+debian-packages@zugschlus.de>
Date: Mon Nov 29 16:09:10 2021 +0000
Merge branch 'DBTS-573155-usage-gid' into 'master'
Fix an invalid command in the "adduser -h" output (DBTS: #573155)
See merge request debian/adduser!7
commit 091c7bb1a4c14f715e39fef11723dd0a77b91612
Author: Jason Franklin <jason@oneway.dev>
Date: Sun Nov 28 08:01:06 2021 -0500
Trim trailing whitespace in the "adduser" script
No one likes trailing whitespace.
Gbp-Dch: Ignore
commit e6d23daf368cbbad378128b25cfe2383b7149f94
Author: Jason Franklin <jason@oneway.dev>
Date: Sun Nov 28 07:54:14 2021 -0500
Make "--gid" in the help output match the man page
This obviously does not fix the appearance of all such options in
the help text. That will come with time.
Gbp-Dch: Ignore
commit 0a747a66739fea7beb43158ccccff8cb439a8653
Author: Jason Franklin <jason@oneway.dev>
Date: Sun Nov 28 07:50:02 2021 -0500
Fix an invalid command in the "adduser -h" output
Closes: #573155
commit 5c8417ed4a9564ff7058490e5b31b9f8c764bdf0
Merge: ef554c4 63f9f13
Author: Marc Haber <mh+debian-packages@zugschlus.de>
Date: Sun Nov 28 11:28:00 2021 +0000
Merge branch 'DBTS-503153-gid-ingroup' into 'master'
Edit the "--gid" and "--ingroup" man page text (DBTS: #503153)
See merge request debian/adduser!6
commit 63f9f137ceadc7f06aa64502a5e4596e31a06fc6
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 27 09:45:16 2021 -0500
Adjust the description of the "--ingroup" option
This minor adjustment makes the text read slightly better.
I would rather be fussy now (just before peer-review) than feel the
need to change things at a later time.
Gbp-Dch: Ignore
commit 3a8625494e249125ccccf973c66b18eff8121efa
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 27 09:35:26 2021 -0500
Re-position the man page text for "--ingroup"
This commit re-positions the description of "--ingroup" just below
the description of the "--gid" option.
These two options are fairly similar, so having them close together
seemed like the sensible thing to do.
Gbp-Dch: Ignore
commit 269a2c70c158197601235b8d327bb77ea9161bd3
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 27 09:27:40 2021 -0500
Edit the "--gid" and "--ingroup" man page text
This commit edits the descriptions of the "--gid" and "--ingroup"
options found in adduser(8). Justifications for these changes
follow below.
Regarding "--gid":
The new text clearly indicates that the provided GID will be used
to initialize a new user's primary group ID number. The complaint
was that the text "this option will put the user in that group"
was not clear enough. The variable is also changed from "ID" to
"GID" to indicate that it is indeed a number we are talking about.
The new text matches this update.
Regarding "--ingroup":
Again, we state unambiguously that we are using the provided group
name to initialize the new user's primary group ID number. I went
ahead and omitted the mentioning of overridden settings. This is
already explained in the DESCRIPTION section, and it should be
implied. I also removed the reference to "--add_extra_groups"
since it is documented just below.
I am not sure that there was really a "bug" here, but it was
a simple change to accommodate a user's complaint. Including it
does no harm and possibly helps someone.
Closes: #503153
commit dfed18296d7be5a9eeb70953c76acba07be13dd0
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 27 07:35:03 2021 -0500
Change "GIDS" to "GIDs" in the adduser man page
Gbp-Dch: Ignore
commit ef554c48a54c4e348afa442d286a0e844715833c
Merge: 3982734 4a191ed
Author: Marc Haber <mh+debian-packages@zugschlus.de>
Date: Tue Nov 23 20:42:02 2021 +0000
Merge branch 'DBTS-846242-short-options' into 'master'
Document currently supported short options (DBTS: #846242)
See merge request debian/adduser!5
commit 3982734b7cea35182b15b23945816ce42c001619
Author: Marc Haber <mh+mr-git@zugschlus.de>
Date: Tue Nov 23 21:28:37 2021 +0100
Fix NAME_REGEX the intended way
Closes: 630750
Thanks: Georgios M. Zarkadas, Daniel Convissor, Henry Lin, Laurent Martelli
commit 4a191ed10521c67962ce163438ad2882da289c92
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 14:03:30 2021 -0500
Update the changelog
DBTS: #846242
commit b15788105e27165072670208f127dde0fc354242
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 13:49:07 2021 -0500
Edit "general options" in each usage message
This commit edits the "general options" section of each usage
message to ensure that the format of the option descriptions are
closely aligned with what is found in the man pages.
The only important part is indicating that "-c" also requires the
"FILE" argument, just like its long form.
commit 7e7370bd5642d16e2d7acae9a13f026acecc9468
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 13:23:51 2021 -0500
Remove the "COMMON OPTIONS" man page sections
I see no benefit in retaining these sections. The options listed
within them don't seem to be selected logically. For example, will
the "--debug" option really be used often?
Furthermore, this section is not listed as a "standard" section in
the guidelines for Linux man pages. See man-pages(7).
Finally, the redundancy is also a problem. If options change in
their behavior, I must check yet another place where the
documentation might need to be updated.
commit 9ed6d6525f80bbb7c08b8a702a9fcb3fe3af1946
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 13:07:10 2021 -0500
Edit the descriptions of the "-c" option
I believe guidelines indicate that arguments to command line options
should be in italics, so that is added here.
commit aef2d539ef99405520a796b1e533a8e795ac866b
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 12:53:46 2021 -0500
Document the "-c" option
I was careful to follow the guidance of man-pages(7), which says to
place arguments to options in italics.
Note that the "=" form was used under the "OPTIONS" section. This
conforms to the more common way of documenting options like this.
DBTS: #846242
commit f92a98d0e44be445f1fe95e6f6b87d70fc3bbefe
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 11:53:50 2021 -0500
Explicitly add "-c" to option specifications
Before this commit, the "-c" option was only mentioned in command
usage messages. It was implicitly provided by Perl's default option
parsing configuration which allows option names to be abbreviated to
uniqueness.
In fact, the Perl option parsing used by "adduser" and "deluser" is
very permissive. I think it is far too permissive for a critical
system utility. For example, the following ...
$ adduser -v
$ adduser --vers
$ adduser -VeRsi
... are all implicitly supported as of now.
In the future, I hope to see us get to a state where the supported
options exactly match those which are documented.
That is the kind of rigor I expect from a utility like this.
DBTS: #846242
commit f4ce833a71f881bdad1ad08134b421aab96f2606
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 10:09:43 2021 -0500
Document the "-v" option
DBTS: #846242
commit ef0f9216e7002a5627f3f4e30c010cabab379a51
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 10:01:16 2021 -0500
Document the "-h" option
DBTS: #846242
commit 065d49eae60ab886169087b097ac1072e943047d
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 09:51:06 2021 -0500
Document the "-q" option
DBTS: #846242
commit cf565eb25a99893233c8547f1fb24cebf74e9a43
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 08:30:36 2021 -0500
Remove editor-specific directives
This change is a bit opinionated.
I argue that editor-specific directives do not belong in source code
that we distribute, so I am removing them. Such directives are fine
for users editing personal files on their own machines. In shared
projects, they are more like noise comments.
Note that these directives do not work well at enforcing indentation
rules. The indentation in "adduser" is an odd mixture of tabs and
spaces and is very inconsistent. Users who don't use Vim will
ignore the rules anyway.
Since we have a review process with PRs, we can just reject merge
requests where the contributor has made a mess of the whitespace.
Furthermore, if Emacs can't detect that our man page files are of
the "nroff" type, I would say that Emacs should be fixed. Vim has
no problem with discerning the file type.
commit 255112c356523dc69e7e692171c58eb97cb51208
Author: Jason Franklin <jason@oneway.dev>
Date: Tue Nov 23 08:00:31 2021 -0500
Make the "deluser" script executable
This makes the working tree permissions on the "deluser" script
match those on the "adduser" script.
It's just a convenience for developers. Now, when I checkout the
version of "deluser" that is in the Git index, the file remains
executable in my working tree.
commit e76235198ca94c7235608aeebd614e20399a6a43
Author: Marc Haber <mh+mr-git@zugschlus.de>
Date: Mon Nov 22 06:24:54 2021 +0100
add basic salsa-ci
commit a33fb196c7179d37a348b4a450c2278c865fb159
Merge: e13d61c 108ce3f
Author: Marc Haber <mh+debian-packages@zugschlus.de>
Date: Mon Nov 22 05:23:34 2021 +0000
Merge branch 'DBTS-974658-man-page-dots' into 'master'
Strip trailing dots from man page descriptions (DBTS: #974658)
See merge request debian/adduser!4
commit 108ce3f977983d8cc02d51d30689400ca12b3305
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 20 07:54:20 2021 -0500
Update the changelog
DBTS: #974658
commit c6e1969a010496f3f1f0cbe81f55f7c23c884e69
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 20 07:43:20 2021 -0500
Run "wrap-and-sort"
Some of the Debian packaging assistance tools like to run this
command for you automatically.
If you do not run this on your code and commit the changes, running
a command like "debmake --native" on your working tree will result
in unstaged modifications, which is not nice.
Running this every now and then does no harm, and it results in
a less fussy packaging experience.
As of this writing, "wrap-and-sort" is installed by the "devscripts"
package in case you need to find it.
commit 905fc0c9716db04f1fd15532bee730cd2d9aeda6
Author: Jason Franklin <jason@oneway.dev>
Date: Sat Nov 20 07:34:49 2021 -0500
Strip trailing dots from man page descriptions
This is a fairly simple and low-priority fix.
One may observe with the following commands that having such
trailing dots is indeed unusual. The shell command output you see
here was pulled from my system:
$ apropos '.*' | wc -l
11729
$ apropos '.*\.$' | wc -l
614
$ apropos '.*\s\.$' | wc -l
2
$ apropos '.*\s\.$'
adduser.conf (5) - configuration file ...
deluser.conf (5) - configuration file ...
The first command counts all of the descriptions available. The
second counts the ones that end in a period, which is unusual. The
third command counts those that end in a space and then a period,
which is very unusual. The final command shows that only our
description lines have this quirk.
Note that the ".BR" command was changed to ".B" because there is
only one argument to the command now. Thus, there is no need to
alternate between bold and Roman type.
Applying this fix closes a bug in the tracking system and does no
harm to the package. I see no reason not to include it!
DBTS: #974658
commit e13d61c0d6f9008bb294c9f89da9a52d753a729d
Merge: fa79d84 35c41ae
Author: Christian Hofstaedtler <zeha@debian.org>
Date: Sat Jul 25 23:29:44 2020 +0000
Merge branch 'lintian-fixes' into 'master'
Fix some issues reported by lintian
See merge request debian/adduser!2
commit 35c41ae9b4c8ff6e51da8bbad38194421e87b934
Author: Debian Janitor <janitor@jelmer.uk>
Date: Tue Apr 28 05:09:47 2020 +0000
Fix misspelling of Close => Closes.
Fixes: lintian: misspelled-closes-bug
See-also: https://lintian.debian.org/tags/misspelled-closes-bug.html
commit 3b7dffa3554ae07f0d3d31c2cee524848b90975e
Author: Debian Janitor <janitor@jelmer.uk>
Date: Tue Apr 28 05:08:36 2020 +0000
Wrap long lines in changelog entries: 3.107, 2.10.
Fixes: lintian: debian-changelog-line-too-long
See-also: https://lintian.debian.org/tags/debian-changelog-line-too-long.html
commit 138ed7be8aba4f1199a5f97ce6f7d07209265ab8
Author: Debian Janitor <janitor@jelmer.uk>
Date: Mon Oct 7 21:48:57 2019 +0000
Fix day-of-week for changelog entries 3.63, 3.13.
Fixes lintian: debian-changelog-has-wrong-day-of-week
See https://lintian.debian.org/tags/debian-changelog-has-wrong-day-of-week.html for more details.
commit 74a65195db3e5a2be90171779c61188931ecf088
Author: Debian Janitor <janitor@jelmer.uk>
Date: Mon Oct 7 21:48:42 2019 +0000
Bump debhelper from old 9 to 12.
Fixes lintian: package-uses-old-debhelper-compat-version
See https://lintian.debian.org/tags/package-uses-old-debhelper-compat-version.html for more details.
commit c9f0de0b2c77bdafed9c18ba586e6d001bf976c7
Author: Debian Janitor <janitor@jelmer.uk>
Date: Mon Oct 7 21:48:26 2019 +0000
Trim trailing whitespace.
Fixes lintian: file-contains-trailing-whitespace
See https://lintian.debian.org/tags/file-contains-trailing-whitespace.html for more details.
commit fa79d84efd98c762ddbc4c6649ef643a17022567
Author: Ondřej Nový <onovy@debian.org>
Date: Mon Oct 1 10:25:53 2018 +0200
d/changelog: Remove trailing whitespaces
