Git log: commit 0ad6c8bd2a77eefeb84dfadbc83150154372450b
Merge: 04fbb08 efc3d6e
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 25 16:46:30 2024 +0000
Merge branch 'fix-test-lxd-ubuntu' into 'master'
d/tests: make the lxd test work on Ubuntu
See merge request ci-team/autopkgtest!335
commit 04fbb088f67afd49c5f1fd567187c5eb594dbcfc
Merge: 00b40a0 d6ef4d8
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 25 15:38:26 2024 +0000
Merge branch 'fix-unshare-test-if-restricted' into 'master'
d/t/unshare: better check whether we should skip the test
See merge request ci-team/autopkgtest!333
commit 00b40a0db841cfd8ceaaee592e500516eac4b688
Merge: c984ad8 2ac31f4
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 25 15:29:59 2024 +0000
Merge branch 'skia/set_fqdn' into 'master'
ssh-setup/nova: explicitely set 'fqdn' in cloud-init
See merge request ci-team/autopkgtest!334
commit efc3d6e2a14056a0ecb1a4b54af4ca3d8f3ba38d
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 25 17:09:16 2024 +0200
d/tests: make the lxd test work on Ubuntu
commit 2ac31f4fd6f0f70e6cbe4c4ee7f18fe86dd82dd5
Author: Florent 'Skia' Jacquet <florent.jacquet@canonical.com>
Date: Thu Apr 25 13:28:33 2024 +0100
ssh-setup/nova: explicitely set 'fqdn' in cloud-init
Letting openstack set the fqdn adds an unwanted variable to the test
run, and can lead to unexpected results like the one described in
LP #2019472. Let's set the fqdn to a fixed value, as we do for the
hostname.
commit d6ef4d82ebed86a875c218d30a8b5d55a1d58d78
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 25 10:38:42 2024 +0200
d/t/unshare: skip test if kernel.apparmor_restrict_unprivileged_userns=1
Replaces the previous `unshare ... true` test, which was not really
meaningful.
commit c984ad8cf82e3f794ae3717f4c414308ca4a1829
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 24 14:38:35 2024 +0200
create-sources.list-for-pocket: drop outdated (now wrong) comment
Gbp-Dch: ignore
commit 9160871fca6f21016eb93aa971cc340086574c73
Merge: 839e702 a111813
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 24 08:10:55 2024 +0000
Merge branch 'master' into 'master'
Fix a couple of bugs in autopkgtest-build-lxd
See merge request ci-team/autopkgtest!331
commit a11181378f7b7c2a04758c9d04f55934489431d1
Author: Frode Nordahl <fnordahl@ubuntu.com>
Date: Wed Apr 24 08:47:21 2024 +0200
autopkgtest-build-lxd: Add missing remote prefix in get_boot_id().
Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
commit 287e463300eee924d1879498a879edd2f4634f43
Author: Frode Nordahl <fnordahl@ubuntu.com>
Date: Wed Apr 24 08:40:32 2024 +0200
autopkgtest-build-lxd: Extract lxc client version correctly.
The outut from `lxc version` might look like:
Client version: 5.20
Server version: 5.20
It might also look like:
Client version: 5.21.1 LTS
Server version: 5.21.1 LTS
The current code does not handle the latter version, make use of
awk to extract the string in the third position instead.
Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
commit 839e702b3056a3661e7b07a819760d2f999bc373
Merge: 8c9cce6 1b43d9f
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 23 11:10:38 2024 +0000
Merge branch 'test-podman-ubuntu' into 'master'
d/t/podman: when dpkg-vendor is Ubuntu, test on Ubuntu containers
See merge request ci-team/autopkgtest!330
commit 1b43d9fd063e7c64ef3f0e9f3598c531b5d67b19
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 23 11:48:14 2024 +0200
d/t/control: podman: add test dependency on fakeroot
Fixes these failures happening on Ubuntu:
FAIL: test_dsc_build_needed_success (__main__.PodmanRunner.test_dsc_build_needed_success)
FAIL: test_timeout (__main__.PodmanRunner.test_timeout)
Failure mode:
AssertionError: 25 != 0 : b'dpkg-buildpackage: error: fakeroot not found,
either install the fakeroot\npackage, specify a command with the -r option,
or run this as root\n'
Gbp-Dch: ignore
commit d51db850f6fae63d1f32ff6c75f985bda20fb721
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 23 11:26:45 2024 +0200
d/t/podman: when dpkg-vendor is Ubuntu, test on Ubuntu containers
Same approach of 0a18fe9037239f1d20ebea643a8a3181c0dbbd33.
commit 8c9cce6509677de9941f5083044959220c1faedd
Merge: bda4462 c3cae23
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 23 09:11:54 2024 +0000
Merge branch 'test-docker-ubuntu' into 'master'
d/t/docker: when dpkg-vendor is Ubuntu, test on Ubuntu containers
See merge request ci-team/autopkgtest!329
commit c3cae23f786a56d6450d9799d33049e20c696353
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 23 10:29:50 2024 +0200
d/t/docker: when dpkg-vendor is Ubuntu, test on Ubuntu containers
Same approach of0a18fe9037239f1d20ebea643a8a3181c0dbbd33.
commit bda44625e88fe12a6401931f3848b4c908431348
Merge: c147432 0a18fe9
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 22 21:34:09 2024 +0000
Merge branch 'test-lxc-ubuntu' into 'master'
d/t/lxc: when dpkg-vendor is Ubuntu, test on Ubuntu containers
See merge request ci-team/autopkgtest!327
commit 0a18fe9037239f1d20ebea643a8a3181c0dbbd33
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 22 19:01:53 2024 +0200
d/t/lxc: when dpkg-vendor is Ubuntu, test on Ubuntu containers
commit c147432d178f96fce12ec1af29206b8fd4a4b89f
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 22 13:47:24 2024 +0200
t/autopkgtest: delete stray docstring
Looks like this 'docstring' originally belonged to one of the test_*
functions, not to the common do_apt_pocket_test().
commit b3cf635c7e2564eb9a860543518a275f12f81051
Merge: 5ea6105 0ec6116
Author: Paride Legovini <paride@debian.org>
Date: Sat Apr 20 13:06:42 2024 +0000
Merge branch 'unshare-test-skip-if-broken' into 'master'
d/t/unshare: skip test (exit 77) if simple unshare command fails
See merge request ci-team/autopkgtest!323
commit 0ec611673de2ccdd16fd53a74122e78841406b74
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 17 22:56:53 2024 +0200
d/t/unshare: skip test (exit 77) if simple unshare command fails
For some reason this happens on some Ubuntu VMs:
# unshare --map-auto --map-root-user true
newuidmap: uid range [1-65537) -> [100000-165536) not allowed
# echo $?
1
I am not sure of what denies the UID mapping, but in any case I believe
it makes sense to skip the unshare test if such a command fails, as it
means that unshare support is broken for reasons independent from
autopkgtest.
commit 5ea6105d404d8e21594adbde9c60d72688b0d6e0
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 15 14:53:25 2024 +0200
r/autopkgtest: fix typo
Gbp-Dch: ignore
commit cf4ad4fdbbe4ac5cbf27945732d300ea08f5e246
Merge: fe47f41 164f314
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 15 11:01:44 2024 +0000
Merge branch 'pre-commit-codespell' into 'master'
Run codespell in pre-commit; fix typos
See merge request ci-team/autopkgtest!318
commit fe47f41b6976e6c43c8e9634f4551dc9ebf1a287
Author: Paride Legovini <paride@debian.org>
Date: Fri Apr 12 17:47:22 2024 +0200
Add comment on the apt "pin by source package" syntax
Gbp-Dch: ignore
commit 517e5012cebb16163935fcc300d086ff4d94d7a9
Merge: a54d621 1330c1f
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 11 12:51:23 2024 +0000
Merge branch 'skia/improve_build_lxd' into 'master'
tools/a-b-lxd: make sure the reboot happens when needed
See merge request ci-team/autopkgtest!319
commit a54d62107e0a9f83b2c8767943146970cb95fed5
Merge: 1f19d35 2dd018b
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 11 12:21:49 2024 +0000
Merge branch 'clarify-package-list-comment' into 'master'
Improve comment on missing Package-List arch field
See merge request ci-team/autopkgtest!321
commit 1330c1fbd27d77c9ab62b31e047f4f8c6b314acb
Author: Florent 'Skia' Jacquet <florent.jacquet@canonical.com>
Date: Tue Apr 9 16:33:09 2024 +0200
tools/a-b-lxd: make sure the reboot happens when needed
When issuing the reboot command, there is no blocking mechanism that
ensures the reboot was actually performed. When the host machine is
under heavy load, the reboot can actually take some time, and the
`wait_reboot` function instantly passes, because the container is still
fully booted, but has already queued a reboot. When that situation
happens, the rest of the script tries to keep going until it fails to
run any step because the container is now really rebooting.
This patch ensures that when we want to reboot, we actually wait for it
to happen, by checking that the `boot_id` has actually changed.
commit 2dd018ba2b11c4f5f8bb04411f2bfe25d7f61ab3
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 10 15:23:40 2024 +0200
Improve comment on missing Package-List arch field
I also slightly modified the condition logic, turning it from if/else to
if/continue, to make it easier to drop support for source packages built
with ancient tooling when the day will come: just drop the if/continue
block.
Also: add extra newline in the same code block (cosmetic).
Gbp-Dch: ignore
commit 1f19d35701cb606c09b3ce741a31e436a6c74a11
Merge: 701ddb3 b64ac76
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 10 13:40:45 2024 +0000
Merge branch 'bump-vmdb2-suggests' into 'master'
d/control: bump versioned Suggests: vmdb2 to >= 0.25-1
See merge request ci-team/autopkgtest!320
commit b64ac76eedc9e4432ca09c88c0108b522dfd27d8
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 10 14:22:57 2024 +0200
d/control: bump versioned Suggests: vmdb2 to >= 0.25-1
Thanks: Christian Kastner
commit 164f314c50d5e7fad0ea9e041531ff785850cc21
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 10 10:25:27 2024 +0200
pre-commit: update pre-commit/pre-commit-hooks pin to v4.6.0
commit c02a58eb74d503d2be3edb78f0ff6070de41d5e8
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 10 10:23:32 2024 +0200
pre-commit: add check-toml, now that we have one to check
commit c966722d7d64bc573007c536b6ce24193b25321e
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 9 16:47:49 2024 +0200
Fix typos spotted by codespell
commit 519fb8340e4fb7966d3e3ca229848021bae010ee
Author: Paride Legovini <paride@debian.org>
Date: Tue Apr 9 16:08:12 2024 +0200
pre-commit: add codespell hook
commit 701ddb3dcffbc52bb686de187ace9a00faa652f2
Merge: b3e82f2 b86576a
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 8 15:35:40 2024 +0000
Merge branch 'satdep-via-bd' into 'master'
Resolve and install test dependencies as build dependencies
See merge request ci-team/autopkgtest!313
commit b3e82f2a36254e86d41eb97839b3d40bbab8bebf
Merge: a685761 e022826
Author: Paride Legovini <paride@debian.org>
Date: Mon Apr 8 13:53:15 2024 +0000
Merge branch 'add-pre-commit-config' into 'master'
Add pre-commit-config and run the checks in CI
See merge request ci-team/autopkgtest!314
commit b86576aa47f6f95985c3be46e4a4e20278da4511
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 3 15:07:31 2024 +0200
Resolve and install test dependencies as build dependencies
This has two advantages:
1. By listing test dependencies as Build-Depends of a satdep.dsc source
package, and installing them via `apt-get build-dep satdep.dsc`, we
don't need to install and then purge the satdep package itself, as it
never gets installed.
2. apt-get build-dep supports the -a/--host-architecture flag, which
allows dependencies to be resolved for a foreign architecture.
This will enable running tests in a foreign dpkg architecture.
In the future we may want to switch to `apt-get satisfy -a` to install
test dependencies. However that's only supported since apt 1.9.0 (Debian
Bullseye, Ubuntu Focal), and we don't want to introduce a third way to
resolve/install test dependencies. Let's do this after the testbed
baseline is bumped to Debian Stretch and Ubuntu Xenial, and support for
installing test dependencies via the binary satdep.deb is dropped.
commit 50b3065ddaedf135831f96d28e083430e489fd4e
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 3 14:48:29 2024 +0200
Move mock satdep .deb generation code to separate function
Straightforward refactor to make further changes easier.
Gbp-Dch: ignore
commit a6857615be9a65e665e7ec22cea3d2304653eb5d
Merge: 0328c1c 3781b4f
Author: Paul Gevers <elbrus@debian.org>
Date: Sat Apr 6 10:21:03 2024 +0000
Merge branch 'find-source-version-skip-udeb' into 'master'
find_source_version_to_download: do not consider udebs
See merge request ci-team/autopkgtest!317
commit 3781b4f80f674af49f19f0a8f70e42015714adce
Author: Paride Legovini <paride@debian.org>
Date: Fri Apr 5 13:10:39 2024 +0200
find_source_version_to_download: do not consider udebs
When "reverse-resolving" maybe-pinned binary packages to test to a
source package to download, do not consider udeb packages (and possibly
other non-deb packages) as candidate binary packages.
A concrete (trimmed down) example where not skipping udebs causes issues
is the following. Two versions of the package to test are available:
```
Package: linux-aws-5.15
Version: 5.15.0-1056.61~20.04.1
Package-List:
linux-aws-5.15-cloud-tools-5.15.0-1056 deb devel optional arch=amd64,arm64 profile=!stage1
linux-aws-5.15-headers-5.15.0-1056 deb devel optional arch=all profile=!stage1
linux-aws-5.15-tools-5.15.0-1056 deb devel optional arch=amd64,arm64 profile=!stage1
linux-udebs-aws udeb debian-installer optional arch=amd64,arm64 profile=!stage1+!noudeb+!cross+!autopkgtest
Package: linux-aws-5.15
Version: 5.15.0-1057.63~20.04.1
Package-List:
linux-aws-5.15-cloud-tools-5.15.0-1057 deb devel optional arch=amd64,arm64 profile=!stage1
linux-aws-5.15-headers-5.15.0-1057 deb devel optional arch=all profile=!stage1
linux-aws-5.15-tools-5.15.0-1057 deb devel optional arch=amd64,arm64 profile=!stage1
linux-udebs-aws udeb debian-installer optional arch=amd64,arm64 profile=!stage1+!noudeb+!cross+!
```
Given that "We only consider binaries which are shipped in all available
versions" (see docstring), only the udeb remains in the intersection,
but as the udeb is not really known to apt the function eventually fails
to find a suitable source package. By ignoring the udeb (what this
commit does) we fall into the "same source ships non-overlapping
sets of binaries" case (again: see docstring and comments), and
everything works as expected.
commit 0328c1cac54d8bdb066d9c875035d99c86f4fb41
Merge: 933bd29 57351be
Author: Paride Legovini <paride@debian.org>
Date: Fri Apr 5 10:03:30 2024 +0000
Merge branch 'dep-drop-broken-debugging' into 'master'
install_apt: drop broken debugging stage
See merge request ci-team/autopkgtest!316
commit 57351be372998b8b952a12b8469adacbafe2a14d
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 4 13:01:49 2024 +0200
install_apt: drop broken debugging stage
This reverts 70cd342682742cfdf1229ee5a5ceb6193e36f2c4.
When installing test dependencies, we can't simply run
apt-get install <dependencies>
because <dependencies> can be a complex dependency string with
versioned dependencies, or architecture specific dependencies,
and `apt-get install` is unable to handle that. This is why we
use the "satdep" dummy package. For the same reason we can't run
apt-get install --simulate <dependencies>
to help debugging: the output of that command can be very misleading,
or the command can be completely broken. For example, a dependency on
`foo (>> 42)` or on `foo | bar` will cause shell syntax errors, with
no useful debugging output being printed.
commit 933bd29bb628bad8a66b877298ebcfaeb4aa41a6
Merge: be97310 c614861
Author: Paride Legovini <paride@debian.org>
Date: Thu Apr 4 13:16:02 2024 +0000
Merge branch 'qemu-ubuntu-fixes' into 'master'
qemu: Make Ubuntu images buildable again with autopkgtest-build-qemu
See merge request ci-team/autopkgtest!315
commit e022826f6094d3db5fd31f4e093e94f28d1174b3
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 3 19:29:47 2024 +0200
autopkgtest-virt-docker.1: remove trailing spaces
Spotted by pre-commit.
Gbp-Dch: ignore
commit 6ce7792bce425c411bc56f8044af9909ab230fc4
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 3 17:54:16 2024 +0200
Run pre-commit checks in CI
commit c61486159799b69f95e5a3623958861e5dc28575
Author: Christian Kastner <ckk@debian.org>
Date: Thu Apr 4 13:50:28 2024 +0200
qemu: Drop ifupdown from image creation
It's already installed during debootstrapping, if necessary.
For Debian, this was tested going back to Jessie. For Ubuntu, this was
testing going back to Trusty, with Xenial being the last release to
install it.
commit 10c680c52c911c71201ec2a3c575e4054dee9ce5
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 3 17:48:01 2024 +0200
gitlab-ci.yml: fix missing document start "---"
Gbp-Dch: Ignore
commit 895256105843bc0ae2ea2c6f6805ea0f1eb07c35
Author: Paride Legovini <paride@debian.org>
Date: Wed Apr 3 17:44:50 2024 +0200
Add pre-commit-config and yamllint configuration
The pre-commit-config only have some basic checks for now,
more can be added incrementally.
