Debian changelog in Git: dpkg (1.20.0) UNRELEASED; urgency=medium
[ Guillem Jover ]
* libdpkg: Do not generate a backup file for the available database.
Closes: #343578
* perl: Switch Getopt::Long from bundling to bundling_values. This means
the few scripts using Getopt::Long will stop accepting options in the
form «-ab» for «-a -b», which is not future-proof, as it does not allow
these options to get new arguments without making them abiguous.
* dpkg-buildpackage: Remove transient backwards R³ compatibility code.
* buildtools.mk: Add support for nostrip in DEB_BUILD_OPTIONS when setting
the STRIP variable.
* dpkg-genbuildinfo: Do not include irrelevant packages in the Binary field.
* dpkg: Do not clear selections for unknown packages. Closes: #927752
* dpkg-shlibdeps: Add support for new Build-Depends-Packages, to be able
to specify multiple packages. Closes: #926669
Based on a patch by Frank Schaefer <kelledin@gmail.com>.
* perl: Remove support for versioned GnuPG 2 program and packages.
* libdpkg: Clarify lock contender error message. Print the PID of the lock
contender, and add a warning explaining that removing the lock file is
never the correct solution.
* dpkg-genchanges, dpkg-mergechangelogs: Remove support for ~vola
versioning, as volatile.debian.org was decommissioned some time ago.
* dpkg-genchanges, dpkg-mergechangelogs: Match ~deb also as a backport
marker in versions. Closes: #934980
* libdpkg, dpkg: Use new versiondescribe_c() for non-localizable call sites,
such as when writing to a log, which should not be localized.
Reported by Julien Cristau <jcristau@debian.org>.
* dpkg-query: Try to use the package synopsis from the available file if
not installed. Closes: #43573
* dpkg-gencontrol: Take into account hardlinks when computing the
Installed-Size substvar. Closes: #923475
Patch co-authored with Sven Joachim <svenjoac@gmx.de>.
* dpkg: Fix and clarify behavior for packages marked to be on “hold”. These
need to be processed for configuration and triggers. Closes: #926472
* dpkg: Use DPKG_ADMINDIR to set the admindir. Closes: #900071
* dpkg-source: Remove backwards compatibility code for legacy build-profiles.
* perl: Give more context on field parsing errors. Closes: #637060
* dpkg-buildpackage: Add option to sanitize environment. Closes: #843776
* update-alternatives: Cope with a missing administrative directory.
* update-alternatives: Create the administrative directory on demand.
* dpkg-split: Cope with a missing parts/ database directory.
* dpkg-split: Create the parts/ database directory on demand.
* libdpkg: Consider msdbrw_needsuperuser equivalent to msdbrw_write, so
the same checks are performed on normal non --force-not-root operation.
* libdpkg: Add support for bootstrapping the installation of dpkg:
- Create the logfile with correct permissions, and remove the code
setting up the logfile from the dpkg postinst.
- Allow missing status and available databases, so that they get created
on write, and remove the code setting them up from the dpkg postinst.
Closes: #647911
- Do not change the ownership of the triggers database directory. Either
we are running as root:root which means the ownership should be correct
already, or we are not which means we cannot change it anyway.
- Create the dpkg database directory on demand.
- Create the updates/ database directory on demand.
- Create the info/ database directory on demand.
* dpkg-architecture: Fix handling of exec failing in --command.
Reported by Helmut Grohne <helmut@subdivi.de>.
* dpkg-buildpackage: Do not accept equal signs as part of the hook names.
Reported by Daniel Shahaf <danielsh@apache.org>. Closes: #948291
* dselect: Mark a string for translation.
* dselect: Cleanup access methods:
- Remove harddisk methods, as they were non-functional due to fdisk
interface changes, and do not make sense anymore as we can expect users
to mount any such filesystem on their own, to then use a filesystem
method instead. Prompted by Helmut Grohne <helmut@subdivi.de>.
- Remove cdrom method superseded by the multi_cd method.
- Remove nfs methods, as there is nothing special about NFS, and mounting
these should just be left to the local admin, who can mount any other
remote filesystem too.
- Remove multi_mount method, as the multi_cd method can take care of
mounting the necessary images or devices.
- Replace changelog with correct copyright in file header.
* dpkg, dselect: Stop using first-person singular in output messages.
* libdpkg: Fix memory leak in parsedb context close.
* Perl modules:
- Dpkg::Source::Package: Verify original tarball signatures at build time.
- Dpkg::BuildFlags: Add new unset() method.
Requested by Daniel Schepler <dschepler@gmail.com>.
- Dpkg::Source::Package::V2: Emit a special patch header on
single-debian-patch. Closes: #933152
- Dpkg::Vendor::Debian: Only scan /usr/local/ directories that exist.
Closes: #932967
- Dpkg::Vendor::Debian: Do not set -Werror=implicit-function-declaration
for C++. Closes: #939969
- Dpkg::Deps: Check for valid virtual package version relations. Do not
allow non-equal version relations in virtual provides. Closes: #930317
- Dpkg: Remove internal lowercase variables $version, $progname,
$admindir, $dpkglibdir and $pkgdatadir.
- Dpkg::Changelog: Remove obsolete methods dpkg() and rfc822().
- Dpkg::Changelog::Entry::Debian: Remove obsolete methods check_header()
and check_trailer(). Hide variables $regex_header and $regex_trailer.
- Dpkg::Changelog::Parse: Remove warnings of obsolete options forceplugin
and libdir. Remove obsolete functions changelog_parse_debian() and
changelog_parse_plugin().
- Dpkg::Compression: Hide internal lowercase variables
$default_compression, $default_compression_level and
$compression_re_file_ext.
- Dpkg::Deps::KnownFacts: Remove obsolete check_package() method.
- Dpkg::Exit: Hide internal lowercase @handlers variable.
- Dpkg::Gettext: Remove obsolete _g() function.
- Dpkg::Source::Package: Hide internal lowercase variable
@tar_ignore_default_pattern. Remove iternal lowercase variable alias
$diff_ignore_default_regexp.
- Dpkg::Substvars: Remove obsolete no_warn() method.
- Dpkg::Index: Change default value for unique_tuple_key to 1.
- Dpkg::Version: Remove deprecation warning from semantic change in
bool overload.
- Dpkg::Checksums: Remove obsolete 'program' property warning.
- Dpkg::Conf: Remove obsolete methods and obsolete croak for method option.
- Dpkg::Vendor: Remove obsolete 'keyrings' hook.
- Dpkg::Exit: Unregister all signal handlers once we have executed them.
Closes: #932841
- Dpkg::Exit: Register exit handlers also for __DIE__.
- Dpkg::Source::Package::V3::Native: Do not say v1.0 for 3.0 formats.
- Dpkg::Dist::Files: On filename parse error say file instead of package.
- Dpkg::Substvars: Add new vendor:Name and vendor:Id substvars.
* Documentation:
- man: Fix uncommon wording constructs.
- man: Use a minus sign for a literal string.
- man: Clarify that the pager is called via «$SHELL -c».
- dpkg-shlibdeps: Document split_soname() function.
Prompted by Christopher Crim <christopher.crim@quoininc.com>.
- Dpkg::Changelog: Document methods provided by subclasses.
Reported by Felix Lechner <felix.lechner@lease-up.com>.
- man: Globally adjust left and disable hyphenation.
- man: Split dselect(1) --color from --colour option items.
- man: Describe the SONAME formats supported in deb-shlibs(5).
- man: Move template symbol documentation into new deb-src-symbols(5).
- Dpkg::Changelog::Parse: Remove $ sigil from option names in POD.
- Dpkg: Say class instead of object when appropriate.
- Dpkg::Changelog: Clarify that these classes inherit from some other
base class, which will contain the missing documentation.
Prompted by intrigeri <intrigeri@debian.org>.
- man: Clarify deb-changelog(5) format. Closes: #946780
- man: Clarify debian/source/include-binaries format in dpkg-source(1).
Prompted by Felix Lechner <felix.lechner@lease-up.com>.
- man, doc: Clarify that the postinst "triggered" argument gets the
trigger-name(s) as a space-separated list in the second argument.
Prompted by Michael Biebl <biebl@debian.org>.
- dselect: Update the multicd README file.
- doc, man: Mark T and I package instances to avoid misreadings.
* Code internals:
- Dpkg::Source::Package: Refactor original tarball handling.
- perl: Use File::Copy instead of spawning mv/cp commands.
- Dpkg::OpenPGP: Refactor signature verification into a new function.
- Dpkg::OpenPGP: Make it possible to verify detached signatures.
- Dpkg::OpenPGP: Add support for importing an OpenPGP key into a keyring.
- Dpkg::BuildFlags: Remove unused hash keys.
- libdpkg: Use the variable instead of a type as sizeof() argument.
- libdpkg: Use the totalwritten variable for a consistency check.
- dselect: Reduce scope of variable, to avoid it being unused in a branch.
- dpkg-deb: Fold two adjacent if conditionals into a single one.
- dpkg: Initialize flagdeppossi in check_conflict().
- libdpkg: Add new C locale switch over support.
- libdpkg: Add new versiondescribe_c() to force a C locale.
- dselect: Make baselist::draw_column_*() col arguments const.
- libdpkg: Use p instead of name in dpkg_arch_name_is_illegal().
- dpkg: Remove redudant condition for sourcefile in updateavailable().
- dpkg, update-alternatives: Make variables static.
- libdpkg: Add missing symbols to the version map.
- libdpkg: Fix fiemap memory layout usage that confuses gcc 10 to emit a
warning.
- libdpkg: Only use varbuf_printf() in pkg_format_show() when necessary.
This should speed up «dpkg-query --show» formatting.
- libdpkg: Fix package format string to be a string literal.
This suppresses a gcc warning.
- dpkg: Fix short lived memory leak in --force-help handling.
- dpkg-split: Fix short lived file descriptor leak in --auto.
- start-stop-daemon: Explicitly ignore uninmportant function return values.
- start-stop-daemon: Fix memory leak on multiple --chuid arguments.
- start-stop-daemon: Close the notification socket in the child.
- libdpkg: Fix memory leaks in zlib and bz2 decompression functions.
- libdpkg: Add new dir_make_path() and dir_make_path_parent() functions.
- libdpkg: Add new atomic file flag to create the base path when missing.
- libdpkg: Fix modstatdb_rw enum comments.
- libdpkg, dpkg-query: Optimize db-fsys:Files virtual variable loading.
We load either the entire db-fsys for all packages, possibly optimized
per platform (such as by using fiemap), or the specific ones for the
requested packages. This also fixes a problematic cast removing the
constness of a variable.
- Dpkg::Dist::Files: Document the two filename pattern formats.
- update-alternatives: Remove redundant condition in argument parser.
- update-alternatives: Move error context setup before calling setjmp(),
so that cppcheck stops being confused.
- test: Reformat 200_Dpkg_Shlibs.cpp for coding style conformance.
- dpkg: Make it possible for the compiler to check printf() format
string arguments on dependency printer.
- dselect: Reorder branches in packagelist::deselect_one_of so that they
are not duplicated.
- dselect: Use nullptr instead of NULL.
- dselect: Use static_cast<> instead of old-style type qualifier cast.
- dselect: Do not use unnecessary old-style casts.
- dselect: Fix variable types to avoid needing old-style casts.
- libcompat: Disarm libselinux setexecfilecon() declaration for
libcompat-test.
- libdpkg: Define new VARBUF_OBJECT macro.
- libdpkg: Add new ATOMIC_FILE_NORMAL enum value to avoid a cast in C++.
- libdpkg: Use a new DPKG_NULL macro that works in C and C++.
- libdpkg: Use a new DPKG_STATIC_CAST macro that works in C and C++.
- libdpkg: Move printing of errno into dpkg_error_set().
- libdpkg: Use a varbuf to store the problem messages per parsedb context.
- libdpkg: Fix Doxygen comments.
* Build system:
- Bump minimal Perl version to 5.24.1.
- Add a serial versioning to the m4 files.
- Install m4 files into system aclocal directory.
- Bump minimal gettext version to 0.19.8, to get the m4 files that can
cross-build for musl-based systems.
- Enable more compiler warnings.
- Update Doxygen configuration from version 1.8.16.
* Packaging:
- Remove obsolete Breaks satisfied since oldstable.
- Replace custom rule for 'configure' with call to dh_autoreconf.
Thanks to Dan Streetman <ddstreet@canonical.com>. Closes: #939516
- dselect: Remove methods state files on purge.
Spotted by Sven Joachim <svenjoac@gmx.de>.
- Switch to debhelper compatibility level 12.
- Switch from debian/compat to debhelper-commpat in Build-Depends.
- Bump Standards-Version to 4.5.0 (no changes required).
* Test suite:
- Remove perlcritic Documentation::RequirePodLinksIncludeText suppression.
- Clarify cppcheck va_list_usedBeforeStarted suppression.
- Skip build directories from codespell check.
- Update stopwords for codespell 1.16.0.
- Suppress new bogus cppcheck 1.90 false positives.
- libdpkg: Remove redundant assignment in t-ehandle unit test.
- Skip backup files from codespell check.
[ Updated programs translations ]
* German (Sven Joachim).
* Portuguese (Miguel Figueiredo). Closes: #935695
* Simplified Chinese (Mo Zhou). Closes: #942195, #945776
[ Updated dselect translations ]
* German (Sven Joachim).
[ Updated scripts translations ]
* German (Helge Kreutzmann).
[ Updated man pages translations ]
* German (Helge Kreutzmann). Closes: #931135
-- Guillem Jover <guillem@debian.org> Fri, 07 Jun 2019 18:00:53 +0200
Git log: commit 506b5d45d9a12eecb5718043db91f094297c04a2
Author: Sven Joachim <svenjoac@gmx.de>
Date: Fri Feb 14 18:14:53 2020 +0100
German dpkg translation update
Update to 1140t.
commit 9c1413408a4d9c5d3f1b76b0324361f6deee0d98
Author: Guillem Jover <guillem@debian.org>
Date: Wed Feb 12 02:28:11 2020 +0100
libdpkg: Fix Doxygen comments
commit 52ad6fa24e8663a1c522da274a174ae6ba24a4cc
Author: Guillem Jover <guillem@debian.org>
Date: Sun Feb 9 19:44:06 2020 +0100
doc: Update Doxygen configuration from version 1.8.16
commit b81acba9f358d63b38ad76508bc4baaa4786d935
Author: Guillem Jover <guillem@debian.org>
Date: Fri Feb 7 03:05:12 2020 +0100
build: Enable more compiler warnings
commit ac22e69bf7d4832bb1ed0ed681591e80a50d5b18
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:36:38 2020 +0100
libdpkg: Use a varbuf to store the problem messages per parsedb context
This both simplifies the code, gets rid of a static variable, and
squashes a warning due to non-literal format strings.
Warned-by: clang-10 -Wformat-nonliteral (from -Wformat=2)
commit 3d4ecf6f9ce5093a31fb1958ea09718d05505186
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:34:29 2020 +0100
libdpkg: Move printing of errno into dpkg_error_set()
This simplifies the code, and squashes a warning.
Warned-by: clang-10 -Wformat-nonliteral (from -Wformat=2)
commit 33f375f87425ad26e85ba4c27beaf6296ea72d98
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:12:44 2020 +0100
libdpkg: Use a new DPKG_STATIC_CAST macro that works in C and C++
Warned-by: clang++-10 -Wold-style-cast
commit bfee5cd63ca0786d7cc55c8593f198c0b9ed2f40
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:03:38 2020 +0100
libdpkg: Use a new DPKG_NULL macro that works in C and C++
Warned-by: clang++-10 -Wzero-as-null-pointer-constant
commit 3fd4a7b3b4887c77a6315b724d5a1af6b5cba238
Author: Guillem Jover <guillem@debian.org>
Date: Sat Feb 1 19:34:57 2020 +0100
libdpkg: Add new ATOMIC_FILE_NORMAL enum value to avoid a cast in C++
Warned-by: g++ -Wold-style-cast
commit 7b8236d8d782aa578070b10ed736afd423d08dc9
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:33:11 2020 +0100
libdpkg: Define new VARBUF_OBJECT macro
commit f7a488d68bfb1070043a462b2d05944a819d367d
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:33:58 2020 +0100
libdpkg: Fix memory leak in parsedb context close
commit c3afad847701370dd45ec58414580115c8ea1d2c
Author: Guillem Jover <guillem@debian.org>
Date: Fri Feb 7 12:30:52 2020 +0100
libcompat: Disarm libselinux setexecfilecon() declaration for libcompat-test
When building the selinux module as part of the libcompat-test library,
that takes care of making sure the libcompat code can compile all the
time, we are redeclaring the symbol which causes a compiler warning.
Remap the symbol while we include the libselinux headers and then remove
the remapping so that ours is used.
Warned-by: gcc -Wredundant-decls
commit 371662f160c4c71afe79eb6f277dc0a2419bee17
Author: Guillem Jover <guillem@debian.org>
Date: Sun Mar 25 05:08:22 2018 +0200
dselect: Fix variable types to avoid needing old-style casts
Warned-by: g++ -Wold-style-cast
commit 428483f603e539f60e738f2ed1859b92852c3870
Author: Guillem Jover <guillem@debian.org>
Date: Sun Mar 25 05:08:22 2018 +0200
dselect: Do not use unnecessary old-style casts
Warned-by: g++ -Wold-style-cast
commit a7b4a9ae06acdffb46313b76e91c0a40b7b1b63c
Author: Guillem Jover <guillem@debian.org>
Date: Thu Feb 23 03:47:43 2017 +0100
dselect: Use static_cast<> instead of old-style type qualifier cast
Warned-by: g++ -Wcast-qual
commit 398844386310471db42a7af98bf885e4162728f2
Author: Guillem Jover <guillem@debian.org>
Date: Tue Feb 4 04:06:24 2020 +0100
dselect: Use nullptr instead of NULL
Warned-by: clang-10 -Wzero-as-null-pointer-constant
commit 4f00cb936f15ee01763e23c5bbfa25cc384cfa88
Author: Guillem Jover <guillem@debian.org>
Date: Sat Feb 1 19:30:15 2020 +0100
dselect: Reorder branches so that they are not duplicated
Change the branches to alternate, instead of having the last two being
equal which trigger this warning. This makes the code easier to follow
as it's symmetric for all cases.
Warned-by: gcc -Wduplicated-branches
commit bedfaeb58945622d19ed2bbb2eaf65b8f6152b5d
Author: Guillem Jover <guillem@debian.org>
Date: Tue Mar 2 00:25:59 2010 +0100
dpkg: Make it possible for the compiler to check printf format
By using the format as a string literal in the actual function we let
the compiler check for its validity against the arguments passed.
Warned-by: gcc -Wformat-nonliteral (from -Wformat=2)
commit 4e80526259046215c52f4024c7e4bc4fbdc6cd71
Author: Guillem Jover <guillem@debian.org>
Date: Tue Mar 2 00:24:44 2010 +0100
t/200_Dpkg_Shlibs: Reformat for coding style conformance
commit f9a05d7cfe6492bd903eeeabe8d36f115386cff3
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Sun Feb 2 06:50:39 2020 +0100
Update German translation of manual pages
Update to 3022t.
Includes further proofreading on debian-l10n-german
commit d3a02acdca7515e24ff268f02a93d1b5b655c200
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Sun Feb 2 06:24:30 2020 +0100
Add one missing markup
commit ee84837df531a8f6b569fe99c049a30ccc8b9021
Author: Sven Joachim <svenjoac@gmx.de>
Date: Sat Feb 1 18:13:59 2020 +0100
German dselect translation update
Update to 275t.
commit efbd608a51740e5a67aeb85de3a953c721c90664
Author: Sven Joachim <svenjoac@gmx.de>
Date: Sat Feb 1 18:13:46 2020 +0100
German dpkg translation update
Update to 1140t.
commit 3e3c4b160a4fe21ec73539a8cf5b013ea05ff99e
Author: Guillem Jover <guillem@debian.org>
Date: Sat Feb 1 04:16:46 2020 +0100
dpkg, dselect: Stop using first-person singular in output messages
It is very strange reading the computer/program talk to the user in
first-person singular, and it's a practice that has been discouraged
for a while now.
commit 2f7e8b6ee7812a105c38beb978401954774aa9eb
Author: Guillem Jover <guillem@debian.org>
Date: Sat Feb 1 03:51:57 2020 +0100
doc, man: Mark T and I package instances to avoid misreadings
Using “I” without any kind of marking makes it hard to read, as it can
easily get confused with the first-person singular pronoun.
commit ceb024b410612c70b63e5efe53e5c06b7fed3ef2
Author: Guillem Jover <guillem@debian.org>
Date: Fri Jan 31 03:41:54 2020 +0100
dselect: Replace changelog with correct copyright in file header
This made sense when the method was in a different source package,
but it stopped making sense when it got merged into dpkg proper.
commit 733f459fc6c7c318bb3893ec9b63731dfb6c573a
Author: Guillem Jover <guillem@debian.org>
Date: Fri Jan 17 00:58:34 2020 +0100
dselect: Remove multi_mount method
commit 18119725a55b359926ad9112e2810b1a32ee98e2
Author: Guillem Jover <guillem@debian.org>
Date: Fri Dec 27 03:15:53 2019 +0100
dselect: Remove nfs methods
There is nothing special about NFS, and mounting these should just be
left to the local admin, who can mount any other remote filesystem too.
commit be0379378c0b3c3244eb992aac97eacfcf54b007
Author: Guillem Jover <guillem@debian.org>
Date: Fri Dec 27 03:06:17 2019 +0100
dselect: Remove cdrom method superseded by the multi_cd method
commit b6b7d10bc6f7f04ef972e4f22facc24ec578b3c1
Author: Guillem Jover <guillem@debian.org>
Date: Fri Dec 27 02:53:59 2019 +0100
dselect: Remove harddisk methods
These were non-functional due to fdisk changes, and do not make sense
anymore, as we can expect users to mount any such filesystem on their
own and then use a filesystem method instead.
commit 15de47b0b13ec19a128cd61ede8fc6ff58f0e2cb
Author: Guillem Jover <guillem@debian.org>
Date: Fri Jan 17 01:20:38 2020 +0100
dselect: Update multicd README file
commit cc7476b3f049d5e0549191441ed1a82791efbc5a
Author: Guillem Jover <guillem@debian.org>
Date: Sun Dec 29 03:48:36 2019 +0100
dselect: Mark a string for translation
commit 4dcce43d964a779d3587fab39699f533d1091976
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Fri Jan 31 20:32:03 2020 +0100
Update German translation of manual pages
Update to 3022.
Includes further proofreading on debian-l10n-german
commit d82d003aa426fc3eedcd18acc5b43105b0fbc1fd
Author: Guillem Jover <guillem@debian.org>
Date: Fri Jan 31 00:21:21 2020 +0100
man, doc: Clarify the postinst "triggered" arguments
The trigger-name(s) is passed as a space-separated list in the second
argument.
Prompted-by: Michael Biebl <biebl@debian.org>
commit 501f56659c512a4c365b873c87c9a5c41ef82d11
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Wed Jan 29 18:01:17 2020 +0100
Update German scripts translation
Update to 609t.
commit 0f560b4cb650753a9d0c91fa30c13974b17fc2e5
Author: Guillem Jover <guillem@debian.org>
Date: Wed Jan 29 01:21:49 2020 +0100
test: Skip backup files
commit 5a72724fa5721f065894ddd2fade79aab9268e2a
Author: Guillem Jover <guillem@debian.org>
Date: Wed Jan 29 01:19:47 2020 +0100
build: Remove reference to deleted debian/compat file
Fixes: commit 4158d222d9b8734eb764da70e6b8cac066dc8654
commit 82d9cfd7e0c8733c322806b257ac194103d7d423
Author: Guillem Jover <guillem@debian.org>
Date: Sat Jan 25 03:29:36 2020 +0100
Dpkg::Substvars: Add new vendor:Name and vendor:Id substvars
These will make it easier to keep packaging branding neutral from
the current vendor, so that derivatives need to modify less things
from their parent.
commit 0ecdc83131190666cc1ccfe5b8b43e97ade7cff2
Author: Guillem Jover <guillem@debian.org>
Date: Wed Jan 29 00:25:09 2020 +0100
test: Update suppressions for cppcheck 1.90
Some got introduced in 1.89 and fixed in 1.90, others had been fixed
before but never noticed, remove them now.
Update the comments to match the newly grouped suppressions.
commit 5e3ffab92fcc099000ab6308eba3140d20796cfc
Author: Guillem Jover <guillem@debian.org>
Date: Wed Jan 29 00:20:41 2020 +0100
u-a: Move error context setup before calling setjmp()
This is a cppcheck false-positive, but by rearranging the code we can
avoid it, and it makes it somewhat more clear anyway.
This was causing lots of fuzzying when the line numbers were getting
changed.
Warned-by: cppcheck
commit b006dc6ce5a78baba9c21f58048a8f65946d95ec
Author: Guillem Jover <guillem@debian.org>
Date: Wed Jan 29 00:15:48 2020 +0100
u-a: Remove redundant condition in argument parser
This was really a redundant condition, and independent of the variable
being an enum instead of a bool.
Warned-by: cppcheck
commit 8a98dae74c864ef3f44855a5c2edf42aa9a7bc0e
Author: Guillem Jover <guillem@debian.org>
Date: Wed Jan 29 00:09:53 2020 +0100
test: Remove redundant assignment
This is really a redundant assignment, as the variable is local, and
even if the error handler was triggered, it would jump to the first
branch of the setjmp conditional, which also sets pass to false.
Warned-by: cppcheck
commit 6dc63578c8a7f7fae5968334577140985990317b
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:49:59 2020 +0100
debian: Bump Standards-Version to 4.5.0 (no changes required)
commit 4158d222d9b8734eb764da70e6b8cac066dc8654
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:47:06 2020 +0100
debian: Switch from debian/compat to debhelper-compat in Build-Depends
commit df3e0a9a310a1a5943735d67dbadcc4fbc523687
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:45:17 2020 +0100
debian: Switch to debhelper compatibility level 12
commit 3beef2f57d353accf5e508ae8065feb813eb7d66
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:41:52 2020 +0100
build: Update debian/.gitignore for dh_autoreconf artifacts
commit f032555d9f98f00b0ccf05d6459a6bb8f9897f0b
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:24:30 2020 +0100
Dpkg::Source::Package: Fix original tarball signature calls
We need to pass the directory as the first argument, and should not be
calling the functions if there are no tarball signatures to verify.
Fixes: commit 3821f024d92aabf24a333025c1c1956d8a45e718
Reported-by: Niels Thykier <niels@thykier.net>
commit 7fd5756e22177b39c7822ca0672bd6a59f659971
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:23:28 2020 +0100
Dpkg::Dist::Files: Document the two filename pattern formats
Prompted-by: Felix Lechner <felix.lechner@lease-up.com>
commit e8ffa0552b5600f18c06702c16033f0bcb1b1e11
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:20:09 2020 +0100
Dpkg::Dist::Files: On filename parse error say file instead of package
commit 0e9eb7b807733e41c1e38012a5560376887232db
Author: Guillem Jover <guillem@debian.org>
Date: Tue Jan 28 23:55:40 2020 +0100
Dpkg::OpenPGP, Dpkg::Source::Package: Update needed modules
This was missed when refactoring the code out of Dpkg::Source::Package.
Fixes: commit 139dfc4c78593d995610c0aa180300a9a7dd94ac
commit 05c9d5ba0ce65d47070e31e997f6eeb6ab558d12
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Mon Jan 20 22:44:31 2020 +0100
Update German translation of manual pages
Update to 3018t.
commit 5f0001ac38b255591a5ab88b8bf0a846c0f4ac14
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Mon Jan 20 19:47:46 2020 +0100
Update German scripts translation
Update to 609t.
commit b0884e9d08fa9996bc67c96712b187c1255b5def
Author: Sven Joachim <svenjoac@gmx.de>
Date: Mon Jan 20 18:12:29 2020 +0100
German dpkg translation update
Update to 1140t.
commit ff589fd1d161dbea88dea82c7edee5ed62549c74
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 02:53:10 2020 +0100
dpkg-architecture: Suppress perlcritic policy for «no warnings»
Fixes: commit ba23abe9e93ffcdae09ec234208ea55478c3f5ac
commit 33899e9378790f0bda984feb09860899eab96331
Author: Guillem Jover <guillem@debian.org>
Date: Sat Nov 23 19:44:12 2019 +0100
libdpkg, dpkg-query: Optimize db-fsys:Files loading
We load either the entire db-fsys for all packages, possibly optimized
per platform (such as by using fiemap), or the specific ones for the
requested packages.
This also fixes a problematic cast removing the constness of a variable.
commit 2e5010d660ea644e05d77ec48fe760d1a044ceda
Author: Guillem Jover <guillem@debian.org>
Date: Thu Jan 9 05:18:33 2020 +0100
dpkg-buildpackage: Do not accept equal signs as part of the hook names
Closes: #948291
Reported-by: Daniel Shahaf <danielsh@apache.org>
commit 3f77e30a269bb3ffb2b45f3f74c29e495beac8c9
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 00:59:17 2020 +0100
Dpkg::Vendor::Ubuntu: Remove obsolete 'keyrings' hook
Fixes: commit 6e6bd74a5664b3d354dc7fd892a08eaf928980ad
commit ba23abe9e93ffcdae09ec234208ea55478c3f5ac
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 01:48:01 2020 +0100
dpkg-architecture: Fix handling of exec failing in --command
We should check exec's return value, and error out ourselves so that
we exit with a correct error code. We suppress the perl exec warning,
so that we do not get duplicate messages.
Reported-by: Helmut Grohne <helmut@subdivi.de>
commit a7c8c0f02e4a6399ad485b67284ac018914da082
Author: Guillem Jover <guillem@debian.org>
Date: Sat Dec 7 22:14:37 2019 +0100
libdpkg: Fix comment description
commit 2896dae700d8aaff73b4a05f07c0c138a20c784c
Author: Guillem Jover <guillem@debian.org>
Date: Fri Nov 29 02:23:01 2019 +0100
libdpkg: Create the info/ database directory on demand
commit ee8be1388758cb0e71cfbf7cb61d543040442f86
Author: Guillem Jover <guillem@debian.org>
Date: Fri Nov 29 02:22:37 2019 +0100
libdpkg: Create the updates/ database directory on demand
commit 12b68b3fbc9970d91bbacf49291ad3e5a9e5cced
Author: Guillem Jover <guillem@debian.org>
Date: Wed Mar 20 05:21:26 2019 +0100
libdpkg: Create the dpkg database directory on demand
commit e6bc50a5ecc6743c1ad03aede8679a81d11ac713
Author: Guillem Jover <guillem@debian.org>
Date: Fri Nov 29 02:26:41 2019 +0100
libdpkg: Do not change the ownership of the triggers database directory
Either we are running as root:root (checked by modstatdb_open()) which
means the ownership should be correct already, or we are not which means
we cannot change it anyway.
commit 99c9cdbf1b9650ef5025c3c06ea918ef3007888e
Author: Guillem Jover <guillem@debian.org>
Date: Fri Mar 15 03:25:16 2019 +0100
libdpkg: Allow missing status and available databases
This makes it possible to bootstrap an installation w/o requiring
external knowledge of the dpkg internals, as the databases will be
created on write when necessary. We can then remove the code setting
them up from the dpkg postinst.
Closes: #647911
commit bbb52d7a9a8061920414634af22d76b7f02466eb
Author: Guillem Jover <guillem@debian.org>
Date: Fri Mar 15 03:08:50 2019 +0100
libdpkg: Create the logfile with correct permissions
We switch from fopen(3) to open(2) so that we get more control when
opening the log file and can explicitly give the corrent mode to use.
Remove the code from the postinst, as it should now be unnecessary.
commit d1ff4b8427aab0ad735735a1bfc9a8f037c8fda0
Author: Guillem Jover <guillem@debian.org>
Date: Sun Dec 1 04:21:43 2019 +0100
libdpkg: Consider msdbrw_needsuperuser equivalent to msdbrw_write
When checking for missing access to the dpkg database directory, we
should consider msdbrw_needsuperuser equivalent to msdbrw_write, as
the former is a superset of the latter.
commit 5997521cc98bddfb2be4c80a69b120624b249313
Author: Guillem Jover <guillem@debian.org>
Date: Sun Dec 1 04:20:41 2019 +0100
libdpkg: Fix modstatdb_rw enum comments
commit 9b611f69a628387424b4597485cd274e5cce0998
Author: Guillem Jover <guillem@debian.org>
Date: Wed Mar 20 05:21:11 2019 +0100
dpkg-split: Create the parts/ database directory on demand
This makes it possible to bootstrap dpkg w/o requiring external
knowledge of internal details.
commit 49c8d396ff36fd0c21f2a7a082ebf1d9b609e22b
Author: Guillem Jover <guillem@debian.org>
Date: Wed Mar 20 05:21:11 2019 +0100
dpkg-split: Cope with a missing parts/ database directory
When trying to scan the parts/ directory, we should gracefully cope with
it being missing, which can be the case when bootstrapping this package
on a new system. Or when using an different administrative directory.
commit 16f696213370484cc1930071a31481bd7dc87262
Author: Guillem Jover <guillem@debian.org>
Date: Sun Dec 29 03:49:38 2019 +0100
libdpkg: Add new atomic file flag to create the base path when missing
commit 62f5a5399b721e7bcf47bb0aa4c9f0582739eda9
Author: Guillem Jover <guillem@debian.org>
Date: Sat Mar 16 04:58:12 2019 +0100
libdpkg: Add new dir_make_path() and dir_make_path_parent() functions
commit 5fd4ba68c41c1be5a28dfe241aec35c7e11255e7
Author: Guillem Jover <guillem@debian.org>
Date: Sat Nov 30 22:17:55 2019 +0100
u-a: Create the administrative directory on demand
Create it if missing when saving the alternative into the database.
commit 63b5e9b5cbc4023b3d3fbec9823bfbaf270fd261
Author: Guillem Jover <guillem@debian.org>
Date: Sat Nov 30 22:17:55 2019 +0100
u-a: Cope with a missing administrative directory
When trying to scan the administrative directory, we should gracefully
cope with it being missing, which can be the case when bootstrapping
this package on a new system. Or when using a different administrative
directory.
commit 67a1d582284c5ce22a46d68c45bc7410d33845d6
Author: Guillem Jover <guillem@debian.org>
Date: Mon Mar 11 23:00:29 2019 +0100
dpkg-buildpackage: Add option to sanitize environment
This new option will apply vendor-specific sanitization to the
environment so that the build is safer. We cannot enable this by default
as that would let packages assume these settings are always in place,
which would cause regressions when using the currently defined build
entry point (debian/rules).
Closes: #843776
commit be1d6863fda782ce94d017aae5f035b92f54d6cb
Author: Guillem Jover <guillem@debian.org>
Date: Mon Mar 11 23:36:02 2019 +0100
scripts: Give more context on field parsing errors
While the line number and column are lost at the point were we parse the
field values, printing the name of the binary package should help
substantially on locating the required context in the file.
Closes: #637060
commit 8c65a0fbedabf49878dedf7b58b8a3e581d6bc1d
Author: Guillem Jover <guillem@debian.org>
Date: Sun Dec 29 03:48:51 2019 +0100
man: Clarify debian/source/include-binaries format
Prompted-by: Felix Lechner <felix.lechner@lease-up.com>
commit 00790440e0844d49af5830af5fe73ad0713453c3
Author: Guillem Jover <guillem@debian.org>
Date: Wed Dec 18 03:05:43 2019 +0100
man: Clarify deb-changelog(5) format
Specify that the semicolon is required, that zero or more key/values
are allowed, the format of the keys, and the exact Unicode characters
used for the delimiters.
Closes: #946780
commit 26107bd453f343d93f0128a9c30d74435debefc1
Author: Mo Zhou <lumin@debian.org>
Date: Wed Dec 18 03:24:47 2019 +0100
po: Update Simplified Chinese programs translation
Closes: #945776
Signed-off-by: Guillem Jover <guillem@debian.org>
commit 72e359a5d595838f1d727a3b6269541757a54aed
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 00:23:42 2020 +0100
libdpkg: Fix memory leaks in zlib and bz2 decompression functions
We need to close the handles to release their respective resources.
These leaks are not important as they are short-lived in the current
implementation as the call site will always execute them in a child
process.
Warned-by: coverity
commit cfc4908be31c24010cf52193f8ebdefc6d9ab8ea
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 00:28:44 2020 +0100
s-s-d: Close the notification socket in the child
This is not really required, as the socket is set as close-on-exec, but
it confuses some static analyzers. So let's close it explicitly, which
makes the intention more clear too.
Warned-by: coverity
commit 531e6c329152e61163102241fb6d721bcb19c0d3
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 00:21:36 2020 +0100
s-s-d: Fix memory leak on multiple --chuid arguments
When we pass multiple times the --chuid option, it will leak any
previous argument.
Warned-by: coverity
commit 375d066c0c30cd810d2c9c4b1ab6ffe889f5de60
Author: Guillem Jover <guillem@debian.org>
Date: Mon Jan 20 00:20:20 2020 +0100
s-s-d: Explicitly ignore uninmportant function return values
Warned-by: coverity
commit 098b9642ddae878c155c358e3ef5ca9ecf401d79
Author: Guillem Jover <guillem@debian.org>
Date: Sat Jan 18 01:52:18 2020 +0100
dpkg-split: Fix short-lived file descriptor leak --auto
Warned-by: coverity
commit c3d79e40b18d57d6a287fb49c6b2c04b8dc5722d
Author: Guillem Jover <guillem@debian.org>
Date: Sat Jan 18 01:35:14 2020 +0100
dpkg: Fix short lived memory leak in --force-help handling
Warned-by: coverity
commit 53ae4e616df2dbc49fe2f11492558bdee1ef0cfe
Author: Guillem Jover <guillem@debian.org>
Date: Sat Jan 18 01:23:07 2020 +0100
test: Suppress new bogus cppcheck 1.90 false positives
Warned-by: cppcheck
commit 37b8a0ea1ab1bd96dd7a4c8c1a90ef76a6a0802b
Author: Guillem Jover <guillem@debian.org>
Date: Thu Jan 16 04:30:20 2020 +0100
libdpkg: Fix format string to be a string literal
This also removes an intermediate string formatting.
Warned-by: gcc-10, gcc -Wformat=2
commit 0ec260b39b0d23d262ddff07d8954f11c8d954c7
Author: Guillem Jover <guillem@debian.org>
Date: Sat Nov 23 19:44:12 2019 +0100
libdpkg: Only use varbuf_printf() in pkg_format_show() when necessary
Calling varbuf_printf() to add a simple string is quite expensive. We
should only use it when we need to format the arguments.
commit b077a733f086d7e75d12cc4cfc733654a3b37925
Author: Guillem Jover <guillem@debian.org>
Date: Thu Jan 16 04:01:17 2020 +0100
libdpkg: Fix fiemap memory usage layout
The compiler has a hard time understanding that the composite struct is
being used to allocate enough space for the flexible array member, and
emits an out of bounds warning (-Wzero-length-bounds).
Instead use a buffer with enough space that we alias to a struct fiemap.
Warned-by: gcc-10
commit a0828e04289639f875cb924f8d1a65a634683b19
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Thu Dec 26 08:21:49 2019 +0100
po: Regenerate .pot files and merge .po files with them
commit cad2ca70bdfcaca55afd00cac111c095762ee12c
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Thu Dec 26 07:53:02 2019 +0100
Proofreading of German man pages on debian-l10n-german (Part 1)
commit 036cb27170a1f95446ecd03a20cf3601d9a85f38
Author: Sven Joachim <svenjoac@gmx.de>
Date: Wed Nov 27 19:43:52 2019 +0100
German dselect translation update
Update to 274t.
commit 38da4b7aca42fc62a49b2a5879fc9021ca973b98
Author: Sven Joachim <svenjoac@gmx.de>
Date: Wed Nov 27 19:43:26 2019 +0100
German dpkg translation update
Update to 1135t.
commit 21199ee1c25538ee24cdacc0a133ac6ff3502821
Author: Guillem Jover <guillem@debian.org>
Date: Tue Nov 26 13:17:45 2019 +0100
Dpkg::Source::Package: Honor require_valid_signature option
We need to pass this option forward to the verify_signature() calls,
otherwise we use the default.
Fixes: commit 139dfc4c78593d995610c0aa180300a9a7dd94ac
Fixes: commit 3821f024d92aabf24a333025c1c1956d8a45e718
commit 89f9aad83b2c67294aaf80658fcdc6f36c3129ef
Author: Guillem Jover <guillem@debian.org>
Date: Wed Nov 27 03:37:08 2019 +0100
po: Remove previous msgids for up-to-date translations
This was causing unit test failures.
commit 34974887506d0bcf8bc069e99a22901647e6d173
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Tue Nov 26 19:42:31 2019 +0100
Update German translation of manual pages
Update to 3016t.
commit b0d572695d2fc5478d2461e952145d933e40e6be
Author: Helge Kreutzmann <debian@helgefjell.de>
Date: Tue Nov 26 18:27:48 2019 +0100
Update German scripts translation
Update to 609t.
commit 89afa9af7cd589eb8384ed96b6d86dd59d56bdf5
Author: Guillem Jover <guillem@debian.org>
Date: Tue Nov 5 12:59:17 2019 +0100
Dpkg::Source::Package::V3::Native: Do not say v1.0 for 3.0 formats
commit 2eafcd122aa4e772cd6bb40c3eb82ac27aff3646
Author: Guillem Jover <guillem@debian.org>
Date: Tue Nov 5 12:57:13 2019 +0100
Dpkg::Changelog: Clarify inheritance and implementation references
Make it clear that these classes inherit from some other base class,
which will contain the missing documentation.
Prompted-by: intrigeri <intrigeri@debian.org>
commit 7ab69d4acbdabd3af0f8c27801527750505c1a11
Author: Guillem Jover <guillem@debian.org>
Date: Wed Nov 6 02:07:17 2019 +0100
Dpkg: Say class instead of object when appropriate
These were referring to the type and not the instance, which makes
using the incorrect nomenclature confusing.
commit b287a80263dd4e45bb82b7e6bad76faeb47358d4
Author: Guillem Jover <guillem@debian.org>
Date: Sat Oct 5 04:28:30 2019 +0200
Dpkg::Exit: Register exit handlers also for __DIE__
This makes sure we execute the handlers on normal errors, and can thus
remove the traps from several functions to run the handlers and to then
rethrow the exception.
