grml2usb (0.16.4) [PTS] [DDPO]

NEW: VCS has unreleased changes: 0.16.5 > 0.16.4

Git: git://git.grml.org/grml2usb.git
Enter a full Vcs-* header, supported schemes are: Vcs-Bzr, Vcs-Cvs, Vcs-Darcs, Vcs-Git, Vcs-Hg, Vcs-Mtn, Vcs-Svn.
For Vcs-Git append -b branch to select the branch name; append [subdir] if the debian/ directory is not in the repository root.
The next upload will reset the information from the source package headers.
Branch: master
Path: debian/changelog
Browser: https://git.grml.org/?p=grml2usb.git
Last scan: 2019-06-19 07:06:27+00
Next scan: 2019-06-20 08:43:00+00

Debian changelog in Git:

grml2usb (0.16.5) unstable; urgency=medium

  * [95b0773] Switch default mount point from /lib/live/mount/medium to
    /run/live/medium

 -- Michael Prokop <mika@grml.org>  Thu, 21 Mar 2019 12:23:59 +0100

This branch is 1 commit ahead of tag v0.16.5

Git log:

commit ef2f28e996c9d5b6313be87ee957c0d9a578e822
Author: Michael Prokop <mika@grml.org>
Date:   Tue Jun 4 10:39:28 2019 +0200

    Avoid custom boot options getting duplicated when used with multiple ISOs
    
    grml2usb can be invoked with multiple ISOs *and* custom boot options, like:
    
      % sudo grml2usb --bootoption="ssh=foobar mikawashere" grml32-small_2018.12.iso grml64-small_2018.12.iso /dev/sdb1
    
    Then grml2usb appends the custom boot options in the GRUB
    (boot/grub/*.cfg) + isolinux/syslinux (boot/syslinux/*.cfg)
    configuration files of files that have been installed by the underlying
    grml32-small ISO.
    
    But when hitting the grml64-small ISO then, it continues to replace the
    files with the boot options once again. Therefore we end up with
    duplicate boot options in the grml32-small_2018.12.iso specific files
    (boot/grub/grml32small_default.cfg, boot/grub/grml32small_options.cfg,
    boot/syslinux/grml32_small_default.cfg, boot/syslinux/grml32_small_grml.cfg +
    boot/syslinux/hidden.cfg).
    
    We could actually ensure to only touch the ISO specific files, but
    we don't have version information included in the file names and also
    have shared files like boot/syslinux/hidden.cfg, so this might unexpected
    side effects as well. So instead let's explicitly check for the provided
    custom boot options.
    
    Notes regarding the implementation:
    
    * If boot options are whitespace-only or empty, nothing will happen. This
      prevents str.replace to do unintended things.
    
    * otherwise consider string "PRE some-boot-options POST". Then we should find
      'some-boot-options' and remove them. Why the delimiter handling? Consider
      some-boot-options is 'ssh'. If we replace line.replace(bootopt, '') then some
      fictitious boot option like 'service.ssh=autostart' would be broken. Thus the
      space delimiters are necessary.
    
    * However, the space delimiters might not exist if the boot options occur at the
      end of the string. Thus special handling is required for this case.
    
    Thanks: Ralf Moll for the bug report and Lukas Prokop for providing the bug fix