hping3 (3.a2.ds2-10)
[PTS] [DDPO]
COMMITS: VCS has seen 2 commits since the debian/3.a2.ds2-10 tag
- Git: https://salsa.debian.org/debian/hping3.git
-
- Branch: debian/master
- Path: debian/changelog
- Repo size: 131072
- Browser: https://salsa.debian.org/debian/hping3
- Last scan: 2024-07-15 04:27:24+00
- Next scan: 2024-07-22 10:10:00+00
- Merge requests: 1
- CI pipeline status: success
- Debian changelog in Git:
hping3 (3.a2.ds2-10) unstable; urgency=medium
* debian/changelog: removed some whitespaces.
* debian/control:
- Added field Rules-Requires-Root.
- Bumped Standards-Version to 4.5.0.
* debian/patches:
- Created the patch 191_fix_ftbfs_with_gcc10.patch.
(Closes: #957341)
- Updated the patch 040_spelling.diff.
* debian/rules:
- Removed uninecessary lines.
- Updated to convert the hping3 french manpage to UTF-8.
* debian/salsa-ci.yml: added to provide CI tests for Salsa.
* debian/tests/control:
- Added to provide a simple test.
* debian/watch:
- added a fake site to explain about the current
status of the original upstream homepage.
* Ran wrap-and-sort.
* Using new DH level format. Consequently:
- debian/compat: removed.
- debian/control: changed from 'debhelper' to 'debhelper-compat' in
Build-Depends field and bumped level to 13.
-- Marcio de Souza Oliveira <marciosouza@debian.org> Wed, 02 Sep 2020 18:12:56 +0000
- This branch is 2 commits ahead of tag debian/3.a2.ds2-10
- Git log:
commit 99058531a28a85ba0e9d7d974bb47db4238f5e28
Merge: f00d970 2361d74
Author: Marcio de Souza Oliveira <marciosouza@debian.org>
Date: Mon May 13 04:39:41 2024 +0000
Merge branch 'fix-implicit-declaration' into 'debian/master'
Don't use asprintf (requires _GNU_SOURCE_)
See merge request debian/hping3!4
commit 2361d747f03ba8224eb397cfbbddd9f52cb26bf4
Author: Arnaud Rebillout <arnaudr@kali.org>
Date: Mon May 6 09:06:25 2024 +0700
Don't use asprintf (requires _GNU_SOURCE_)
In dpkg 1.22.6, the compiler flag -Werror=implicit-function-declaration
was enabled by default, see [1] for details.
It fails the build:
```
| script.c: In function ‘HpingTcl_AppInit’:
| script.c:1351:29: error: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Werror=implicit-function-declaration]
| 1351 | if (asprintf(&rcfile, "%s/.hpingrc", home) < 0)
| | ^~~~~~~~
| | vsprintf
```
Looking at the code, asprintf is not used anywhere, except in the file
script.c.
Turns out it's added by a Debian patch. Apparently, the changes was
added to avoid using the variable `PATH_MAX` (not defined for GNU Hurd),
but at the same time the patch defines `PATH_MAX` if it's not defined...
So it seems to me that we can revert this chunk of the patch, thus
removing the use of asprintf, and reverting to using snprintf.
Closes: #1066662
[1] https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration