Git log: commit 456bd7bc3244c7adccfcfd3b419eb9ccae2dea4c
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Jun 4 15:53:36 2019 +0300
fix-tools-build.diff: Build igt_stats again.
commit fc0a57b63918af1d64f29696c7570f4b2f0fb0d7
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Jun 4 15:51:16 2019 +0300
docs, install: Updated.
commit 139eb25c12cf7593a5ab821292c2d7d66245ece4
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Jun 4 15:50:50 2019 +0300
Build with meson.
commit 3d417627e2590cf3532276396d34d13240cd49b4
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Jun 4 15:20:26 2019 +0300
control: Add libdw-dev to build-depends.
commit 38b90fc4b7084ddc7374e727cc4908c15e1e441d
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Jun 4 15:20:10 2019 +0300
bump the version
commit 8717a8c3af56c0cb84cd833828d4856fae5fc76d
Merge: f220662b e81b020f
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Jun 4 15:10:23 2019 +0300
Merge branch 'upstream-unstable' into debian-unstable
commit e81b020f8af3c605b5649591dd46ae3118f2ec23
Author: Simon Ser <simon.ser@intel.com>
Date: Mon May 27 14:42:51 2019 +0300
lib/igt_kms: introduce igt_kms_get_hdmi_audio_edid
This new function uses igt_edid to generate an EDID suitable for testing HDMI
audio. It's imported from kms_chamelium with minor edits, it's used there and
in kms_hdmi_inject. A (unexported for now) generate_hdmi_audio_edid function
enables generation of EDIDs with arbitrary SAD and speaker blocks.
This obsoletes kmstest_edid_add_audio.
The sanity check for the HDMI audio EDID has been moved from
lib/tests/igt_hdmi_inject.c to lib/tests/igt_edid.c.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit fc60a75f74792d772ee4f544add1777c260faaaf
Author: Simon Ser <simon.ser@intel.com>
Date: Thu Apr 25 17:05:24 2019 +0300
lib/igt_edid: add support for Speaker Allocation Data blocks
Speaker Allocation Data blocks describe which speakers are present in the
display device.
This block is required to make DisplayPort audio work.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 569870e16055c7d731814234a67d88382331b3e0
Author: Simon Ser <simon.ser@intel.com>
Date: Mon May 27 13:29:50 2019 +0300
lib/tests/igt_edid: introduce EDID sanity checks
The idea is to make sure we don't completely break EDIDs by performing some
basic sanity-checking in lib tests.
The test currently only checks the base and alt EDIDs. More EDIDs will be added
in the future: HDMI audio, 4K, 3D and so on.
The logic is mostly borrowed from lib/tests/igt_hdmi_inject.c. This patch is
part of the "let's unify igt_edid and igt_hdmi_inject" series.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit d37fd01737dea57f33176d6525610666637a88d6
Author: Simon Ser <simon.ser@intel.com>
Date: Wed May 29 15:21:32 2019 +0300
lib/tests/igt_audio: add test with an extra frequency
Make sure it fails.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 908c17365708ac9095c2160e2e1343c72e96ad47
Author: Simon Ser <simon.ser@intel.com>
Date: Wed May 29 15:17:48 2019 +0300
lib/tests/igt_audio: add test with missing frequency
Make sure detection fails.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 04b5de43470657611cadb11ef2cc0c8afa1891e7
Author: Simon Ser <simon.ser@intel.com>
Date: Wed May 29 14:25:59 2019 +0300
lib/igt_audio: add basic audio_signal_detect tests
This adds three basic library tests for igt_audio's audio_signal_detect: one
that checks that detection works with the generated signal unchanged, and two
that check that detection properly fails with a silent/noise input signal.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 0caa0063fa86133464e3f3822ad39678be3e9bcd
Author: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Date: Fri Apr 5 17:55:59 2019 +0300
tests/kms_plane_multiple: before going testing check how many planes are allowed
before start testing try out how many planes kernel will
allow simultaneously to be used.
v2 (Jose Souza, Daniel Vetter): Fix resource leaks. Randomize
used planes.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
commit 8eddc43c75c2ae4ec6e3bee70e4f815e08a928c8
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Jul 11 15:09:02 2018 +0100
i915/gem_exec_balancer: Exercise bonded pairs
The submit-fence + load_balancing apis allow for us to execute a named
pair of engines in parallel; that this by submitting a request to one
engine, we can then use the generated submit-fence to submit a second
request to another engine and have it execute at the same time.
Furthermore, by specifying bonded pairs, we can direct the virtual
engine to use a particular engine in parallel to the first request.
v2: Measure load across all bonded siblings to check we don't
miss an accidental execution on another.
v3: Throw in a check for master as well.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
commit 1b3f41b03edc0f1496e4478a81eea23dd8b1f54a
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Mon Mar 12 15:42:56 2018 +0000
i915: Add gem_exec_balancer
Exercise the in-kernel load balancer checking that we can distribute
batches across the set of ctx->engines to avoid load.
v2: Many assorted improvements from Tvrtko.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 2047a2f386f29f373a222006634101953496b7ae
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Sat Apr 28 09:27:56 2018 +0100
i915: Add gem_ctx_engines
To exercise the new I915_CONTEXT_PARAM_ENGINES and interactions with
gem_execbuf().
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Andi Shyti <andi@etezian.org>
Reviewed-by: Andi Shyti <andi@etezian.org>
commit 3de39c02a8ca4839f99927ecdd9f154f49492218
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Sat May 12 10:46:24 2018 +0100
i915/gem_ctx_switch: Exercise queues
Queues are a form of contexts that share vm and enfore a single timeline
across all engines. Test switching between them, just like ordinary
contexts.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 34f8e70106982f6a363a15330071ef383350dc9b
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Thu Dec 14 14:14:21 2017 +0000
i915: Exercise creating context with shared GTT
v2: Test each shared context is its own timeline and allows request
reordering between shared contexts.
v3: Use the modern interface to use physical engines for testing
single-timeline along each real engine.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 1376f540fb3503b246d14494a3bf3bdf9423ae45
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Mar 13 18:02:13 2019 +0000
i915: Add gem_ctx_clone
Exercise cloning contexts, an extension of merely creating one.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 8bd2b3e12a4743b256724dfbad78f865d7e3dd59
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Mar 13 15:48:31 2019 +0000
i915/gem_ctx_create: Basic checks for constructor properties
Check that the extended create interface accepts setparam.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit eb02ab50373cacc0daea5d23409dc6de78e799ca
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue Mar 12 10:34:05 2019 +0000
i915/gem_ctx_param: Test set/get (copy) VM
Exercise reusing the GTT of one ctx in another.
v2: Test setting back to the same VM
v3: Check the VM still exists after the parent ctx are dead.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit f264521e654ae1469a6be7ffa459e1e76eaa2daa
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Thu Mar 14 12:43:43 2019 +0000
i915: Add gem_vm_create
Exercise basic creation and swapping between new address spaces.
v2: Check isolation that the same vm_id on different fd are indeed
different VM.
v3: Cross-over check with CREATE_EXT_SETPARAM
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 248c71f76446fd899a1afe5da988a0b6544b96b4
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Mon May 27 10:43:58 2019 +0100
benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
We can use offsetof for the same effect, much tidier with no dummy
locals.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 6cfbf0365f39d68fcaabcd0498ffec28d1528d8f
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date: Thu Apr 25 10:41:02 2019 +0200
tests/kms_setmode: Handle eDP with fixed mode better.
When running the stealing tests, we set the same mode on the eDP and
the other connector. If the eDP is 4k, we may try to set a mode that
is not supported on the other connector, which might be 1080p.
Fix this by selecting the smallest default mode, based on clock.
Hopefully this is more likely to be supported on all connectors,
instead always using the first connector's mode.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110391
[mlankhorst: Kill off 1 extra copy of mode (vsyrjala)]
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
commit 5aeacd5cc3fc37ff9e5dccb9e8ae63acdc12e521
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Fri May 24 22:43:51 2019 +0100
automake: Repair overlay build
This partially reverts commit 9141edea9931db0ca1dfcf476da8bdd370702cc4.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 5a08524404ddd579857fea2bd977b770e9911032
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Sun Jun 2 09:52:18 2019 +0100
i915/gem_ppgtt: Remove defunct test
i915_gem_gtt_info has been removed and so flink-and-exit-vma-leak is
defunct.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit 2d5c26f844cf1851e5097680d30c951978291c29
Author: Petri Latvala <petri.latvala@intel.com>
Date: Fri May 31 13:55:21 2019 +0300
meson: Remove redundant libdw from lib_deps
Listing it once should be quite enough.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Simon Ser <simon.ser@intel.com>
Reviewed-by: Simon Ser <simon.ser@intel.com>
commit c998ca40a12933a0cefbe6b99c916eae32846919
Author: Petri Latvala <petri.latvala@intel.com>
Date: Fri May 31 12:56:19 2019 +0300
runner: Cope with repeated subtests in journal
As seen in fallout with the i915 engine discovery patchset, subtests
can in very dire cases be entered multiple times, when the for loop
they're in doesn't progress. That is of course a bug in IGT that needs
to be fixed, but if (when) that happens again, don't make results take
a million years to process.
This patch has been tested to produce good results from the
corresponding bad runs.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
commit 1bcc155549ac1d99207321754c9942559e54bc99
Author: Mika Kahola <mika.kahola@intel.com>
Date: Wed May 29 15:21:28 2019 +0300
tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling
Kernel doesn't support Y or Yf tiling for interlaced modes. In kms_flip_tiling test case
we are missing such a check. Let's add a requirement that whenever we try to do flip with Y/Yf
tiling, we ensure that we have non-interlaced mode selected.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110772
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
commit 4108c74c3b15460de25ab989f4e2031594559dfc
Author: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Date: Mon May 27 13:19:24 2019 -0400
tests/amdgpu: Add color tests for amdgpu
The DRM color management pipeline doesn't directly map to AMD hardware
so creative solutions to implementing CRTC regamma, CTM and gamma were
needed for both DCE and DCN. A few mistakes were made in the process
that weren't caught by kms_color@ tests:
- Can't get linear degamma output without setting a custom degamma
- Can't specify a non-linear degamma that produces correct output
- Can't specify a correct gamma when a linear degamma is used
These are caused by using implicit sRGB degamma then sRGB gamma when no
matrices are set. This produces visually correct output when using a
CTM with no matrices set, but it's also technically the incorrect
output according to the DRM API documentation.
These tests help verify that AMDGPU follows the DRM spec when it comes
to setting linear/bypass gamma and regamma LUT.
The existing kms_color@ tests are written correctly already, so
anything that looks shared in these is really just to verify that we're
no longer doing any strange test specific workarounds outside of the
spec or documentation.
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
commit 4b9889882ef6d287d339db89c584dd035c6dae80
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed May 29 22:06:14 2019 +0100
i915/gem_workarounds: Mix and match SRM with mmio reads
On apl, mmio reads fail, reading 0.
On cml, SRM reads fail, reading 0.
Combine both approaches, starting with SRM and fixing in the blanks with
mmio reads.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
commit f414756be2ac57e194919973da7b86644ba61241
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Sat May 25 08:04:53 2019 +0100
i915/gem_workarounds: Verify regs directly
It seems like the HW validator is getting better at preventing our
snooping of system registers from non-privileged batches! If we can't
use SRM, let's probe the register directly through mmio, making sure we
have the context spinning on the GPU first.
v2: Hold forcewake just in case the spinning batch isn't enough to
justify our register access.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110544
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
commit 0cb925e7f145ba2535924d9a298a62d757707e2a
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Mon May 27 09:33:43 2019 +0100
prime_vgem: Fix typo in checking for invalid engines
Move the stray ')' from
gem_can_store_dword(exec_id) | exec_flags
to
gem_can_store_dword(exec_id | exec_flags)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110764
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
commit b7e700567803237e2f3d7a8753fd4775f712d353
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Wed May 22 18:11:53 2019 +0300
tests/kms_big_fb: Delay the expensive big fb creation until the last moment
We already perform the format+mod+rotation test using the small fb, so
we don't actually need to create the big fb until that test has been
performed. We do need to calculate the big fb dimensions though so that
we can calculate the coordinates we're going to use in the test.
$ time kms_big_fb
- real 0m52.902s
+ real 0m52.616s
so not so great.
But if I run each subtest separately it starts to add up:
$ for i in `kms_big_fb --l` ; do kms_big_fb --r $i ; done
- real 5m32.898s
+ real 4m32.164s
The big difference between those two ways of running the test
is at least partially due to the test reusing big fb between
the different rotation subtests for each format+mod combo.
Running each subtest individually can't get that benefit so
avoiding needless big fb creation starts to make a difference.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
commit 57b28c863f210b0d18769d561a5e1537b2a43b11
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Thu May 23 22:03:24 2019 +0300
tests/kms_big_fb: Run the test for a single pipe only
I think we can safely assume that if no plane on the first
available pipe supports the format+mod+rotation combo we
don't have to check on all the other pipes.
The only slight exception is CHV where pipe B has a few more
features, but none of those are actually relevant for this
test.
Also leave put the PIPE_ANY commit as that still causes
pointless modesets.
$ time kms_big_fb
- real 2m8.101s
+ real 0m52.902s
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
commit d8a8cc9ba0d204d71818fdc105e90cac5e47cf39
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Fri May 10 19:49:37 2019 +0300
tests/kms_plane: Test C8 pixel format
Now that igt_fb has rudimentary C8 support let's test it.
We have to generate a custom palette for it of course.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
commit 8a07b094cf39cae93625bffcb5c6667b8f585e08
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Fri May 10 19:47:50 2019 +0300
lib/igt_fb: Add support for C8 pixel format
Expose C8 support by utilizing pixman's rgb332 support.
By using rgb332 we don't have to worry too much about
how to populate the LUT, though for now we still leave
that responsibility to individual tests. If desired we
could make igt_kms generate a suitable LUT when the test
itself didn't bother. But meh for now.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
commit 2d64cb6808075b0d0696a89d2ce290220e6eff8e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Fri Apr 5 09:34:36 2019 +0100
i915/pm_rpm: Probe connectors to run standalone
In order to run as a standalone test (i.e. immediately after booting a
device), we need to explicitly probe the connectors.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Imre Deak <imre.deak@intel.com>
commit 44280058510bbf559a3bc13e19f4a94ae7644242
Author: Simon Ser <simon.ser@intel.com>
Date: Tue May 28 16:44:27 2019 +0300
lib/igt: fix igt_audio include
igt_audio includes a libasound header. We should guard it behind
HAVE_CHAMELIUM.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
commit 0d0b4547c356734b03d61797f49c30281e8763ed
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Thu May 16 19:52:31 2019 +0300
tests/kms_available_modes_crc: Remove C8 test
The test is not setting up the legacy LUT for C8 as the kernel
expects. Since I'm going to add rudimentary C8 support to igt_fb
and kms_plane anyway let's just drop it from here.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
commit 7dadebb49b15373ec55af89cce0df0e8f40a7178
Author: Simon Ser <simon.ser@intel.com>
Date: Fri May 24 17:25:05 2019 +0300
tests/kms_chamelium: add audio channel alignment test
The previous pulse test only checked the signal amplitude.
This commit adds a new check to the flatline test: channel alignment. This check
makes sure there is no time shift between each channel.
This is achieved by first sending a positive signal and then a falling edge.
Edges in each channel should be aligned.
The index of each channel's falling edge is stored in number of samples. I
chose not to implement a per-page test because the edge could be right between
two pages.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit b443813d6f625387304857d92595a9c835bae49d
Author: Simon Ser <simon.ser@intel.com>
Date: Fri May 24 10:20:49 2019 +0300
tests/kms_chamelium: add a flatline audio test
This commit adds a flatline test alongside the existing frequencies test.
The test sends a constant value and checks that the amplitude is correct. A
window is used to check that each sample is within acceptable bounds. The test
is stopped as soon as 3 audio pages pass the test.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit f92f051da6f07b9bb70f030f1df9996cf4b9a7fe
Author: Simon Ser <simon.ser@intel.com>
Date: Fri May 24 10:17:53 2019 +0300
lib/igt_audio: make audio_extract_channel_s32_le support a NULL dst
This adds a snprintf-like behaviour to audio_extract_channel_s32_le.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 5f372af8c8ed99f24fa6bf280f00367ecb8ff136
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 16:16:20 2019 +0300
tests/kms_chamelium: add name parameter to audio_state_start
This identifies the audio test name. This is required for adding multiple
audio tests.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit cb42c4dbbc4d4bf245371876352e5c986b248799
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 15:52:19 2019 +0300
lib/igt_audio: introduce audio_convert_to
This function converts normalized doubles into an ALSA PCM format.
Instead of having per-format audio_signal_fill_* functions, we can only have
audio_signal_fill that outputs normalized doubles. Then in ALSA's playback
callback, we can simply use the new audio_convert_to function to fill the
buffer.
This makes the test code simpler and prevents code duplication when another
ALSA playback callback is implemented.
This adds a dependency of igt_audio over ALSA for the PCM format enum, but I
don't think this is a concern, since I don't see the point of using igt_audio
without igt_alsa. If this is an issue, it would always be possible to replace
ALSA's enum with our own in the future.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 7e99a553b74d175c7e6640f37679c1e696cc20a9
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 15:12:12 2019 +0300
tests/kms_chamelium: explain why 8-channel tests aren't performed
Also add a reference to the relevant Chromium bug.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 08dc471bd63de908e5e11a024b1e02b550272ed6
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 15:07:22 2019 +0300
tests/kms_chamelium: rename do_test_display_audio and test_audio_configuration
- Rename do_test_display_audio to test_audio_frequencies to prepare for a
future amplitude/delay test
- Rename test_audio_configuration to check_audio_configuration because this
function doesn't execute any test, it just checks whether we can perform
audio tests using a particular configuration
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 4252e130cbd09c7bb599448e1109bc9bb6984491
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 14:56:15 2019 +0300
tests/kms_chamelium: introduce audio_state_receive
This extracts the logic receiving audio pages in do_test_display_audio into a
new audio_state_receive function. The function takes care of updating the
current msec counter and dumping the received data in a file.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit c46e2dc3d9262abce7e48ca2277856b2ea5f1bd5
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 14:32:59 2019 +0300
tests/kms_chamelium: refactor audio test
Instead of shoving everything into do_test_display_audio, extract the logic to
initialize, start, stop, finish an audio test in helper functions. The struct
audio_state now carries all audio-related state.
This will allow to easily add more audio tests that don't use sine waves (via
audio_signal). This is necessary for future delay and amplitude tests.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 7be24f8a5a6374ae167c89e9962bb27a3513ed8a
Author: Simon Ser <simon.ser@intel.com>
Date: Mon May 27 17:08:14 2019 +0300
lib/igt_chamelium: introduce CHAMELIUM_MAX_AUDIO_CHANNELS
This allows us not to hardcode 8 everywhere.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 2892adce93fb8eea3d764dc0f766a202d9dcef37
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 13:55:06 2019 +0300
lib/igt_audio: use calloc instead of malloc + memset
This is less error-prone.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit b1c181e45f8116591f4398cc8383bf79d4ad949e
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 13:53:26 2019 +0300
lib/igt_audio: add more assertions
- Make sure an audio signal isn't created with zero channels
- Make sure each channel has at least one frequency when synthesizing
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
commit 5e583caf38c04c9312e28510b754b2b54da31d56
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:27 2019 +0300
tests: Remove redundant igt_exit() calls
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 81b44b085e6a1b213965a04e1f06fcd732e89735
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:26 2019 +0300
testdisplay: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 2fe849b5a88ded35b5d0ebb2e78333bcacf8b8b0
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:25 2019 +0300
prime_mmap_coherency: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 3d27f3e3173104e657199a1a3f104cf569bf4c7c
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:24 2019 +0300
kms_tv_load_detect: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 061f03ccca2372130456e3bd10038bdaa7e9341c
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:23 2019 +0300
kms_setmode: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit defc37eb2a8e33c2894ba22545a06991146615c5
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:22 2019 +0300
kms_psr: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit e23fe8e1eaca213320e9cc3464760492dedd2c94
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:21 2019 +0300
kms_psr2_su: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit b6e9dcb5be57eae398ffc2717f4087a14d710100
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:20 2019 +0300
kms_plane_multiple: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 6d0cc5202a9a3a823c6239b15763d4b01d32080d
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:19 2019 +0300
kms_mmap_write_crc: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 2200131012869128887c4b0b61cb0381b7c5b9ce
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:18 2019 +0300
kms_frontbuffer_tracking: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 226c3e9967a725386d910fe8b5119b61b2f9c433
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:17 2019 +0300
kms_force_connector_basic: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 43a590dc563fc33d013e8990834caf7e4eadb498
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:16 2019 +0300
kms_flip: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit daf72d1094a96b3eb8a61dfcd0c35ca2375147bf
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:15 2019 +0300
kms_cursor_edge_walk: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit b15d7f6c29dab4f63609de72663a5b364ebb4635
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:14 2019 +0300
kms_concurrent: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit a1c3d34486ea03c28cdf612e928cb80a81499b77
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:13 2019 +0300
i915/i915_pm_rpm: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit c7430008727fdca9f770c517db5c457d64ad2eb4
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:12 2019 +0300
i915/gen3_render_tiledy_blits: Nuke custom main function
The buffer count parameter, previously gotten from argv[1], is now the
parameter -c.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 974d8e9bb4ab466618d588c38042c52d6edd99e3
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:11 2019 +0300
i915/gen3_render_tiledx_blits: Nuke custom main function
The buffer count parameter, previously gotten from argv[1], is now the
parameter -c.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 2cd5adb5fd166852a45aa70580570e93c2266213
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:10 2019 +0300
i915/gen3_render_mixed_blits: Nuke custom main function
The buffer count parameter, previously gotten from argv[1], is now the
parameter -c.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit c5d59aab7a9277c1dbff3308446f7ba17f5cefd6
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:09 2019 +0300
i915/gen3_render_linear_blits: Nuke custom main function
The buffer count parameter, previously gotten from argv[1], is now the
parameter -c.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 6cabcb59e9fc59c79f9272ba501eb016ccf1744b
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:08 2019 +0300
i915/gen3_mixed_blits: Nuke custom main function
The buffer count parameter, previously gotten from argv[1], is now the
parameter -c.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 1bd67385ea337cadda8f2d228aff24ddc8d956dc
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:07 2019 +0300
i915/gem_userptr_blits: Nuke custom main function
The buffer count parameter, previously gotten from argv[1], is now the
parameter -c.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit b246001a807b0d72355afa9367ee3c8d29a95b31
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:06 2019 +0300
i915/gem_tiled_blits: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 4db0341a9f26a4386567e42a9566c075ac68ce8d
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:05 2019 +0300
i915/gem_stress: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit fec340e8a0f46325cec6aa353cf5b78843f60ed4
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:04 2019 +0300
i915/gem_request_retire: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit fe27b9e0890a1f600a9d75c4d2e0d7a747a21159
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:03 2019 +0300
i915/gem_render_copy_redux: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 7e4ed1cec6b2f0326f95cdb35e9f70bdc492c858
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:02 2019 +0300
i915/gem_render_copy: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit a7499441ebe33871fd7a60c87e231e1f1aba2c78
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:01 2019 +0300
i915/gem_pwrite_pread: Nuke custom main function
The object size parameter, previously gotten from argv[1], is now the
parameter -s.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit d7eab9452a65b0e139da4fea4c0aa18ff4e49a49
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:27:00 2019 +0300
i915/gem_pwrite: Nuke custom main function
The object size parameter, previously gotten from argv[1], is now the
parameter -s.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 179463132a2a48c79bd527edd4a773a17c36a63e
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:59 2019 +0300
i915/gem_pread: Nuke custom main function
The object size parameter, previously gotten from argv[1], is now the
parameter -s.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit a7f17ca88bcfa055cbc23219b35b3f8ea0aac0e1
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:58 2019 +0300
i915/gem_ppgtt: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 6b5776618b4f1bead4a29b3b3d327692d5e0f5f0
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:57 2019 +0300
i915/gem_linear_blits: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 34cf1de0e6888461979107b417269c590273dcbe
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:56 2019 +0300
i915/gem_hang: Nuke custom main function
The pipe parameter, previously gotten from argv[1], is now the
parameter -p.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 321de5e771894327379042cd0ccacf82cba8f6dd
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:55 2019 +0300
i915/gem_gtt_speed: Nuke custom main function
The size parameter, previously gotten from argv[1], is now the
parameter -s.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 299d73aa49312d3b400471a7588a24244ba8b625
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:54 2019 +0300
i915/gem_exec_blt: Nuke custom main function
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 0fff5e7c719178d695007bdcafda56901dcdf25e
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:53 2019 +0300
lib: Document igt_opt_handler_t semantics
Best practices for the help string formatting, along with explicit
symbols for the possible return values for the callback.
Also documented: Do not call the _parse_opts functions yourself, use
igt_main_args or igt_simple_main_args.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit c17f0cc405b67c88bda594daf98934cbc7adbf1f
Author: Petri Latvala <petri.latvala@intel.com>
Date: Thu May 23 15:26:52 2019 +0300
lib: Introduce main function macros with custom args
Instead of using a custom main function and calling
igt_subtest_init_parse_opts / igt_simple_init_parse_opts, the _args
variants of igt_main and igt_simple_main take the relevant parameters
and pass them along to the correct init function.
Open-coding a custom main function is no longer necessary and not
recommended.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Don Hiatt <don.hiatt@intel.com>
commit cdd6b0a7630762cec14596b9863f418b48c32f46
Author: Simon Ser <simon.ser@intel.com>
Date: Tue May 21 16:35:33 2019 +0300
tests/kms_chamelium: print audio sub-sub-test results
We run multiple audio sub-sub-tests inside the same sub-test to save a modeset.
With the current output it's not clear whether a particular sub-sub-test
succeeded or not.
After a sub-sub-test has completed, print its configuration (format, channels,
sampling rate) and its result.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 777b3698c95d5551bdc1af325ca9fe0b32c04bb2
Author: Simon Ser <simon.ser@intel.com>
Date: Mon May 20 17:59:04 2019 +0300
tests/kms_hdmi_inject: document how the test works
It's not immediately obvious what injection and ELDs are, and what is tested.
This commit adds a few comments to help readers understand this test. In case
the test breaks, this could help.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 60c17a3fca964bb762bb4b20125dbcd28e0a07f4
Author: Simon Ser <simon.ser@intel.com>
Date: Thu May 23 13:47:27 2019 +0300
lib/igt_audio: fix uninitialized variable
Seems like I'm not used to the C89 style yet, and ASan caught it but with a
completely unrelated stack trace.
Signed-off-by: Simon Ser <simon.ser@intel.com>
commit 5771480d7648dcd66d00e5a97b502027437fcc71
Author: Simon Ser <simon.ser@intel.com>
Date: Wed May 22 13:13:20 2019 +0300
lib/igt_audio: fix amplitude for S24_LE and S32_LE
We need to use signed integers (hence "S" in the format name).
The reason this has gone unnoticed is that we were generating signals with half
of the amplitude they were supposed to have. As a result, using UINT32_MAX
(which is almost INT32_MAX * 2) resulted in the correct amplitude. In other
words, these two bugs were cancelling each other's effects.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Fixes: 42576d710255 ("lib/igt_audio: add support for S24_LE and S32_LE signal generation")
commit 9ab4576a705f2b83db34071afd4808028e15929f
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Fri May 24 14:52:40 2019 +0100
i915/gem_busy: Fix typo killing snb!
Check the right engine to see if it is the one that explodes!
Fixes: 88318b0771f9 ("test/i915: gem_busy: use the gem_engine_topology library")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
commit 204a719b71b74d8e5480da8fa10b3353fc82e7dd
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Fri May 24 09:45:08 2019 +0100
benchmarks/gem_wsim: Manually calculate VLA struct sizes
Apparently VLA structs (e.g. struct { int array[count] }) is a gcc
extension that clang refuses to support as handling memory layout is too
difficult for it. So calculate the size by hand!
v2: Use alloca().
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
commit fdad47c994df77f4ecf7c60baa3193ccf3542145
Author: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Date: Fri May 24 08:28:29 2019 +0300
man/build: Fix dependency handling
build_man is a 'feature' option, which means that we get an opaque
object, so comparing it to 'yes' is always false.
It should have been 'if build_man.enabled()'.
But going even further we can prune the whole check, as rst2man is
defined as follows:
rst2man = find_program('rst2man-3', 'rst2man', required : build_man)
>From the patch overhauling those options:
get_option() on a feature returns opaque object that can be passed as
a 'required' argument of a dependency. Auto is equivalent to 'required
: false', enabled is equivalent to 'required : true' and disabled
introduces new behavior forcing the dependency to be considered not
found.
This would cause the build to fail if build_man is enabled (aka
'required') and rst2man is not found. So...
if rst2man.found()
# rst2man found
# buildu buildu
else
# rst2man not found, but considered optional because
# we haven't erred out on find_program
if build_man.enabled() # cannot be, it's optional!
error('...')
endif
endif
We can get rid of the whole else block here.
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Simon Ser <simon.ser@intel.com>
commit 996b4346b6a7f2bd0919817648a4f7a382e59757
Author: Antonio Argenziano <antonio.argenziano@intel.com>
Date: Thu May 23 14:47:34 2019 -0700
man:meson.build: Fix build option check
the build system tries to evaluate a variable that has been removed. Use
the option passed from the outside instead.
Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
commit 7f120c5f1bff2727d50f3c392d81c0f6878b61d6
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date: Wed May 22 16:57:20 2019 +0100
gem_wsim: Allow random seed control
New command line option to allow controling the initial pseudo random
generator seed in order to allow repeatable runs.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Suggested-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
commit ccc473acb1eaf47f3cef9af9fec06bc53d047835
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date: Wed May 22 16:57:19 2019 +0100
gem_wsim: Fix prng usage
Back when gem_wsim used forking it was safe to use the common storage
prng, but after converting to threads it no longer is.
Fix by storing and using a new per workload seed for batch buffer
duration randomness.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
commit e8fd4938a42945e9e28cd7004adf2e31ded3d394
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date: Wed May 22 16:57:18 2019 +0100
gem_wsim: Support Icelake parts
On Icelake second vcs engine is vcs2 instead of vcs1 so add some logical
to physical instance remapping based on engine discovery to support it.
v2:
* Rebase.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
commit 2a35f782c82726866d80652d673db0d711430998
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date: Wed May 22 16:57:17 2019 +0100
gem_wsim: Discover engines
Instead of hardcoding the VCS balancing engines, discover, both with the
new engines query, or with the legacy get_param in the fallback case, so
class based addressing always works.
v2:
* Simplify has_engine_query check. (Andi)
* Fix assert on uninitialized variable. (Andi)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
