Git log: commit a5d8e7fb4a96cdc3ebb7c40f1280c32ca4e7252c
Author: Héctor Orón Martínez <zumbi@debian.org>
Date: Thu Jun 23 01:07:31 2022 +0200
Release Debian version 1.21.0-1
Signed-off-by: Héctor Orón Martínez <zumbi@debian.org>
commit ccf000983da0402013f97138aa1cf940dd1cda79
Author: Héctor Orón Martínez <zumbi@debian.org>
Date: Thu Jun 23 00:55:34 2022 +0200
debian/rules: improve clean target
Signed-off-by: Héctor Orón Martínez <zumbi@debian.org>
commit 76ea20f092bbe67a86b61df0678614a0834b6371
Author: Héctor Orón Martínez <zumbi@debian.org>
Date: Thu Jun 23 00:52:34 2022 +0200
debian/libinput10.symbols: update
Signed-off-by: Héctor Orón Martínez <zumbi@debian.org>
commit 858257f0759adfc6058db07921c23448da54ef60
Merge: acc393e6 bc363328
Author: Héctor Orón Martínez <zumbi@debian.org>
Date: Thu Jun 23 01:04:18 2022 +0200
Merge branch 'upstream-unstable' into debian-unstable
commit bc363328a704b3c5e0ee2f0fcf088de67c708979
Author: José Expósito <jose.exposito89@gmail.com>
Date: Sat Jun 11 13:47:52 2022 +0200
libinput 1.21.0
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
commit 7888ef2787080beafe4dd53b56c779875de7392d
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed Jun 8 16:43:39 2022 +1000
gitlab CI: bump to F35 and F36, as well as Ubuntu 21.10 and 22.04
F33 and F34 are both EOL. This also fixes the RPM build job to
automatically use the latest Fedora version and adds
wayland-protocols-devel which is now needed.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 6a1bd5b0c9be55d21c6e066a94fc6fd77fea96ce
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri Jun 10 10:31:37 2022 +1000
meson.build: check gtk targets before building
We have two different dependencies on Wayland: GTK support and the
wayland-protocols we use directly. If we have GTK support but
wayland-protocols is not installed at meson configure time, our build
fails.
To avoid having multiple ifdefs in the code, let's define two new ones:
HAVE_GTK_WAYLAND and HAVE_GTK_X11, both set if GTK supports that
particular target (from pkgconfig) and we have the other support
libraries we need.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 35420239963747b0c10778a028c07ddf24e57146
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed Jun 8 09:25:59 2022 +1000
test: fix a typo
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit d833f265c0b69dab23c7c0d47622a4cd0a6e3cbb
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed Jun 8 09:25:02 2022 +1000
test: use a ranged test instead of a duplicated one
These two tests were identical except for the WHEEL/HWHEEL
differentiator, let's make this into a ranged test instead.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 4ae72b6eb2e4487a16d2c8e9b663bcb66618e388
Author: José Expósito <jose.exposito89@gmail.com>
Date: Mon Jun 6 20:24:16 2022 +0200
wheel: fix Lenovo Scrollpoint quirk
The IBM/Lenovo Scrollpoint mouse features a trackpoint-like stick that
sends a great amount of scroll deltas.
In order to handle the device, a quirk is in place to normalize the
scroll events as they were relative motion.
However, when high-resolution scroll was implemented, we started
normalizing the hi-res events instead of the lo-res events by mistake.
Fix the quirk by normalizing the right deltas.
Fixes: 6bb02aaf307a ("High-resolution scroll wheel support")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Tested-by: Peter Ganzhorn <peter.ganzhorn@gmail.com>
commit 7688f35477cae9ecceec86ac15a2619ed222d2fe
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Tue Jun 7 09:55:32 2022 +1000
test: ensure we always have an axis event where we expect one
If we never got an event, we'd skip over the while loop and generate a
false positive.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 164227d193e3ef986fc3b5449e2ef0662684f639
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Tue Jun 7 11:56:04 2022 +1000
test: fix the lowres-only wheel event tests
These tests gave us false positives for devices without a REL_WHEEL or
REL_HWHEEL because one of the helper functions papered over missing
events.
We have two tests here, one for horizontal, one for vertical but they
mixed WHEEL and HWHEEL in both tests. Fix this by splitting them
properly, so each test only checks that axis.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 92233df57b07c4bbc95ec4f5ed9ce5cc896eabce
Author: satrmb <10471-satrmb_true-email-is-private_contact-via-web@gitlab.freedesktop.org>
Date: Sun May 29 11:29:49 2022 +0200
filter-touchpad: normalize for dpi on the touchpad-specific flat profile
On mice, switching the acceleration profile to flat disables dpi normalization,
because high or even switchable dpi are generally major features of a
high-end mouse, and switching to flat acceleration indicates that the user
wants to reduce the effects of any cursor acceleration to a minimum.
Therefore we skip normalization there and let the user take full advantage
of their expensive hardware.
On touchpads, particularly those built into a laptop, users have to deal with
whatever hardware they have; touchpad dpi is an afterthought at best, or
a disaster at worst. Switching to the flat profile is more likely to be
about avoiding the non-linear acceleration curve of the adaptive profile.
Hence the flat profile for touchpads shouldn't copy what the one for mice does,
but rather use dpi normalization like the adaptive profile. This keeps flat
acceleration on low-resolution touchpads from dropping to unusably slow speeds.
Signed-off-by: satrmb <10471-satrmb@users.noreply.gitlab.freedesktop.org>
commit bfbcf1737b856bbda5b0271247b8708fbff5e232
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 15:21:08 2022 +1000
tablet: require a minimum pressure before we process pressure events
Tools default to 1% lower threshold (tip up) and 5% upper threshold (tip
down). But our distance vs pressure exclusion would reset the distance
for *any* pressure value, regardless how low that value was and how high
distance was in comparison.
A very low pressure value of less than 1% would then result in a
normalized pressure of 0, so we'd effectively just reset the distance to
zero and do nothing with the pressure. This can cause distance jumps
when the tool arbitrarily sends low pressure values while hovering as
seen in https://github.com/libsdl-org/SDL/pull/5481#issuecomment-1118969064
Commit 61bdc05fb0f84303f97daaba6ae6b49c976dbfbf from Dec 2017
"tablet: set the tip-up pressure threshold to 1%"
was presumably to address this but no longer (?) works.
Fix this by addressing multiple issues at the same time:
- anything under that 1% threshold is now considered as zero pressure
and any distance value is kept as-is. Once pressure reaches 1%,
distance is always zero.
- axis normalization is now from 1% to 100% (previously: upper threshold
to 100%). So a tip down event should always have ~4% pressure and we
may get tablet motion events with nonzero pressure before the tip down
event.
From memory, this was always intended anyway since a tip event should
require some significant pressure, maybe too high compared to e.g.
pressure-sensitive painting
- where a tablet has an offset, add the same 1%/5% thresholds, on top of
that offset. And keep adjusting those thresholds as we change the
offset. Assuming that the offset is the absolute minimum a worn-out
pen can reach, this gives us the same behaviour as a new pen. The
calculation here uses a simple approach so the actual range is
slightly larger than 5% but it'll do.
Previously, the lower threshold for an offset pen was the axis minimum
but that can never be reached. So there was probably an undiscovered
bug in there.
And fix a bunch of comments that were either wrong, confusing or
incomplete, e.g. the pressure thresholds were already in device
coordinates.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 988329d5d9553926f4c72eae9027b3f74454348b
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 14:59:05 2022 +1000
tablet: use a helper variable to make the code more readable
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 393442fd3a741a34b3360f4cc40243df7c7248f8
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 16:24:43 2022 +1000
test: rename a test function to make it easier to select
Because --filter-test does substring matching it's easier to have it
with a unique name rather than one that is a prefix of another.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 374d32c6bed3433355c39bb17e5bf6a6545ee72c
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 14:57:40 2022 +1000
tablet: remove an always-true part of an if condition
A few lines north of here we return early if neither bit is set. If we
get to this point, at least one bit is set so this part of the condition
always evaluates to true.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit a9e6cd03d0ba02ed402dc384b86089f7119d4d4f
Author: José Expósito <jose.exposito89@gmail.com>
Date: Wed May 18 23:17:35 2022 +0200
Remove "device-" file
The file was unintentional added in a merge request:
https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/771
Fixes: 4d26736e ("Quirk all StarLabs trackpads")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
commit 4d26736e2011ea7bce9286bb7f8b144bf3a74536
Author: Sean Rhodes <sean@starlabs.systems>
Date: Thu May 12 09:07:26 2022 +0100
Quirk all StarLabs trackpads
Quirk all the StarLabs trackpads as they are all the same design,
a clickpad with physical buttons that act as one button.
Fixes #771.
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
commit e0e0e3aa8f5b51ef6af126115ac009f7eafdd68a
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon May 16 12:24:16 2022 +1000
quirks: remove an unused quirk
Removed in b925a0878b0b51fe30016546b9e48a7613dccd4d
quirks: switch the models with missing buttonpad to use the new attr
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 8cb2b47b7be5c17165b6ea3d735975de44b064e2
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon May 16 12:23:57 2022 +1000
quirks: move the canvas quirk enum to the right order
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit a6fa862c0052aaba0cb50ca7d920ba50cacd14ad
Author: Sean Rhodes <sean@starlabs.systems>
Date: Mon May 9 12:14:11 2022 +0100
quirks: Add quirk for StarLite Mk IV
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
commit 5dd751a3d023ed74ab9c0fcecc02a4bc3f91a146
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 11:00:59 2022 +1000
test: install libinput-test-utils as part of install-tests
This tests a bunch of internal utility functions that may work
differently depending on compiler flags, etc. Let's make that test
available so it can be verified on an installed system.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 43a8d769ac776bfa2173669cfe03f39e89850f4a
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 10:51:33 2022 +1000
tools: add a libinput test tool as entry point for our test suites
We already install libinput-test-suite if the meson option install-tests
is set, see
commit be7045cdc70d8c026d981997852cc706dab3d5b8
test: make the test suite runner available as installed binary
To make other tests easily available and more discoverable, add a new
tool "libinput test" with the matching man page. This will also help us
to enforce some of the namespacing a bit better.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit d48c7e72f725466f2579d4d687116b632a0cbdf9
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 14:24:41 2022 +1000
tools/analyze-recording: improve the repeated-events line printing
When redirecting to a file, we don't want lines like this:
.. +2 ... +5 ... +9
Let's not print anything until we have collected all those lines and
then print the final result, we don't need a live update here.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 4ac5fd9e2441cc753ecfb069dac6854b0dd75977
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 13:15:25 2022 +1000
tools/analyze-recording: add --print-state to always print values
Helpful in comparing values that update frequently - without this the
last printed value may be way off the page when some other value comes
in that it needs to be compared to.
Values not seen yet default to zero - we can't query those from a
recording but it'll be good enough this way.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 200bc920ac5b770baea3796acf5cd634f8703545
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri May 6 13:44:58 2022 +1000
tools/record: fix indentation for libinput events
Commit 0cdf459643bfa6264bd2d1af8f7749529ebffee1
tools/record: get rid of indent push/pop, replace with fixed indents
Introduced some magic to detect if there's a '-' at the start of the
format string to fix the identation. This only works if the format
string is constant though, leading to an indentation error when record
is run with --with-libinput.
Fixes 0cdf459643bfa6264bd2d1af8f7749529ebffee1
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit f22d1938796a57c378e9ca5353beb1f0b0e99eb1
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed May 4 11:20:01 2022 +1000
tools: don't print a carriage return if we're not on a tty
Otherwise redirecting the output to a file leaves us with ugly ^M
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 509747c01ba0b796657045fc0195a345369190ed
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed May 4 11:14:30 2022 +1000
tools: allow limiting the axes in libinput analyse recording
Use --ignore ABS_X,ABS_Y or --only ABS_X,ABS_Y to ignore or limit to
only a specific axis set. Especially for tablet devices with their
multitudes of axes this makes analysing a particular set easier.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit e0813f4825568fb911421799a286ac889d093cb3
Author: Alexander Courtis <alex@courtis.org>
Date: Tue Apr 26 01:55:22 2022 +0000
AttrLidSwitchReliability quirk default unreliable->reliable
commit a423d7d3269dc32a87384f79e29bb5ac021c83d1
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Wed Mar 30 09:25:22 2022 +1000
evdev: strip the device name of format directives
This fixes a format string vulnerabilty.
evdev_log_message() composes a format string consisting of a fixed
prefix (including the rendered device name) and the passed-in format
buffer. This format string is then passed with the arguments to the
actual log handler, which usually and eventually ends up being printf.
If the device name contains a printf-style format directive, these ended
up in the format string and thus get interpreted correctly, e.g. for a
device "Foo%sBar" the log message vs printf invocation ends up being:
evdev_log_message(device, "some message %s", "some argument");
printf("event9 - Foo%sBar: some message %s", "some argument");
This can enable an attacker to execute malicious code with the
privileges of the process using libinput.
To exploit this, an attacker needs to be able to create a kernel device
with a malicious name, e.g. through /dev/uinput or a Bluetooth device.
To fix this, convert any potential format directives in the device name
by duplicating percentages.
Pre-rendering the device to avoid the issue altogether would be nicer
but the current log level hooks do not easily allow for this. The device
name is the only user-controlled part of the format string.
A second potential issue is the sysname of the device which is also
sanitized.
This issue was found by Albin Eldstål-Ahrens and Benjamin Svensson from
Assured AB, and independently by Lukas Lamster.
Fixes #752
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit a6ec596467a6a33beb79701931321933d4fced9c
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Thu Apr 7 14:44:53 2022 +1000
tools/record: fix the indentation of the system: section
Fixes 0cdf459643bfa6264bd2d1af8f7749529ebffee1
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit bdd2c9b76fdd5b83d40d7f7307a31a5a6eaa1615
Author: Tom Stellard <tstellar@redhat.com>
Date: Tue Apr 5 01:27:15 2022 +0000
Update valgrind.h to a newer version
This updates valgrind.h to the version that was packaged in
valgrind-devel-3.18.1-9.fc36. This new version contains a fix for a
build failure with clang.
Signed-off-by: Tom Stellard <tstellar@redhat.com>
commit 3d064a07f8885a2d6514d9acdc792032eaa13884
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon Mar 28 10:14:24 2022 +1000
doc/user: add a page to troubleshoot right-click Clickpads
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 423bb6455f0b7c47948000aeea42e4e4417700db
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon Mar 28 10:21:58 2022 +1000
meson: replace a meson.source_root() with the explicit directory
Removes the warning that source_root() has been deprecated since 0.56.0
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit f917661980384873f2a8f2cfdcf9e37605e3049b
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon Mar 28 10:16:51 2022 +1000
meson: fix a meson warning
run_command() wants a check kwarg now:
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: https://github.com/mesonbuild/meson/issues/9300
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 321458576da59d05fcbd025358fbdfc74b1c6b80
Author: José Expósito <jose.exposito89@gmail.com>
Date: Mon Mar 28 12:44:55 2022 +0200
test: disable hold gestures when are not required
Certain tests that make use of verify_left_handed_touch_motion can fail
depending on how quick they are executed, specially when using Valgrind.
Instead of ignoring the hold end event, use the existing mechanism to
disable hold gestures where we are not interested in them.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
commit 395d12d63446a1897dd64f35c2eb603203d55c21
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Mon Mar 7 14:44:21 2022 +1000
util: auto-declare the element variable in ARRAY_FOR_EACH
All cases we have in our code base have an otherwise unused variable to
loop through the array. Let's auto-declare this as part of the loop.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit 1f1ddbc6dff0cf0451e3c9ac923f9821278560aa
Author: pudiva chip líquida <pudiva@skylittlesystem.org>
Date: Tue Mar 8 01:33:40 2022 +0000
touchpad: new option dwtp (disable-while-trackpointing)
Add option to control whether the touchpad should be disabled while the
trackpoint is in use.
Fix #731
Signed-off-by: pudiva chip líquida <pudiva@skylittlesystem.org>
commit 602e8dcb999b1129da4887e450bf2d4e09ecb6fe
Author: José Expósito <jose.exposito89@gmail.com>
Date: Wed Mar 2 08:48:03 2022 +0100
coding style: allow C99 variable declaration
Allow to declare variables before they are used in new written code.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
commit 5664007013b057c6dca265c47859ebaab42aab78
Author: José Expósito <jose.exposito89@gmail.com>
Date: Wed Mar 2 08:35:23 2022 +0100
evdev: modernize variable declaration in evdev_device_is_joystick_or_gamepad
Declare the variables used to keep track of joystick buttons and
keyboard keys right before they are used for better readability and
consistency.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
commit ea568a7bcb37d3365a92269aa07d721cbd3fad3a
Author: José Expósito <jose.exposito89@gmail.com>
Date: Tue Mar 1 20:08:11 2022 +0100
evdev: check well-known keyboard keys on joystick/gamepad detection
Create a list of well-known keyboard keys containing one the most
representative key(s) of a group.
The rule is based on the assumption that if the representative key is
present, other keys of the group should be present as well.
The groups are:
- Modifiers group: KEY_LEFTCTRL.
- Character group: KEY_CAPSLOCK.
- Numeric group: KEY_NUMLOCK.
- Editing keys: KEY_INSERT.
- Multimedia keys: KEY_MUTE, KEY_CALC, KEY_FILE, KEY_MAIL,
KEY_PLAYPAUSE and KEY_BRIGHTNESSDOWN.
When 4 of these keys are found, the device is tagged as a keyboard.
Fix #745
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
commit 2e7dd3f84e592f348590220740747b9b682902a2
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Thu Feb 24 10:12:00 2022 +1000
gitlab CI: fail the sanity check stage if the fork is not public
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
