Git log: commit 2dbe91b43dbb17fdf9bb94d0d2e75ae63624f808
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Sep 24 12:18:34 2021 -0700
Split predicate functions out of Lintian::Relation.
Reduces code complexity by splitting the predicate elements and their
comparison out as a new Moo class. They are now separate from the boolean logic
that combines and evaluates them.
Gbp-Dch: ignore
commit 422cae498ec122afdb81e6de920e50051f8aa98e
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Sep 23 16:30:57 2021 -0700
Adopt latest style from website for the standalone HTML output often shown in Salsa CI.
Also provides a script to download the website's CSS style automatically.
commit 068e60969803bb51d79b10a73ee2c8ca21e1092f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Sep 22 15:27:26 2021 -0700
Repurpose breakout-link; split into two new tags to find a use. (Closes: #968525, #971707)
This tag generated a lot of controversy when it was implemented recently. While
it closed a bug from 2004, it was not clear if the fix was even still needed.
Part of the original report referred to an internal Lintian problem. The fix
then overreached and generated many false positives.
This commit narrows the scope of the tag and splits it into two. It also fixes
most, if not all, of the false positives.
Below are the hints Lintian now generates for the examples presented in the bug
reports.
* * *
Bug#968525 was about mixed installation paths for shared libraries. The false
positives cited were in Glibc and in libgpg-error. We did not confirm the fix
for the longer list submitted later. [1] Lintian no longer issues any of the
related tags for either package.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968525#82
The two unpack messages for Glibc are the open Bug#994716.
➤ bin/lintian /mirror/debian/pool/main/g/glibc/libc6-dev_2.32-4_amd64.deb
E: libc6-dev: unpack-message-for-deb-data ar failed for usr/lib/x86_64-linux-gnu/libm.a
E: libc6-dev: unpack-message-for-deb-data ar failed for usr/lib/x86_64-linux-gnu/libmcheck.a
I: libc6-dev: hardening-no-bindnow usr/lib/x86_64-linux-gnu/audit/sotruss-lib.so
I: libc6-dev: hardening-no-fortify-functions usr/lib/x86_64-linux-gnu/audit/sotruss-lib.so
I: libc6-dev: static-library-has-unneeded-section usr/lib/x86_64-linux-gnu/libpthread.a(libpthread-compat.o) .comment
I: libc6-dev: static-library-has-unneeded-section usr/lib/x86_64-linux-gnu/libpthread.a(old_pthread_atfork.o) .comment
I: libc6-dev: static-library-has-unneeded-section usr/lib/x86_64-linux-gnu/libpthread.a(pthread_kill_other_threads.o) .comment
I: libc6-dev: static-library-has-unneeded-section ... use --no-tag-display-limit to see all (or pipe to a file/program)
I: libc6-dev: unstripped-static-library usr/lib/x86_64-linux-gnu/libpthread.a(accept.o)
I: libc6-dev: unstripped-static-library usr/lib/x86_64-linux-gnu/libpthread.a(call_once.o)
I: libc6-dev: unstripped-static-library usr/lib/x86_64-linux-gnu/libpthread.a(cancellation.o)
I: libc6-dev: unstripped-static-library ... use --no-tag-display-limit to see all (or pipe to a file/program)
N: Those file are actually .o files not package in a ar archive, and
N: thus should not be stripped
O: libc6-dev: unstripped-binary-or-object usr/lib/x86_64-linux-gnu/libmcheck.a
➤ bin/lintian --no-tag-display-limit /mirror/debian/pool/main/libg/libgpg-error/libgpg-error-dev_1.38-2_amd64.deb
N: this is an ongoing discussion with upstream, with little likely to change any time soon:
N: see: https://bugs.debian.org/643341
N: and: https://lists.gnupg.org/pipermail/gnupg-devel/2014-May/028473.html
O: libgpg-error-dev: old-style-config-script usr/bin/gpg-error-config
N: this is an ongoing discussion with upstream, with little likely to change any time soon:
N: see: https://bugs.debian.org/643341
N: and: https://lists.gnupg.org/pipermail/gnupg-devel/2014-May/028473.html
O: libgpg-error-dev: old-style-config-script usr/bin/gpgrt-config
For Bug#971707, the issue was that some sources expect many of their files in
non-FHS locations, often in a single folder. Debian maintainers would then
dutifully install those files in the appropriate locations and then set links
from those places where the program expected the files.
It is theoretically possible to patch the sources, but upstream would probably
reject the patches, which leads to too much maintenance effort going forward.
The example cited in that bug, Openarena, no longer produces the false
positives. There are just messages about unused overrides and about the new tag
name.
➤ bin/lintian --no-tag-display-limit /mirror/debian/pool/main/o/openarena/openarena-server_0.8.8+dfsg-5_amd64.deb
I: openarena-server: unused-override breakout-link usr/lib/openarena-server/* -> etc/openarena-server/*
I: openarena-server: unused-override breakout-link usr/lib/openarena-server/*/*.pk3 -> usr/share/games/openarena/*/*.pk3
I: openarena-server: unused-override breakout-link usr/lib/openarena-server/*/etc/openarena-server -> etc/openarena-server
P: openarena-server: renamed-tag breakout-link => ldconfig-escape in line 4
P: openarena-server: renamed-tag breakout-link => ldconfig-escape in line 5
P: openarena-server: renamed-tag breakout-link => ldconfig-escape in line 6
N: #973759
O: openarena-server: debian-changelog-file-is-a-symlink usr/share/doc/openarena-server/changelog.gz
N:
N: Admin console command indicating "all [players are] ready", not a typo
N: for "already"
O: openarena-server: spelling-error-in-binary usr/lib/openarena-server/baseoa/qagamex86_64.so allready already
N:
N: Admin console command indicating "all [players are] ready", not a typo
N: for "already"
O: openarena-server: spelling-error-in-binary usr/lib/openarena-server/missionpack/qagamex86_64.so allready already
commit 690f61da565bce9efc6d6d52b6ab212e0119b8ee
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Sep 23 10:06:28 2021 -0700
Be ambivalent between /lib and /usr/lib for systemd service files. (See: #992465)
In its version 13.5.2, Debhelper today reverted [1] a recent change installing
systemd files in /usr/lib rather than in /lib. This commit is Lintian's
adjustment to the new circumstances.
Debhelper's original changes [2] prompted the filing of the bug above and then
Peter's fix thereto, but in the meantime a lengthy discussion on d-devel
resulted in a preliminary consensus that individual packages should not actually
move files between the /lib and /usr/lib locations on their own. [3]
With this change, Lintian should be ambivalent between the two locations for
systemd, meaning that we issue here no guidance asking maintainers to move.
Further clarification from the Technical Committee is expected.
[1] https://salsa.debian.org/debian/debhelper/-/commit/3083286de05f5c4e209e777edd5800b0cffa5941
[2] https://salsa.debian.org/debian/debhelper/-/commit/d70caa69c64b124e3611c967cfab93aef48346d8
[3] https://lists.debian.org/debian-devel/2021/07/msg00126.html
commit debb5e763be6e0426fba67674fbaea3ee3c87b56
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Sep 23 06:49:46 2021 -0700
Add a slash to the end of all ldconfig folders from Lintian::Data.
Makes the behavior consistent with Index::Item and simplifies the consuming
code. Thereby reduces potential confusion about whether slashes are needed in
matching expressions.
Gbp-Dch: ignore
commit ef5c7cffd7184ee33410ce2b0fe0257fbba86ba8
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Sep 22 13:34:00 2021 -0700
Make Index::Item->link_normalized a Moo accessor.
Gbp-Dch: ignore
commit 8fc1f76053074b0543722efd1d8e25f6da810eb1
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Sep 22 13:18:17 2021 -0700
Rephrase a noun in a tag description.
Gbp-Dch: ignore
commit 4d9ed7a9379d9f90519a191a6e34a07012c49a70
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Sep 21 09:28:53 2021 -0700
Rename Index::Item->is_maintainer_script method from ->is_control.
Fixes a long standing misnomer. The control index, to which the method applies,
is already named 'control'. The method identifies which of those files are
maintainer scripts. Now it is named appropriately.
Gbp-Dch: ignore
commit c9ed2d1647155a6262ded24c607d55100ba501b0
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Sep 21 07:23:06 2021 -0700
Fix minimum version for init-system-helpers in a tag description. (Closes: #918137)
The bug report gave a few hints about version numbers that could be correct,
but did not pipoint one beyond the shadow of a doubt.
According to my research, the functionality was added in this commit [1] and
released in this one [2] as part of init-system-helpers 1.52. The changelog [3]
states so, too:
init-system-helpers (1.52) unstable; urgency=medium
[ Felipe Sateler ]
* invoke-rc.d: add option to do nothing for native systemd units.
It is useful to simplify maintainer scripts, since it allows executing
this command for sysvinit/openrc
systems, and deb-systemd-invoke for systemd systems
Thank you to Ferenc Wágner for bringing the matter to our attention!
Sorry you waited so long for a fix.
[1] https://salsa.debian.org/debian/init-system-helpers/-/commit/d45b6763760ec9ee3019e09af2e4a2ad33977f0c
[2] https://salsa.debian.org/debian/init-system-helpers/-/commit/5e68389bddd66b2dc2ee3f8296b24e041e0d1bf9
[3] https://sources.debian.org/src/init-system-helpers/1.60/debian/changelog/#L120-L123
commit 6eb5bfa7e037184bdb41ef26a527b4a22488f398
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Sep 20 17:57:34 2021 -0700
Only create diffstat when the diff.gz is mentioned in the dsc or the changes. (Closes: #994793)
The erroneous behavior was probably introduced when the cruft check was
expanded to run also on sources with format 3.0. [1][2] Major portions of the
check previously only ran on sources with format 1.0.
Before those changes were made, the cruft check was mostly unable to detect
unwanted files in sources with format 3.0. The issue here lies at the
intersection of having a diff.gz file present while 3.0 sources are being
analyzed, and involves a tag relating to source format 1.0.
I used the instructions in the bug to reproduce the condition. The instructions
worked perfectly on bullseye. (Thank you!) The hint is now gone:
➤ ../../git/bin/lintian trickle_1.07-11.dsc
X: trickle source: deprecated-configure-filename
I: trickle source: out-of-date-standards-version 3.9.4 (released 2012-09-19) (current is 4.6.0.1)
I: trickle source: patch-not-forwarded-upstream debian/patches/fix-test-for-dh-compat-13.patch
I: trickle source: quilt-patch-missing-description debian/patches/diff_as_of_1.07-10.1_Makefile.am.patch
I: trickle source: quilt-patch-missing-description debian/patches/diff_as_of_1.07-10.1_configure.in.patch
I: trickle source: quilt-patch-missing-description debian/patches/diff_as_of_1.07-10.1_getopt.c.patch
I: trickle source: quilt-patch-missing-description ... use --no-tag-display-limit to see all (or pipe to a file/program)
X: trickle source: debian-watch-does-not-check-gpg-signature
P: trickle source: maintainer-manual-page debian/tricklectl.8
P: trickle source: no-dep5-copyright debian/copyright
P: trickle source: trailing-whitespace debian/rules (line 10)
X: trickle source: upstream-metadata-file-is-missing
That was the output before the change was applied. Please note the warning in
the first line: patch-system-but-direct-changes-in-diff.
➤ ../../git/bin/lintian trickle_1.07-11.dsc
W: trickle source: patch-system-but-direct-changes-in-diff Makefile.in and 17 more
X: trickle source: deprecated-configure-filename
I: trickle source: out-of-date-standards-version 3.9.4 (released 2012-09-19) (current is 4.6.0.1)
I: trickle source: patch-not-forwarded-upstream debian/patches/fix-test-for-dh-compat-13.patch
I: trickle source: quilt-patch-missing-description debian/patches/diff_as_of_1.07-10.1_Makefile.am.patch
I: trickle source: quilt-patch-missing-description debian/patches/diff_as_of_1.07-10.1_configure.in.patch
I: trickle source: quilt-patch-missing-description debian/patches/diff_as_of_1.07-10.1_getopt.c.patch
I: trickle source: quilt-patch-missing-description ... use --no-tag-display-limit to see all (or pipe to a file/program)
X: trickle source: debian-watch-does-not-check-gpg-signature
P: trickle source: maintainer-manual-page debian/tricklectl.8
P: trickle source: no-dep5-copyright debian/copyright
P: trickle source: trailing-whitespace debian/rules (line 10)
X: trickle source: upstream-metadata-file-is-missing
Thank you to Axel Beckert for bringing the matter to our attention!
[1] https://salsa.debian.org/lintian/lintian/-/commit/12da36751506887ded9dd5fd56fa54cfc5ccb2c0
[2] https://salsa.debian.org/lintian/lintian/-/commit/ee125788325ee7848f33812c5d7f6676639fcd22
commit 3d048290d64d643a43ad9b0ddcd05563e4789ea2
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Sep 19 12:24:59 2021 -0700
Allow maintainer manual pages for executables also so provided. (Closes: #994689)
For the 'wdm' package mentioned in the bug report, Lintian no longer produces
any of the related hints:
$ bin/lintian --no-tag-display-limit /mirror/debian/pool/main/w/wdm/wdm_1.28-25.dsc
I: wdm source: older-debian-watch-file-standard 3
I: wdm source: patch-not-forwarded-upstream debian/patches/01_kfreebsd.patch
I: wdm source: patch-not-forwarded-upstream debian/patches/04_manpage_indent.patch
I: wdm source: patch-not-forwarded-upstream debian/patches/05_french_translation_name.patch
I: wdm source: patch-not-forwarded-upstream debian/patches/06_login_composite.patch
I: wdm source: patch-not-forwarded-upstream debian/patches/07_ld_no_add_needed.patch
X: wdm source: debian-watch-does-not-check-gpg-signature
P: wdm source: maintainer-manual-page debian/man/wdmlogin.conf.5
X: wdm source: upstream-metadata-file-is-missing
Unfortunately, Lintian's website can presently not receive updates. [1]
This commit provides a new, false-positive test case.
Thank you to Axel Becker for bringing the matter to our attention!
[1] https://lists.debian.org/debian-lint-maint/2021/09/msg00148.html
commit a802167cacc917acff0aa7905f0812c9a14b759a
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Sep 19 11:55:02 2021 -0700
Exempt empty packages so declared from empty-binary-package. (Closes: #994711)
For the 'gnat' package mentioned in the bug report, Lintian no longer produces
any hints whatsoever. The lone 'empty-binary-package' tag is gone:
$ bin/lintian /mirror/debian/pool/main/g/gnat/gnat_10.1_all.deb
Unfortunately, Lintian's website can presently not receive updates. [1]
Provides a new, false-positive test case.
Modifies the standard template for d/control, which read in part "This may be
an empty package", so not all test cases are automatically exempt.
Thank you to Nicolas Boulenguez for bringing this matter to our attention, and
also for the patch!
[1] https://lists.debian.org/debian-lint-maint/2021/09/msg00148.html
commit 7428997ded64b57ccf9a7c5874c683b7b8fd188e
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Sep 17 11:17:32 2021 -0700
Offer consistent line numbers in context for autopkgtest-related hints.
Gbp-Dch: ignore
commit 0c1d753c546f2cab158bcd6e82e52d679c99420a
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Sep 16 20:32:19 2021 -0700
Add spelling correction.
Gbp-Dch: ignore
commit a18b695a5c2eac860c161894e1e065317df06cb4
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Sep 16 19:00:44 2021 -0700
Fix documentation for --fails-on command line option. (Closes: #994414)
commit b9cf3dd9465ce5f696df0606c68753d50379ff77
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Sep 15 11:25:35 2021 -0700
Do not flag missing matches for Files-Excluded; uscan already got rid of them. (Closes: #994271)
These files were removed by uscan, which also reads the information in
Files-Excluded, and should not be flagged.
Thanks to Lukas Schwaighofer for reporting the issue!
commit abaf253c3e2e9f35f4fb5543d81871e59f6a0014
Author: Chris Lamb <lamby@debian.org>
Date: Tue Sep 14 15:09:35 2021 +0100
Open new changelog entry.
Gbp-Dch: ignore
lintian (2.106.1)
[PTS] [DDPO]