Git log: commit ae973964b621505e823311b523ff8be8f87805d2
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Apr 4 13:54:13 2021 -0700
Disregard a source's current Standard-Version when looking for newer policy releases.
The 'before' expression is a bit confusing because it disgards
everthing that meets the condition. The new condition causes the
current compliance version to be excluded. The fourth digit is now
being ignored as a non-normative policy change, just as it should.
This bug produced false positives for a wide range of packages,
including for Lintian itself.
$ bin/lintian ../lintian_2.104.0+git.dsc
I: lintian source: out-of-date-standards-version 4.5.1 (released 2020-11-17) (current is 4.5.1.1)
commit f720e2ee514ed2c41c9b8b60c03d6640da5423db
Author: Jelmer Vernooij <jelmer@jelmer.uk>
Date: Sat Apr 3 16:15:52 2021 +0100
Fix archive section mapping for rust development packages.
commit 1d48d0444315c2c4fdda75754a0f6aa50331a693
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sat Apr 3 23:04:38 2021 -0700
Fix tag description for python-teams-merged; reference did not address team merge.
Gbp-Dch: ignore
commit 50b1c1a9dc38a1524ae543c845ef51f40c236663
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Mar 30 08:44:30 2021 -0700
Use semantic versioning for the output of '--version'.
Starting with version 2.6.0, Lintian adopted [1] a semantic versioning
scheme, but between releases we used the output of 'git describe'.
That format was incompatible.
From now on, we use the unreleased commit count as the "patch level"
which under our current scheme is zero for released versions. The
commit reference is kept as what SemVer calls "build metadata" for
easier navigation in git.
The versioning issue came up in Lintian's new web site. The packaging
hints displayed there are sometimes produced with unreleased versions.
At the same time, the Postgres database holds those hints and the tag
descriptions for different Lintian versions. The 'text' data type is
insufficient for ordering those columns. We plan to use a database
extension with a 'semver' data type [2] for that purpose.
We could probably use Debian's own 'debversion' data type [3] but that
module is presumably less well-tested. It furthermore suffers from
performance problems described in the open Bug#935637 (even though
those may not matter for the narrower version scheme Lintian adopted).
[1] see "Misc", https://salsa.debian.org/lintian/lintian/-/tags/2.6.0
[2] https://pgxn.org/dist/semver/doc/semver.html
[3] https://tracker.debian.org/pkg/postgresql-debversion
commit 0f17b217d03aac60b3d4b26497af6ea7f4027a5c
Author: gregor herrmann <gregoa@debian.org>
Date: Sun Mar 28 00:22:21 2021 +0100
spelling: add another correction.
commit 8c313ec25f8ef9abc6b5778d17ceb5dbda4e6ecd
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Mar 21 11:44:50 2021 -0700
Declare the proper prerequisite libsort-versions-perl, which actually exists.
Gbp-Dch: ignore
commit 0dbf6038f9183373ea971202c787f6c6be55e2f7
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Mar 21 11:15:53 2021 -0700
For team-maintained packages, flag names in another team's name space. (See: !353)
Prompted by the Clojure team split from Java, but generalized.
Thanks to Louis-Philippe Véronneau for the inspiration and a
first draft!
commit 21fd3c7d1ae24bf3bb00ffbab6a0dd99acd3503c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Mar 18 22:06:12 2021 -0700
Store changelog items for policy releases in JSON arrays instead of scalars with newlines.
Makes the file readable for people.
Gbp-Dch : ignore
commit e6005b652f0677c1852ca4e07499e67ef4ada0c2
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Mar 18 22:13:25 2021 -0700
Add version 4.5.1.1 to Debian policy releases by updating data source.
Includes some changes to make the check for Standards-Version work
with the newly recognized version with four components.
commit 788b3943352f3661a463aa4e1166e65cd850bb83
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Mar 19 18:04:35 2021 -0700
Correct previous commit; more tag changes from the test suite.
Gbp-Dch: ignore
commit 53ead395a217a8a7969f7f96e3882d2da402c96d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Mar 19 17:12:19 2021 -0700
Drop tag ancient-standards-version; issuance was time variant and difficult to test.
To my knowledge, this was the only tag whose issuance varied over
time, when the same Lintian version was run against the same package.
The test suite required some engineering too to distinguish the tag
from out-of-date-standards-version, which was often overshadowed. All
that created recurring problems merely with the passage of time, and
espacially when new policy versions were recognized.
On a side note, the tag was probably among the more hated ones.
Lintian already issues many burdensome reminders, but none were
perceived as having so empty a purpose by many users.
The dropped tag may ultimately be replaced by other, comparable
diagnostics surrounding changlog entries. That puts the power back in
the hands of maintainers, who can then read the update checklist and
bump the Standards-Version when they have time. At that point, Lintian
may have already reminded them of some of the needed items, anyway.
commit 381c01b15106a2907bc40fe6ae4b14688fcd6fb3
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Mar 16 18:43:10 2021 -0700
Store DEB_HOST_* variables and hardening buildflags in two JSON files.
Uses a familiar and portable file format. Reduces the number of data
files from five to two.
Also, vastly simplifies the program private/refresh-archs, a precursor
to fully automatic updates for our data sources. It will ultimately
solve Bug#885438.
commit 49527dddb0dbba313d191c4950201c8d3d38fc71
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Mar 16 10:04:41 2021 -0700
Rationalize private/refresh-archs before transitioning to new data format.
Drops the "keep" data reminder from data/shared-libs/ldconfig-dirs.
The information is still in the file, but is now included when the
data is generated. The reminder is no longer needed.
Gbp-Dch: ignore
commit 6da0f21080ad5a04e899affa99f3bbf37a224d25
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Mar 15 15:58:29 2021 -0700
Ignore build profiles when flagging use of py3versions in d/rules. (Closes: #978144)
A build prerequisite with python3-all-dev was already sufficient to
permit the use of py3versions in d/rules, but cracklib2 qualified that
with a build profile:
python3-all-dev:any (>= 3.1.3-2~) <!nopython>
The check was relaxed to disregard restrictions for architectures or
build profiles when the prerequisite is declared.
A general question remains whether Lintian should perhaps disregard
such restrictions more often.
The package mentioned in the bug report no longer triggers the tag:
$ bin/lintian /mirror/debian/pool/main/c/cracklib2/cracklib2_2.9.6-3.4.dsc
I: cracklib2 source: out-of-date-standards-version 4.4.1 (released 2019-09-29) (current is 4.5.1)
I: cracklib2 source: patch-not-forwarded-upstream debian/patches/improve_test_737040.patch
I: cracklib2 source: patch-not-forwarded-upstream debian/patches/install-debian-python-modules.patch
P: cracklib2 source: maintainer-manual-page debian/FascistCheck.3
P: cracklib2 source: maintainer-manual-page debian/cracklib-check.8
P: cracklib2 source: maintainer-manual-page debian/cracklib-format.8
P: cracklib2 source: maintainer-manual-page ... use --no-tag-display-limit to see all (or pipe to a file/program)
P: cracklib2 source: package-uses-old-debhelper-compat-version 10
P: cracklib2 source: silent-on-rules-requiring-root
Thanks to Helmut Grohne for bringing the matter to our attention!
commit a90c4dc53d4270c329ae18d6c7d6d9118ae712e2
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Mar 15 16:28:38 2021 -0700
Rename all 'noarch' routines and variables to 'norestrictions' throughout.
The underlying code in Lintian::Relation disregards both build
profiles and architectures. In the upcoming solution to Bug#978144,
Lintian::Relation helped ignore profiles but the bug fix shared data
structures with adjacent code that used it for architectures.
A future rewrite could easily introduce regressions for that bug. All
occurrences of 'noarch' were therefore replaced with 'norestriction'
where appropriate to avoid such confusion in the future.
Anyone seeking to rewrite later will now have to research each tag and
pick an appropriate variant in case Lintian::Relation learns how to
ignore build profiles or architectures separately, but not always both
at the same time.
Gbp-Dch: ignore
commit 92416840d64ca3cd5b8fc0d71a1d17bd28b482bb
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Mar 15 15:23:58 2021 -0700
Drop package file names from tag context for unknown-field. (Closes: #980560)
The file name was added to help users trying to locate the offending
package control file, but it was never really needed. The information
is hereby removed for the good reasons outlined in the bug report.
Thanks to Thorsten Glaser for bringing the matter to our attention!
commit 9e50dc476511279e6307e49e328827b3549c242b
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Mar 15 14:32:38 2021 -0700
Add 'utils.h' to the list of overly generic headers. (Closes: #982322)
Neither packages mentioned in the report still ships a file with the
offending path, but I found older versions that were affected via
Bug#982320 and Bug#509528. They produced the following tags:
$ bin/lintian /tmp/elektroid_1.3-1_arm64.deb
E: elektroid: header-has-overly-generic-name usr/include/utils.h
$ bin/lintian /tmp/libcdparanoia-dev_3.10.2+debian-4_amd64.deb
E: libcdparanoia-dev: header-has-overly-generic-name usr/include/utils.h
Since I had trouble at first to show that the modified check was
working, this commit also includes a test case for utils.h.
Thanks to Andreas Beckmann for bringing the matter to our attention!
commit ce6adcc55b3afb852ca7d30e91383ff6666339a6
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Mar 15 06:42:44 2021 -0700
In test suite, announce failed builds for test packages.
This required the use of the MCE->gather feature to work properly.
Gbp-Dch: ignore
commit b8731eddcbe4ee67d706378eb39cc3d22788e6cc
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Mar 14 22:28:22 2021 -0700
Add libunicode-utf8-perl to Build-Depends.
This module became a prerequisite when some of the auxiliary scripts,
such as private/generate-html-docs, became UTF-8 aware.
commit df0a6404cf36b16748f4afa2b4b15f45e67c517d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Mar 14 20:30:11 2021 -0700
Encode more output to UTF-8.
Some of these were apparently missed in commit a5584fcc.
Gbp-Dch: ignore
commit e115bdaececf89758153eaa2dadf7514ce973195
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Mar 12 10:40:28 2021 -0800
Read error message from Config::Tiny via the advertised mechanism. (Closes: #985064)
The POD for the module [1] explains how to read the error value, but
that procedure was not followed. This implements it correctly.
Lintian now produces the more meaningful error it was supposed to
generate in the first place:
$ bin/lintian --cfg /nonexistent /mirror/debian/pool/main/n/nyancat/nyancat_1.5.2-0.1_i386.deb
syntax error in configuration file /nonexistent: Failed to open file '/nonexistent' for reading: No such file or directory
Thanks to Jakub Wilk for bringing the matter to our attention!
[1] https://metacpan.org/pod/Config::Tiny#errstr()
commit 2446670bb32063c58e2d9582975c5666dc261e94
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Mar 11 18:45:29 2021 -0800
Drop reference to archive keyring from package-installs-apt-sources. (Closes: #983598)
The reference to packages ending in -archive-keyring appears to be
outdated. The quick survey below shows that such keyrings nowadays end
up in /etc/apt/trusted.gpg.d/.
That folder is covered by the tag package-installs-apt-keyring. The
obsolete reference in this tag is herewith removed.
Thanks to Ferenc Wágner for bringing the matter to our attention!
$ find /mirror/debian/pool/ -type f -name '*-archive-keyring*'
/mirror/debian/pool/main/n/neurodebian/neurodebian-archive-keyring_0.41.0_all.deb
/mirror/debian/pool/main/l/leap-archive-keyring/leap-archive-keyring_2017.11.24+nmu1_all.deb
/mirror/debian/pool/main/u/ubuntu-keyring/ubuntu-archive-keyring_2020.06.17.1-1_all.deb
/mirror/debian/pool/main/f/fasttrack-archive-keyring/fasttrack-archive-keyring_2020.12.19_all.deb
/mirror/debian/pool/main/p/pkg-mozilla-archive-keyring/pkg-mozilla-archive-keyring_1.2+nmu1_all.deb
/mirror/debian/pool/main/d/debian-ports-archive-keyring/debian-ports-archive-keyring_2020.02.02_all.deb
/mirror/debian/pool/main/d/debian-archive-keyring/debian-archive-keyring_2021.1.1_all.deb
$ dpkg-deb -c /mirror/debian/pool/main/n/neurodebian/neurodebian-archive-keyring_0.41.0_all.deb
drwxr-xr-x root/root 0 2021-02-15 19:04 ./
drwxr-xr-x root/root 0 2021-02-15 19:04 ./etc/
drwxr-xr-x root/root 0 2021-02-15 19:04 ./etc/apt/
drwxr-xr-x root/root 0 2021-02-15 19:04 ./etc/apt/trusted.gpg.d/
-rw-r--r-- root/root 1511 2021-02-15 19:04 ./etc/apt/trusted.gpg.d/neurodebian-archive-keyring.gpg
drwxr-xr-x root/root 0 2021-02-15 19:04 ./usr/
drwxr-xr-x root/root 0 2021-02-15 19:04 ./usr/share/
drwxr-xr-x root/root 0 2021-02-15 19:04 ./usr/share/doc/
drwxr-xr-x root/root 0 2021-02-15 19:04 ./usr/share/doc/neurodebian-archive-keyring/
-rw-r--r-- root/root 6809 2021-02-15 19:04 ./usr/share/doc/neurodebian-archive-keyring/changelog.gz
-rw-r--r-- root/root 3700 2021-02-15 19:04 ./usr/share/doc/neurodebian-archive-keyring/copyright
$ dpkg-deb -c /mirror/debian/pool/main/l/leap-archive-keyring/leap-archive-keyring_2017.11.24+nmu1_all.deb
drwxr-xr-x root/root 0 2021-01-03 04:42 ./
drwxr-xr-x root/root 0 2021-01-03 04:42 ./etc/
drwxr-xr-x root/root 0 2021-01-03 04:42 ./etc/apt/
drwxr-xr-x root/root 0 2021-01-03 04:42 ./etc/apt/trusted.gpg.d/
-rw-r--r-- root/root 2848 2017-11-07 13:13 ./etc/apt/trusted.gpg.d/leap-archive.gpg
-rw-r--r-- root/root 2869 2017-11-07 13:13 ./etc/apt/trusted.gpg.d/leap-experimental-archive.gpg
drwxr-xr-x root/root 0 2021-01-03 04:42 ./usr/
drwxr-xr-x root/root 0 2021-01-03 04:42 ./usr/share/
drwxr-xr-x root/root 0 2021-01-03 04:42 ./usr/share/doc/
drwxr-xr-x root/root 0 2021-01-03 04:42 ./usr/share/doc/leap-archive-keyring/
-rw-r--r-- root/root 1146 2021-01-03 04:42 ./usr/share/doc/leap-archive-keyring/changelog.gz
-rw-r--r-- root/root 1054 2016-11-18 06:47 ./usr/share/doc/leap-archive-keyring/copyright
drwxr-xr-x root/root 0 2021-01-03 04:42 ./usr/share/keyrings/
-rw-r--r-- root/root 2848 2017-11-07 13:13 ./usr/share/keyrings/leap-archive.gpg
-rw-r--r-- root/root 2869 2017-11-07 13:13 ./usr/share/keyrings/leap-experimental-archive.gpg
$ dpkg-deb -c /mirror/debian/pool/main/p/pkg-mozilla-archive-keyring/pkg-mozilla-archive-keyring_1.2+nmu1_all.deb
drwxr-xr-x root/root 0 2021-01-01 07:47 ./
drwxr-xr-x root/root 0 2021-01-01 07:47 ./etc/
drwxr-xr-x root/root 0 2021-01-01 07:47 ./etc/apt/
drwxr-xr-x root/root 0 2021-01-01 07:47 ./etc/apt/trusted.gpg.d/
-rw-r--r-- root/root 1853 2021-01-01 07:47 ./etc/apt/trusted.gpg.d/pkg-mozilla-archive-keyring.gpg
drwxr-xr-x root/root 0 2021-01-01 07:47 ./usr/
drwxr-xr-x root/root 0 2021-01-01 07:47 ./usr/share/
drwxr-xr-x root/root 0 2021-01-01 07:47 ./usr/share/doc/
drwxr-xr-x root/root 0 2021-01-01 07:47 ./usr/share/doc/pkg-mozilla-archive-keyring/
-rw-r--r-- root/root 574 2021-01-01 07:47 ./usr/share/doc/pkg-mozilla-archive-keyring/changelog.gz
-rw-r--r-- root/root 479 2018-05-27 17:11 ./usr/share/doc/pkg-mozilla-archive-keyring/copyright
$ dpkg-deb -c /mirror/debian/pool/main/d/debian-ports-archive-keyring/debian-ports-archive-keyring_2020.02.02_all.deb
drwxr-xr-x root/root 0 2021-02-02 10:12 ./
drwxr-xr-x root/root 0 2021-02-02 10:12 ./etc/
drwxr-xr-x root/root 0 2021-02-02 10:12 ./etc/apt/
drwxr-xr-x root/root 0 2021-02-02 10:12 ./etc/apt/trusted.gpg.d/
-rw-r--r-- root/root 1210 2021-02-02 10:12 ./etc/apt/trusted.gpg.d/debian-ports-archive-2021.gpg
-rw-r--r-- root/root 1210 2021-02-02 10:12 ./etc/apt/trusted.gpg.d/debian-ports-archive-2022.gpg
drwxr-xr-x root/root 0 2021-02-02 10:12 ./usr/
drwxr-xr-x root/root 0 2021-02-02 10:12 ./usr/share/
drwxr-xr-x root/root 0 2021-02-02 10:12 ./usr/share/doc/
drwxr-xr-x root/root 0 2021-02-02 10:12 ./usr/share/doc/debian-ports-archive-keyring/
-rw-r--r-- root/root 475 2016-01-24 14:59 ./usr/share/doc/debian-ports-archive-keyring/README
-rw-r--r-- root/root 1689 2021-02-02 10:12 ./usr/share/doc/debian-ports-archive-keyring/changelog.gz
-rw-r--r-- root/root 1007 2010-05-13 02:31 ./usr/share/doc/debian-ports-archive-keyring/copyright
drwxr-xr-x root/root 0 2021-02-02 10:12 ./usr/share/keyrings/
-rw-r--r-- root/root 23857 2021-02-02 10:12 ./usr/share/keyrings/debian-ports-archive-keyring-removed.gpg
-rw-r--r-- root/root 2420 2021-02-02 10:12 ./usr/share/keyrings/debian-ports-archive-keyring.gpg
$ dpkg-deb -c /mirror/debian/pool/main/d/debian-archive-keyring/debian-archive-keyring_2021.1.1_all.deb
drwxr-xr-x root/root 0 2021-02-25 09:38 ./
drwxr-xr-x root/root 0 2021-02-25 09:38 ./etc/
drwxr-xr-x root/root 0 2021-02-25 09:38 ./etc/apt/
drwxr-xr-x root/root 0 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/
-rw-r--r-- root/root 8700 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-bullseye-automatic.gpg
-rw-r--r-- root/root 8709 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-bullseye-security-automatic.gpg
-rw-r--r-- root/root 2453 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-bullseye-stable.gpg
-rw-r--r-- root/root 8132 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-buster-automatic.gpg
-rw-r--r-- root/root 8141 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-buster-security-automatic.gpg
-rw-r--r-- root/root 2332 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-buster-stable.gpg
-rw-r--r-- root/root 7443 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-stretch-automatic.gpg
-rw-r--r-- root/root 7452 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-stretch-security-automatic.gpg
-rw-r--r-- root/root 2263 2021-02-25 09:38 ./etc/apt/trusted.gpg.d/debian-archive-stretch-stable.gpg
drwxr-xr-x root/root 0 2021-02-25 09:38 ./usr/
drwxr-xr-x root/root 0 2021-02-25 09:38 ./usr/share/
drwxr-xr-x root/root 0 2021-02-25 09:38 ./usr/share/doc/
drwxr-xr-x root/root 0 2021-02-25 09:38 ./usr/share/doc/debian-archive-keyring/
-rw-r--r-- root/root 1091 2021-02-24 13:08 ./usr/share/doc/debian-archive-keyring/README
-rw-r--r-- root/root 3514 2021-02-25 09:38 ./usr/share/doc/debian-archive-keyring/changelog.gz
-rw-r--r-- root/root 1243 2021-02-05 08:05 ./usr/share/doc/debian-archive-keyring/copyright
drwxr-xr-x root/root 0 2021-02-25 09:38 ./usr/share/keyrings/
-rw-r--r-- root/root 8700 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-bullseye-automatic.gpg
-rw-r--r-- root/root 8709 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-bullseye-security-automatic.gpg
-rw-r--r-- root/root 2453 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-bullseye-stable.gpg
-rw-r--r-- root/root 8132 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-buster-automatic.gpg
-rw-r--r-- root/root 8141 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-buster-security-automatic.gpg
-rw-r--r-- root/root 2332 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-buster-stable.gpg
-rw-r--r-- root/root 55625 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-keyring.gpg
-rw-r--r-- root/root 36873 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-removed-keys.gpg
-rw-r--r-- root/root 7443 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-stretch-automatic.gpg
-rw-r--r-- root/root 7452 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-stretch-security-automatic.gpg
-rw-r--r-- root/root 2263 2021-02-25 09:38 ./usr/share/keyrings/debian-archive-stretch-stable.gpg
commit 1a0614c230a6314e1513bfe96f9bc76da90dad81
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Mar 11 17:21:10 2021 -0800
Flag the use of DEB_BUILD_MULTIARCH in some Debian files. (Closes: #983219)
The two sources mentioned in the report now trigger this tag:
$ bin/lintian /tmp/cubature_1.0.3\%2Bds-3.dsc
E: cubature source: illegal-variable DEB_BUILD_MULTIARCH debian/libcubature-dev.links
E: cubature source: illegal-variable DEB_BUILD_MULTIARCH debian/libcubature0.install
$ bin/lintian /tmp/mozc_2.26.4220.100\%2Bdfsg-2.dsc
E: mozc source: illegal-variable DEB_BUILD_MULTIARCH debian/uim-mozc.install
Thanks to Helmut Grohne for the clearly written feature request!
commit dac960b63d4d307fadb76e5d50e178d87c031d01
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Mar 11 09:38:01 2021 -0800
Flag systemd temporary files placed in /var/run. (Closes: #984678)
Like the related tag systemd-service-file-refers-to-var-run this tag
is issued at the info level. (The bug report used an old name.)
The list from the codesearch.d.o link in the report flags package
sources, but not all of those files in source packages are actually
being installed. The new tag looks at installed files.
We were able to validate the tag with the following packages (but not,
for example, with celery, sagan, samba or wesnoth-14):
$ bin/lintian /mirror/debian/pool/main/k/krb5/krb5-otp_1.18.3-4_amd64.deb
I: krb5-otp: systemd-tmpfile-in-var-run usr/lib/tmpfiles.d/krb5-otp.conf
$ bin/lintian /mirror/debian/pool/main/v/vrfydmn/vrfydmn_0.11.0-1_all.deb
I: vrfydmn: systemd-tmpfile-in-var-run usr/lib/tmpfiles.d/vrfydmn.conf
$ bin/lintian /mirror/debian/pool/main/v/vsftpd/vsftpd_3.0.3-13_amd64.deb
I: vsftpd: systemd-tmpfile-in-var-run usr/lib/tmpfiles.d/vsftpd.conf
$ bin/lintian /mirror/debian/pool/main/x/xrootd/xrootd-server_5.0.3-4_amd64.deb
I: xrootd-server: systemd-tmpfile-in-var-run usr/lib/tmpfiles.d/xrootd.conf
$ bin/lintian /mirror/debian/pool/main/z/zoneminder/zoneminder_1.34.23-1_amd64.deb
I: zoneminder: systemd-tmpfile-in-var-run usr/lib/tmpfiles.d/zoneminder.conf
As a side note, the related tag for tmpfile declarations installed in
the wrong location was renamed to misplaced-systemd-tmpfiles. The
correct location is described in that tag's description. It is part
of our effort to make tag names less specific when the details is not
needed to distinguish tags from another.
This commit regenerates the profiles.
Thanks to Michael Biebl for this clearly written and well-researched
feature request!
commit 2ee16d25316acd15d63a7077d54300a6c43411c8
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Mar 11 09:46:28 2021 -0800
Add perltidy's backup files to . gitignore.
Gbp-Dch: ignore
commit 8df1045c67040f9611f131e3e74cbe9bbdac5e5d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Mar 10 10:41:22 2021 -0800
Centralize operation of xargs in preparation for implementation in Perl.
A Perl implementation of xargs would make it possible to associate the
input for each invocation of the underlying command to the resulting
output.
It is helpful for programs like 'readelf' that produce different
output when called with multiple arguments. The number of arguments is
easily available, whicn helps with parsing.
Perhaps more significantly, it also allows the use of parallel
execution from within Perl without the locking described in the 'xarg'
manual page.
commit a925f208e4ea3cd9cf22e42c4bcacb944655038f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Mar 1 09:55:16 2021 -0800
Assume that all interactive terminals are hyperlink capable but change default to off.
The implementation of OSC 8 hyperlinks [1] has come a long way. Many
programs enable hyperlinks for all terminals and use a blacklist for
terminals that are known not to support them.
GCC is reported to do that especially well. Lintian should ultimately
implement something similar. For the time being, we merely assume that
all interactive terminals are hyperlink capable, but no blacklist is
implemented at this time.
To avoid stray characters in terminals that not support the feature,
the display of hyperlinks was disabled by default. Users may wish to
add 'hyperlinks = on' to their Lintian configuration.
[1] https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
commit 5c2325c2be4b8003a697d9f256d58db44d2a692b
Author: Jelmer Vernooij <jelmer@jelmer.uk>
Date: Mon Feb 22 16:52:41 2021 +0000
Fix typo: valgring => valgrind.
commit e84f92a1fe0254f28f3c193a1606f78dd7dd6e6e
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Feb 15 09:42:27 2021 -0800
Accept the virtual package dh-sequence-dkms as B-D for 'dh --with-dkms'. (Closes: #982834)
From past experience the alternative appeared more appropriately
placed in the '-manual' version of the data file.
The offending tag is gone:
bin/lintian ../bugs/dkms/r8168_8.048.03-3.dsc
I: r8168 source: patch-not-forwarded-upstream debian/patches/linux-3.5.patch
I: r8168 source: patch-not-forwarded-upstream debian/patches/linux-3.6.patch
Thanks to Andreas Beckmann for filing the bug, and for the fix!
commit 7814de9ac5e80a57b654fab4600d723b6a9c87e7
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Feb 15 09:59:20 2021 -0800
Drop 'use autodie' everywhere; handle errors explicitly.
The 'autodie' pragma breaks many expectations for error handling and
fails to emulate parser quirks in functions like system and exec. Much
of that behavior is documented in the last paragraph here, and also in
the "Gotchas" section below:
https://perldoc.perl.org/autodie#FUNCTION-SPECIFIC-NOTES
Thanks to Grinnz from IRC:#perl-help for these pointers!
Gbp-Dch: ignore
commit 8f16afb39a1f368d856a41927b57c3c2f6206580
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Feb 12 13:39:34 2021 -0800
Improve formatting and wording in tag description for patch-not-forwarded-upstream.
Gbp-Dch: ignore
commit 4888df9f50ba03e211c538556194e589c0944804
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Feb 12 09:44:28 2021 -0800
Do not pretend to show hashbang in hint context for unusual interpreters. (Closes: #982630)
For scripts using 'env', the hint context was confusing because it did
not match the actual hashbang. We now list only the offending
interpreter without a hashbang (or 'env', if it was used).
The bug report makes other important points. They are adressed below:
> Either way, the warning message shouldn't omit /usr/bin/env if it's
> present in the file in question, as the mismatch between the warning and
> the file is a distraction from the intent of the message.
This check traditionally disregarded the use of 'env' in scripts (but
not in maintainer scripts). It would be inappropriate to show the full
hashbang.The tag relates only to the interpreter portion.
> If lintian is in fact trying to complain about "python" vs "python3" (if
> we're trying to ensure that we don't have anything pointing to
> "python"), that is a sufficiently important, specific situation that it
> should offer a dedicated tag for it.
I agree with your sentiment. Unfortunately, the interpreter tags are
already differentiated, i.e. in your case 'examples'. The wisdom of
the existing distinctions is not obvious and seems inferior to the
issue you raised, but implementing your suggestion would require many
new tags, which we are unlikely to embrace.
We would, however, entertain a request to simplify the existing
interpreter tags in order to flag the unversioned Python call in a
better way. Please file a bug if you believe that it is a worthwhile
trade-off for users.
> /usr/bin/python is supposed to be used for things that are both py3-
> and py2-compatible (which hopefully these examples all are).
Based on the information we have, the unversioned /usr/bin/python is
going away in the upcoming 'bullseye' release. The corresponding
changes were made in response to this merge request
https://salsa.debian.org/lintian/lintian/-/merge_requests/334
in this and surrounding commits:
https://salsa.debian.org/lintian/lintian/-/commit/69d52d7b4c9dbf391b23dced6e6de920905f54ac
Please file a bug for the unversioned Python interpreter to be
recognized as valid, if the information we have about the 'bullseye'
release is incorrect.
Thank you to dkg for bringing these matters to our attention!
commit b7078695691b5ff4733c25544404b4e25147389f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Feb 5 13:51:19 2021 -0800
Flag PyPI homepages in source control files. (Closes: #981932)
The condition here received its own tag. Eventually, it could be
desirable combine the tag with similar warnings for other languages or
packaging systems, but Lintian's rule of issuing each tag only in one
check would drop the logic from the Python language, where it arguably
belongs.
On the upside, the custom tag allows for a generous explanation with
PyPI-specific references. Users will find it easier to understand.
Thanks to Paul Wise for bringing this matter to our attention!
commit 0a21349802049ea4e56b565d5bb101756bd15aaf
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Feb 5 10:17:09 2021 -0800
Flag Rubygem homepages in source control files. (Closes: #981935)
The condition here received its own tag. Eventually, it could be
desirable combine the tag with similar warnings for other languages or
packaging systems, but Lintian's rule of issuing each tag only in one
check would drop the logic from the Ruby language, where it arguably
belongs.
On the upside, the custom tag allows for a generous explanation with
Rubygem-specific references. Users will find it easier to understand.
Thanks to Paul Wise for bringing this matter to our attention!
commit 616a94072c81637ba71f4e452460dac704a0ce94
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Feb 3 15:28:53 2021 -0800
Allow environment prefix when recognizing 'dh' sequencer. (Closes: #981712)
While an improvement, this commit does not work for variables that are
assigned values containing spaces. A shell script parser or simulator
would probably be better.
Provides a test case to guard against future breakage (and a possible
reopening of the bug).
Also, the faketime package no longer provokes the tag no-dh-sequencer:
$ bin/lintian /mirror/debian/pool/main/f/faketime/faketime_0.9.7-3.1.dsc
I: faketime source: out-of-date-standards-version 4.2.1 (released 2018-08-25) (current is 4.5.1)
P: faketime source: package-uses-old-debhelper-compat-version 11
P: faketime source: uses-debhelper-compat-file
Thanks to dkg for bringing this issue to our attention!
commit 2503898a3ac5cd3da8c3504a5aa02a19f4b40e6c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Jan 26 10:48:45 2021 -0800
Implement usr-merge; flag files shipped in /bin, /sbin or /lib.
Implements the merged-usr proposal adopted by the majority of Linux
distributions. The tag is marked as a classification for now. It is
not visible to users without additional command-line arguments.
For details, including some of the relevant discussions in Debian,
please consult the references provided in the tag description.
The test packages provided here expect a Bourne-compatible shell to be
available at /usr/bin/sh. Many other tests still use the legacy
location.
Following this commit, the test suite may complete successfully only
on a system that was already converted.
Regenerates profiles.
commit 53af26255a6d4fbd261e4a98cdbb1653f48d598d
Author: Alexandre Rossi <alexandre.rossi@gmail.com>
Date: Tue Sep 1 12:10:15 2020 +0200
Recognize empty and very small files as architecture-independent. (See: !323)
Finds more installation packages that could be marked Architecture:
all.
commit 600b130a569c9344c104e8602059913bce14da58
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Jan 31 18:07:49 2021 -0800
Stop classifying test packages as empty.
Some helper routines that classify installation packages inadvertently
marked all test packages in the test suite as empty, because their
standard long description from t/defaults mentioned, as an apparent
precaution, that test packages may be empty.
After some consideration, the classification criteria were narrowed to
exclude the keyword "empty" while the standard description for test
packages was kept as it was.
Adds several tags for empty-package that appeared in general, non
check related tests as a result.
Gbp-Dch: ignore
commit 68893cea0be6a5459de2b6ee267f56e01c2e140d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Jan 31 12:20:04 2021 -0800
Remove script to generate qa-list.txt from UDD; transferred to web site.
Going forward, this script will be maintained in the Git repo for the
web site at:
https://salsa.debian.org/lintian/detagtive
It was added there in commit 82646d44.
Gbp-Dch: ignore
commit cddbaa8d1de3993f6382cb6ce917faf28db2d797
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Jan 28 18:52:48 2021 -0800
Flag duplicates in d/py3dist-overrides. (Closes: #980987)
Regenerates profiles.
commit bb9e109760488f096fc509746edfdc9a174b8712
Author: Xavier Guimard <yadd@debian.org>
Date: Thu Jan 28 18:19:04 2021 +0100
Fix and simplify search when parsing pkg-js-autopkgtest files. (Closes: #981279)
Fixes the filename match when a glob points to a directory.
commit 2e0f6dae25728b726bcb71aa5e198fec46b7f843
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Jan 28 08:59:29 2021 -0800
Do not flag Python3 entry point definitions as out-of-place documentation. (Closes: #981268)
For reference, please see:
https://packaging.python.org/specifications/entry-points/
commit badeb2eb37017edef5dcd8a06d98ee5134177480
Author: Emmanuel Bourg <ebourg@apache.org>
Date: Tue Jan 26 13:02:03 2021 +0000
Detect obsolete Servlet API 3.1. (See: !348)
The libservlet3.1-java package has been superseded by libservlet-api-java.
commit 2c9361f45f1975098a62ffa032a71314e01a3931
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Jan 27 16:59:11 2021 -0800
Tighten regex for no-op-testsuite to stop false positives. (Closes: #980824)
Does not catch cases that contain comments in addition to the useless
No longer issues the tag for these sources:
$ bin/lintian /mirror/debian/pool/main/b/bcftools/bcftools_1.11-1.dsc
$ bin/lintian /mirror/debian/pool/main/d/dask.distributed/dask.distributed_2.10.0+ds.1-3.dsc
$ bin/lintian /mirror/debian/pool/main/p/php-zend-code/php-zend-code_4.0.0-2.dsc
$ bin/lintian /mirror/debian/pool/main/p/python-pysam/python-pysam_0.15.4+ds-3.dsc
$ bin/lintian /mirror/debian/pool/main/s/sleef/sleef_3.5.1-1.dsc
commit f8ea40bfffad7802f8a3957b381b82f045c0ec1c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Jan 27 10:30:25 2021 -0800
Tolerate manual pages for subcommands when main command is documented. (Closes: #947258)
Prevents the tag spare-manual-page from being isseud for subcommands
like 'git add' in packages like notmuch or libreswan. Works only when
the main command has its own manual page.
The use of the underscore in libreswan's file names required special
casing because underscores are considered word characters.
Thanks to dkg for the interest in this bug, as well as the repeated
pointers and the necessary patience until now!
commit 9c0321f5c7c889429b41562e898e76575fcca46e
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Jan 26 14:44:37 2021 -0800
Use proper PostgreSQL BOOLEAN in script to generate qa-list.txt from UDD.
A database upgrade probably rendered invalid the previous use of "1"
without an explicit cast to the BOOLEAN type.
Now uses "true" instead.
Gbp-Dch: ignore
commit cd3e965caba8ce0fe6a1c294fdd21aa9af213075
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Jan 21 10:15:31 2021 -0800
Always print full path to patch files. (Closes: #980247)
Makes the context for tags related to patches more consistent. Patch
files are now always identified via their full path in the source
package.
As the filer noted, showing the full path may ease packaging for less
experienced maintainers. They are also more likely to rely on Lintian
for guidance.
More experienced users may prefer the short path. We are instead
making tag names shorter, and the context longer. For tags related to
patches, it means that paths are getting longer.
Working with tag names often, we believe that shorter tag names are
easier to remember. Accordingly, we try to be precise with tag names
only when needed, for instance when tags distinguish closely related
topics. Whenever possible, we provide any necessary precision in the
tag context. It makes tags more versatile.
This philosophy applies to many tags. For example, a relatively large
subgroup of names contains the word "debian". (Tags for changelogs or
watch files are good examples.) The word usually indicates that a
source file is located inside the ./debian directory. We perceive such
a tag naming scheme as cumbersome.
Many parts of our packaging infrastructure are named after Debian. The
moniker is generally overloaded, and often ambiguous. It is much
clearer to provide the full path of a file.
As a side note, we also no longer preface tag names with the name of
the check that issues them (although such a scheme still exists with
name-spaced tags; see continuous-integration.)
We sincerely hope that this solution is acceptable even though the
issue was resolved against the filer's stated preference.
Thank you to Alex Beckert for his keen eye, and also for remaining one
of our most active bug reporters!
commit f7f4ac033fcc0939fe26ac59732878c7ad46be3b
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Jan 13 09:33:19 2021 -0800
Treat NMU edge cases for non-consecutive-debian-revision. (Closes: #942013)
The bug report was confirmed by several parties. It even offers some
history because it was once reopened. Unfortunately, none of the false
positives mentioned in it seemed to work anymore.
In theory, this commit should conclusively resolve the bug, yet right
now the only confirmation for that claim is the false positive fixed
in the test suite. Please reopen the bug and amend it, if needed.
This effort was prompted by Mattia Rizzolo on IRC, who appealed
repeatedly for attention to this bug over the course of several
months. Thank you for your patience, Mattia!
commit a222bb479d6f309e1f3d64961275511c9c1fd785
Author: Paul Wise <pabs@debian.org>
Date: Thu Dec 31 13:07:13 2020 +0800
spelling: Add another correction
commit f0112bccf3f5130768bdcd99b822c48bee1cb3a2
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 18:12:18 2020 -0800
Anchor some negative regex assertions for architectures in the rear, and all in front. (See: !300)
Jiří Paleček made some good points about these regular expressions in
the MR noted above, but I do not agree with the suggested approach to
solving the problem.
I believe the regular expressions at issue here require anchors in the
rear so the negative (?!GNU) assertions hold for the full remainder of
each string, and not just for a part of them.
The anchors are added here.
I came up with what I think is a better solution when looking at the
example at https://regex101.com/r/14KozX/1 that Jiří so kindly
provided.
Jiří's wording also showed the way by stating that the expression
matches (his quotes) "a line which contains a word starting with
GNU/Linux, or any other word not starting with GNU". Matching words
is not enough. We wish to match the entire line, and anchoring does
exactly that.
Thanks to Jiří Paleček for the thoughtful suggestion, and for the
extraordinary patience before the merge request was resolved!
commit 89049561ea93787a0f7169229627e2e01765805d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 16:40:43 2020 -0800
In harness test, continue to allow commas as field separators for profiles.
All profiles we ship were converted. There would be no occasion to
allow commas in our harness test except our test checks all profiles
that are present.
The test works fine on a development source tree but not when testing
an installed version, as autopkgtest does. Lintian depends on dpkg,
which installs its own profile. That profile was not yet converted.
A single tag name there is misparsed to include a comma at the end:
Failed test 'Tag package-uses-vendor-specific-patch-series, exists
in profile /usr/share/lintian/profiles/dpkg/main.profile'
The error showed up only in Salsa CI. This commit should fix it.
A better course of action might be to test only our profiles, if
possible, or perhaps to test none at all.
Gbp-Dch: ignore
commit 77605f0eef9b50994caa0fcfa5099d2e155ad8bb
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 14:29:48 2020 -0800
Stop shipping modules in system path. (Closes: #968011)
commit d43799ae30f55e8a211281295d4508b11d022147
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 14:25:38 2020 -0800
Provide a dedicated, non-public executable to obtain the latest policy version from Lintian data. (See: #978672)
commit abffad321d6d1db236e6aefda9fd68eaaa1fa914
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 15:12:19 2020 -0800
Set a sybolic link to find our checks when installed.
Profiles currently look only in the shorthand used by users when
supplying custom checks. Perhaps they should also look in:
lib/Lintian/Check
Attempts to cure a Salsa CI failure following this commit:
https://salsa.debian.org/lintian/lintian/-/commit/e50792d02fef3fa467025c5205544d65b15091c4
Gbp-Dch: ignore
commit 97955b9bc9bb942f5aec21587a15b62a65e58368
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 14:31:05 2020 -0800
Do not search user configurarion folders when opening profiles in test suite.
Attempts to cure a Salsa CI failure following this commit:
https://salsa.debian.org/lintian/lintian/-/commit/e50792d02fef3fa467025c5205544d65b15091c4
Gbp-Dch: ignore
commit 386d5707c4ac1a95023c4dbf481b852d89227b36
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 13:19:05 2020 -0800
Drop IO::Async from test suite, and with that from Lintian altogether.
Gbp-Dch: ignore
commit 06b4652ee6f630ebddc35e7a1ab55f29a8cc0725
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 13:17:47 2020 -0800
Convert ./private/build-test-packages to MCE::Loop.
Gbp-Dch: ignore
commit eb3abea3a1688a6a7c47be4cf3c9bda64d069865
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 11:13:07 2020 -0800
Simplify output engines; drop their Moo class structure and any shared attributes.
Gbp-Dch: ignore
commit e0b96c6f64ce3bb0a3c34ceedbda3eeed696d532
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 10:31:14 2020 -0800
Issue verbose messages for EWI output only.
Verbose output is not available for any of the other format options,
such as JSON or HTML.
commit 697de993f07145e9f4c00aaec3a87514c4bca29c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 29 06:03:52 2020 -0800
Always send all debugging and status information to STDERR.
Greatly simplifies the handling of file descriptors in Lintian.
commit 3b2a0f8bb2a97cbd5119f2c52bb7656eb899c333
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 13:52:43 2020 -0800
Adopt the perlcritic policy ControlStructures::ProhibitYadaOperator.
commit 6746b2552e1a424ba68555297693d4d453179dd9
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 13:48:38 2020 -0800
Adopt the perlcritic policy Miscellanea::ProhibitUnrestrictedNoCritic.
commit 3f466ce0463685e41e193d098317d3ad30ec1cda
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 13:45:54 2020 -0800
Adopt the perlcritic policy Miscellanea::ProhibitUselessNoCritic.
commit e50792d02fef3fa467025c5205544d65b15091c4
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 12:21:41 2020 -0800
Rationalize handling of user-based include directories; centralize in Profile.
Eliminates duplication and provides greater certainty as to which
folders are actually being used.
Gbp-Dch: ignore
commit 3860b0bf7ab93d423a425060abc5332b341762a7
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 07:44:20 2020 -0800
Prefer spaces over commas as field separators in profiles.
Commas are not needed, and spaces are more convenient. None of
Lintian's identifiers contain spaces. All other parts of Lintian like
tag and test specifications already use spaces.
Commas are still accepted but, from now on, they generate a warning.
Please also note that newlines are now trimmed transparently. That
allows a clear multi-line formatting style everywhere.
It is easy on the eyes and much better for diffs. In Git, it reduces
the complexity of merge conflicts. For example, the kali.main profile
now reads:
Disable-Tags:
bugs-field-does-not-refer-to-debian-infrastructure
no-nmu-in-changelog
source-nmu-has-incorrect-version-number
Instead of previously:
Disable-Tags: bugs-field-does-not-refer-to-debian-infrastructure,
no-nmu-in-changelog, source-nmu-has-incorrect-version-number
commit 28ad4d81496f4adb5c691c0abb08b4c1e7044453
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 05:13:27 2020 -0800
Do not fail on dangling symlinks when looking for obsolete, missing or invalid content. (Closes: #978534)
With this change, Lintian no longer produces source-is-missing as
mentioned in the bug report. It also drops this related tag:
P: restfuldb source: source-contains-prebuilt-javascript-object website/js/jquery-3.3.1.min.js
The package from the bug report now generates the following packaging
hints:
bin/lintian /mirror/debian/pool/main/r/restfuldb/restfuldb_0.15.0+dfsg-1.dsc
I: restfuldb source: out-of-date-standards-version 4.5.0 (released 2020-01-20) (current is 4.5.1)
I: restfuldb source: patch-not-forwarded-upstream debian/patches/db-dir.patch
I: restfuldb source: patch-not-forwarded-upstream debian/patches/htaccess.patch
I: restfuldb source: patch-not-forwarded-upstream debian/patches/no-build-dependencies.patch
I: restfuldb source: patch-not-forwarded-upstream ... use --no-tag-display-limit to see all (or pipe to a file/program)
P: restfuldb source: package-uses-old-debhelper-compat-version 12
Thanks to Andrius Merkys for a concise and well-articulated bug
report!
commit f26799b1125798e5935aeac846472483a6a833b5
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 04:35:46 2020 -0800
Allow interpolation for missing tag names.
Gbp-Dch: ignore
commit 5cb987c5d2e0f1e72778105b94156b66d54c6bb8
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 28 04:25:10 2020 -0800
Detect Rust boilerplate in package descriptions. (See: !344)
Thanks to Sylvestre Ledru for an early version of this work!
commit 0e95c5846f7a14a7af683492d300c8bc5ef89b53
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 27 13:59:05 2020 -0800
Provide Index->sorted_list as an immutable array reference.
Now conveniently provided as a read-only Moo attribute, without
explicit caching.
Gbp-Dch: ignore
commit 0991cf18429257688e5fbbc4986175cd553efe26
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 27 11:40:53 2020 -0800
Implement the perlcritic policy ValuesAndExpressions::ProhibitLeadingZeros.
commit 7c20102e15b1b9f35fa8f0735162372075927057
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 8 06:42:49 2020 -0800
Implement the perlcritic policy ValuesAndExpressions::ProhibitMagicNumbers.
commit 97f6bc7f99cafa95a5be1c8edbb3a8f2f820d845
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 27 10:51:42 2020 -0800
Bring the octal context of octal-permissions in line with other octal output in related tags.
This change was commited separately because it drowns out smaller but
more important changes in adjacent commits.
Gbp-Dch: ignore
commit 3f71a11f52328e4a6fdc508716ebf2649b0bdd4b
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 27 09:57:46 2020 -0800
Restructure tags for file permissions; combine tags for setuid/setgid executables.
Simplifies the conditional logic and nesting depth of the check for
file permissions. Combines three setuid/setgid-related tags into a new
one called elevated-privileges.
commit 8853e27e2f202945858e60c7e58d726aae6f43a8
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sat Dec 26 21:25:01 2020 -0800
Refuse to read installable control data in national encodings.
Finally processes control files consistently between sources and
installable packages. Implements the Unicode release goal [1] with
respect to our primary package control files.
Some thought was given to issuing a tag instead of a hard program
error, but the resulting complexity did not outweigh the expected
benefits of this change.
[1] https://wiki.debian.org/ReleaseGoals/utf-8
commit 6deb0513c01632f6a10747038a97f8c37e107213
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 23 18:07:25 2020 -0800
Recognize Architecture and Classes as valid fields in d/tests/control. (Closes: #977976)
According to the specification [1] those fields are valid. Thanks to
Christoph Biedl for pointing it out!
[1] https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst
commit 7cd7b450355d49096fe2096694e59fce0dfdacd6
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 21 16:06:57 2020 -0800
Rename the check init.d to init-d.
It was the only check that had a period in the name. It required a
special case when deriving check names from file names, for example
when generating profiles.
Gbp-Dch: ignore
commit c0e31efea61c0a7ddfbef7eccbc7d8ea2ca066e5
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 21 16:11:35 2020 -0800
Fix generation of profiles after recent changes to Perl module names.
Gbp-Dch: ignore
commit 9aacf5da38c9846b6aefa840484e336f5404fb95
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 21 15:24:32 2020 -0800
Combine, rename two confusing debhelper tags. (Closes: #977332)
The new tag is called no-versioned-debhelper-prerequisite and is alwys
a warning. The decision was made to reduce confusion for users.
According to Debian Trends, debhelper levels below 10 are rapidly
losing popularity in the archive.
commit c9601fc502bc8f794671b7193a7158d9a356d6d6
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Mon Dec 21 13:39:09 2020 -0800
For manual pages, extract section information correctly from .TH header. (Closes: #962601)
The value of the original filing of this bug is unclear. The use of a
comma-separated list with whitespaces that separate multiple names is
very rare.
The manual page mentioned in the bug report did not do so when this
message was written. It is unclear where the filer found it. At the
time of filing, the version then in unstable (2.6.9-1) shipped a
manual page that read:
.TH MOUNT.CIFS 8 "" "" ""
The version now in unstable (2.6.11-10 ships a header with whitespace
but no comma. That is likely an error:
.TH MOUNT.CIFS MOUNT.SMB3 8 "" "" ""
The only manual page that was remotely relevant that we were able to
find was gv2gml.1 from graphviz, which had a comma but no whitespace.
Thanks to DLange fo pointing it out! That header read:
.TH GML2GV,GV2GML 1 "24 June 2011"
Either way, we hope that this change will put the bug to rest. At a
minimum, it seems to silence the run time errors that have been
showing up since we attempted to resolve this bug the first time
around.
commit 41c3d174a7266bf58f79732a0373e92c41e85609
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sat Dec 19 18:13:50 2020 -0800
Implement the perlcritic policy ValuesAndExpressions::ProhibitNoisyQuotes.
commit 44c38208a9aec95fc1490a34ff0e116e3d09478e
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sat Dec 19 18:13:33 2020 -0800
Adopt the perlcritic policy Freenode::PackageMatchesFilename.
commit 6d0806ce40e79e413fb0d0eccb5459261b90bafc
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Dec 18 12:19:45 2020 -0800
Do not generate documentation from checks (restore previous behavior to fix a CI issue).
Restores the behavior from before checks were moved in hope of fixing
the Salsa CI failure.
As a side note, we should probably enable the POD requirement in
checks, and also generate and ship the resulting documentation.
Gbp-Dch: ignore
commit 1c170b339be50bcebd385b1be6daa692d17950d9
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Dec 18 11:58:08 2020 -0800
Provide a convenience link to checks as advertised in the previous commit.
Gbp-Dch: ignore
commit a3a0961e2e132e502e4f12f7dcc6998b31b6659f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Dec 18 10:46:12 2020 -0800
Move all checks into the module name space under ./lib; provide symbolic link.
Traditionally, the module names for checks in Lintian did not match
their location in the file system. In Perl, that leads to several
serious shortcomings that are remedied in this commit series.
Here, checks are moved to lib/Lintian/Check. A symbolic link will be
provided as a convenience in the next commit.
The move prevents modules from being absent due to typos. It also
ensures that all modules are loaded under the names we expect. Some of
these assertions are not a possible without the help of the perlcritic
policy Freenode::PackageMatchesFilename, which we hope to enable
shortly.
Together with the changes to follow, this may break pkg-js-tools and
pkg-perl-tools. The maintainers of those packages will be advised
separately, as has been our custom.
commit 7865af392125d33fb84b5266be3063dd3977596c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Fri Dec 18 11:27:57 2020 -0800
Drop Lintian::Check::Info from obscure file; reason for Bug#968011.
This is the precise reason for removing Lintian's modules from the
system path as described in Bug#968011. On a co-maintainer's machine
the deleted module was satisfied from the system path.
More diligent might have caught the left-over reference, but the
error would have been caught immediately if our private modules from
installed versions were not also available via the system path.
Gbp-Dch: ignore
commit 27b5ce2a0a996af892b3fa95a02f1220eb61d881
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Dec 17 19:01:59 2020 -0800
Merge Check::Info into Profile and Group; free up Lintian::Check as a name space for checks.
Traditionally, the module names for checks in Lintian did not match
their location in the file system. In Perl, that leads to several
serious shortcomings that are remdied in this commit series. In the
future, checks will be kept in lib/Lintian/Check.
Symbolic links will be provided as a convenience where appropriate.
The move prevents modules from being absent due to typos. It also
ensures that all modules are loaded under the names we expect. Some of
these assertions are not a possible without the help of the perlcritic
policy Freenode::PackageMatchesFilename, which we hope to enable
shortly.
Together with the changes to follow, this may break pkg-js-tools and
pkg-perl-tools. The maintainers of those packages will be advised
separately, as has been our custom.
Gbp-Dch: ignore
commit da82572b291bb461eae2926d17ba01dfa77e3c50
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Dec 17 14:58:49 2020 -0800
Switch to MCE::Loop for test prparation in ./private/runtests.
This is an experimental change since MCE performed relatively well to
generate tags for the website.
It is not a vote against IO::Async. We are simply desparate to get to
the bottom of some signal handling issues in TAP::Harness that are
probably caused by something else. For details, please see Bug#974575.
Gbp-Dch: ignore
commit 6c4317474a925efb40de05ba2cad31f0d4e2e7bc
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Dec 17 14:29:43 2020 -0800
Ignore SIGWINCH in the test suite. (Closes: #974575)
The source of this odd behavior was not identified. It continued under
MCE::Loop when that was used experimentally instead of IO::Async.
Based on past experience, there was a concern about IO::Async and
SIGCHLD. Either module, however, helped only briefly to prepare
tests.
The problem occurred already in the test scripts before any custom
loops were started, so the loop modules are not at fault.
The bulk of the work in private/runtests took place under the aegis of
TAP::Harness->aggregate_tests. As noted in the bug, something in the
module initialization caused it, and probably not in Perl.
The upcoming merging of Check::Info into Profile and Group appeared to
cause a similar problem with SIGCHLD. That issue, and its mitigation,
are described here:
https://stackoverflow.com/a/60761593
A proper identification and a solution remain outstanding.
commit 26734cfa105fa9beba0804767f5693617ab20bb5
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 16 19:31:05 2020 -0800
Restore hyperlinks in GNOME terminals; fixes commit 990d920a.
Gbp-Dch: ignore
commit 54d842a95696a3c344fd6b14d0ac3eda3a1ea7d9
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 16 15:52:35 2020 -0800
Drop support for legacy 'desc' check descriptions.
We have not been aware of any users of this mechanism for at least a
year. Please contact us if you require help converting to the new
check format.
commit f6691259ea97c3dda4e547a2c74b2210e915b236
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 16 11:54:45 2020 -0800
Implement the perlcritic policy NamingConventions::Capitalization.
commit 03624482039aa89f33d94439c04d52da99e53fd4
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 16 08:40:44 2020 -0800
Capitalize module names for checks in camel case; drop underscores.
Lintian tried for a long time to make the module names for checks
similar to their names. It is not possible to make them the same.
(Module names may not contain hyphens; not sure about dots.) This
commit chooses an alternative naming scheme.
The new names are more in line with Perl customs. We introduce them
here in preparation to move the modules to their correct location in
our name space. Symbolic links will be provided as a convenience where
appropriate.
The move will prevent modules from being absent due to typos. It will
also help to ensure that all modules are loaded. Some of these
assertions did not appear possible without the perlcritic policy
Freenode::PackageMatchesFilename, which we hope to enable shortly.
Aside from the broader name tranlations, this commit currently
special-cases the dot in the check 'init.d' in two conversions from
camel case in which otherwise a hyphen would be inserted.
Together with the changes to follow, this may break pkg-js-tools and
pkg-perl-tools. The maintainers of those packages will be advised
separately, as has been our custom.
commit 1ec59cef43d34fa3785c876885940044b10fb87c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 16 07:04:44 2020 -0800
Add '::Check' to all Perl module names for checks.
A grouping for these modules in Perl's name space is a precursor to
ensure that the correct checks are being loaded, and that all checks
requested are also being run.
In addition, much of Perl's internal and external tooling works less
well with non-standard package names.
Together with the changes to follow, this may break pkg-js-tools and
pkg-perl-tools. The maintainers of those packages will be advised
separately, as has been our custom.
commit 4ce2b82e8ba67242a8916d0dd534b36e0e2b1dc5
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Dec 16 05:53:54 2020 -0800
Implement the perlcritic policy RegularExpressions::ProhibitUselessTopic.
commit ecd58648c63da3ec32ee9859bbe0ca9983de4439
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 15 17:52:19 2020 -0800
Implement the perlcritic policy ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions.
commit fe15e69524e27f100f1566b59321e4de4b1dbfd2
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Dec 15 13:32:03 2020 -0800
Implement the perlcritic policy Freenode::WhileDiamondDefaultAssignment.
commit 0fd439537df2a5773f4468505ff996b09134e5cd
Author: Xavier Guimard <yadd@debian.org>
Date: Mon Dec 14 22:38:33 2020 +0100
Verify that nodejs module does not use semantic-release
commit 5a0dff8c27e87da0a58072916a670ab446123f7e
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 13 18:36:58 2020 -0800
Provide data for Debian policy releases in JSON format.
For details, please see the commit preceeding this one.
commit 49226e6478ebde16e23c16641ceb86ffcc1247d1
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 13 18:22:33 2020 -0800
Integrate refresh capability from private/get-policy-release-dates into Data::Policy::Releases.
In the future, some data synchronization may take place autmatically
prior to each each Lintian release. Will ultimately allow for a
generalized data refresh pattern to address Bug#885438.
The new file provides more information about policy releases than
before. To sidestep encoding an other issues, the file is now in
JSON. The new location is ./data/debian-policy/releases.json.
The actual update (and switch) of the data files will happen in the
commit following this one, so the code changes are not obscured during
a casual perusal.
Renames private/get-policy-release-dates to refresh-policy-releases.
commit aa36cc7bccb8bf5d24eca09bb2a408f12601e202
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Sun Dec 13 19:49:13 2020 -0800
Simplify the interaction between profiles and data sources.
Gbp-Dch: ignore
lintian (2.104.0)
[PTS] [DDPO]