Git log: commit 7800c10dd68b839a9c264804a473b10f2bb14e3c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:30:20 2019 -0700
Adapt test scripts/scripts-maintainer-script-classification to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit ef5cc45480a1778bde2589ea03ee9f4a56b48aa1
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:29:45 2019 -0700
Adapt test scripts/scripts-does-not-start-with-shebang to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit d57798b8b560d6f43e4d18834fee0cea682d9f2f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:29:04 2019 -0700
Adapt test python/python-script-uses-unversioned-python-in-shebang to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 220cc64234e88d0e549bb06fb2968dc479c53bc1
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 23:27:53 2019 -0700
Adapt test md5sums/md5sums-traversal to new templating system
This test used to specify which checks to run, but that is now
incompatible unless the default Lintian command line options are
overridden. Turns off the manual selection.
The selection of three checks before was unusual. From now on, the
test suite will run only the declared check md5sums.
One tag disappeared as a result.
Gbp-Dch: ignore
commit 623e3f68948056eb184211566de02096ff125c90
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 23:28:26 2019 -0700
Adapt test lintian-features/lintian-display-level to new templating system.
Changes to the Lintian invocation are no longer made through the
special file 'lintian-command'. Templating values that use
substitutions themselves may now be used directly in 'desc'.
Gbp-Dch: ignore
commit 7bd6a74a74c4c87e19b41bf13ec9b0a5cc0fd612
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 08:03:56 2019 -0700
Adapt test lintian-features/lintian-check-tags-file to automatic check selection.
The Lintian option '--tags-from-file' used by this test conflicts with
the automatic test selection. Overrides the default Lintian command
line options. Turns off the automatic selection of Check: all.
Gbp-Dch: ignore
commit 983be9dd4830e98d0dc5fcf2226cf64347e9da15
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:28:33 2019 -0700
Adapt test files/files-package-contains-usr-unmerged-pathnames to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 554171061a6af154ef05c10d8d3e0e00af3eee08
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 23:27:00 2019 -0700
Adapt test files/contains-build-path to new templating system.
Changes to the build command are no longer made through the special
file 'builder'. Templating values that use substitutions themselves
may now be used directly in 'desc'.
Gbp-Dch: ignore
commit e1101595ca23478412aa9b660fe27711da213670
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:27:48 2019 -0700
Adapt test debian-source-dir/debian-source-dir-classifications to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit edb7bb03a86d243fec2f7b17dc2261f8d0b5b187
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:18:43 2019 -0700
Adapt test debhelper/debhelper-compat-virtual-relation to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 07e4084a43be49cca0f2684e9ea2d1b0ed7ed0b3
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:17:52 2019 -0700
Adapt test control-files/control-files-classifications-no-ctrl-scripts to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 2dc3e4b8759a7b148bfda99cc6ba07eb3a1862c4
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:16:24 2019 -0700
Adapt test control-files/control-files-classifications-ctrl-script to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce and error saying that -C may not be specified
twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 70467041d42eaf36478e42e8b6708233f138f63a
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:15:04 2019 -0700
Adapt test control-file/rules-requires-root-implicitly to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit a1ae024464f7dd29c948938cbaaafe0b63b2667d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 00:07:17 2019 -0700
Adapt test runner-features/runtests-options to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 9213750537509b2f174506239a0272b68bf2b9ae
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:03:29 2019 -0700
Adapt test control-files/md5sums-traversal to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 8a2cbf28d7b3976e9fa9cf478fa0d10091a070c8
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 07:02:39 2019 -0700
Adapt test control-files/control-files-traversal to automatic check selection.
The check is now selected automatically through the templates. The
manual selection is no longer necessary, and actually conflicts.
Lintian will produce an error saying that the option -C may not be
specified twice.
Removes the manual check selection.
Gbp-Dch: ignore
commit 75ffb5f7431a78a168c03ef2b8694792fa58e481
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 23:26:01 2019 -0700
Adapt test control-file/source-only-upload-to-non-free-without-autobuild to new templating system
Changes to the build command are no longer made through the special
file 'builder'. Templating values that use substitutions themselves
may now be used directly in 'desc'.
Gbp-Dch: ignore
commit ea2fac33c4c21d185430c48e387ad198cc0c1436
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Aug 20 22:30:07 2019 -0700
In tests, adjust expected tags for greater specificity; drop tags unrelated to check.
For tests that declare a check Lintian now runs only that check. That
reduces the set of expected tags to the tags issues by that particular
check. It makes the tests much more specific.
Removes all expected tags that are not related to the declared check.
The impact of this step is particularly noticable for the families of
tests that were duplicated as they were sorted into checks from the
previous test suite. Until now, that duplication had little value;
besides the ability to run only tests associated with a check, a
positive, the test suite just took longer to run.
With this commit, the expected tags for these families of tests began
to diverge severely. In fact, they no longer share any tags at all.
The most significant effect of this change, however, is running time.
In preliminary tests, the test suite is anywhere from 20% to 33%
faster than before.
Gbp-Dch: ignore
commit e69e68520d1b1757429b02303f0474e973664e8c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Aug 20 23:08:57 2019 -0700
Adjust internal harness test to automatic check selection and new default options.
In t/scripts/harness/logged_prepare.t, specify a Check. Also looks for
that value in the completed templating values.
Gbp-Dch: ignore
commit 9ce64812aaa65d7b3ebfabbc28fcbae4c311ee3d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 22:49:53 2019 -0700
Adjust template whitelist for absence of special files like 'builder' and 'lintian-command'.
The template whitelist only filled the special file 'lintian-command'.
The whitelist is no longer used. Deletes the whitelist.
Removes the special file 'builder' from the whitelist 'make-builder'.
The special file is no longer used.
Gbp-Dch: ignore
commit 9f93268a2ceac3c22e584ef70f1c906475d9e4bb
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 22:45:55 2019 -0700
Removes unecessary references to template whitelists from skeletons.
The whitelist 'lintian-invocation' attempted to fill the special file
'lintian-command', but that file is no longer used. Removes that
whitelist reference from all skeletons.
Similarly, the whitelist 'make-builder' was used to fill the special
file 'builder'. It is still needed to fill Makefile templates in all
template sets except 'changes-simple-fill', whieh uses no Makefile.
Removes the whitelist reference from that skeleton.
Gbp-Dch: ignore
commit 40594e73dd00147c645c61f87db070cf602bb315
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 15:55:31 2019 -0700
In templates, move previously special file 'lintian-invocation' to locations in ./fill-values.d.
The templating system no longer recognizes special files like
'lintian-invocation'. Instead, all files under fill-values.d are
filled and loaded into the list of substitution variables. It allows
templates to define their own substitution variables, which may
contain substitutions themselves.
Renames the file and moves it into the new location.
Also introduces a new substition value Lintian-Command-Line to avoid
circular behavior in fill-values.d.
Gbp-Dch: ignore
commit c424b392d99edaf00381f6a48ea4a79d20638c73
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Aug 20 23:07:37 2019 -0700
In templates, move previously special files 'builder' to locations in ./fill-values.d.
The templating system no longer recognizes special files like
'builder'. Instead, all files under fill-values.d are filled and
loaded into the list of substitution variables. It allows templates to
define their own substitution variables that contain substitutions
themselves.
Renames the files and moves them into their new locations.
Gbp-Dch: ignore
commit 9dabdb94b2cc8b3609de0fc2cc8638bab19b0da7
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 21 00:26:20 2019 -0700
In Test::Lintian::Run, use new Lintian command line options and recognize Check: all.
The old way of specifying Lintian's command line options lead to
recursive behavior in fill-values.d. Introduces a new variable,
Lintian-Command-Line, as a solution.
The location of the executable was not specified as part of that
command line. That way, the runner has the option to use either the
unpacked or the installed version of Lintian. This feature is not
currently used but could be handy if package templating and building
are separated from the test suite.
The runner looks up whether the Check in a test exists in Lintian.
Tells it not to complain about a value of 'all'.
Gbp-Dch: ignore
commit 1c771fc83617e8f3b775ddfd25269353c4d09647
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Aug 20 23:08:38 2019 -0700
In Test::Lintian::Prepare, implement new templating order; also fill substitutions in substitution variables.
This changes the order in which values are loaded into the test case
structure. That leads to a more intuitive order in which values
override one another.
Now fills all values in fill-values.d and loads those values into the
list of substition variables to be used in templates. This is now a
powerful system that is generic enough to be used by any template that
needs it.
At some point, it may be desirable to switch the templating engine to
Template::Toolkit. It may also be better to use their delimiter.
Gbp-Dch: ignore
commit 0af8a3d82d361e17d4a00e6fcba0a760580989f7
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 22 08:02:42 2019 -0700
As testing default, run only declared Check; speeds up tests and makes them more specific.
For tests that declare a check Lintian now runs only that check. That
reduces the set of expected tags to the tags issues by that particular
check. It makes the tests much more specific. The most significant
effect, however, is running time. In preliminary tests, the test
suite is anywhere from 20% to 33% faster than before.
Adds a default '--check-part' command line option to all invocations
of Lintian. Some tests that use tag selectors that conflict with that
option can and do override that value.
For Check:, adds a default value of 'all'. Lintian now accepts this
value. It was necessary to avoid scripting the option '--check-part'.
For Fill-Values-Folder:, sets default for directory that holds
additional substitution variables to be added to desc. Templates can
add variables that contain substitutions themselves. The files in this
folder replace 'builder' and 'lintian-invocation' from before. The
location of the folder can probably not be overridden because of the
way the files are loaded in Test::Lintian::Prepare.
The Sequence: value has not been used for some time and was already
removed from all individual tests. Also removes it from here.
commit 0132b88bb9e36b612dd2982c506b7a24f0230137
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Aug 20 23:06:27 2019 -0700
In Lintian, accept 'all' as a value for --check-part.
This changes avoid scripting the use of the option --check-part, which
is now used for almost all tests with a specific test.
For a small number of tests, this option is still used, but with
default value of 'all'. It made the design of the templating system
much easier.
This option still conflicts with other tag selection options even
though the value 'all' acts as if the option had not been specified at
all. It seemed more logical given the presence of the option.
Gbp-Dch: ignore
commit b61b7b2ab96035b374392336cdcc16c249bd2b40
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Tue Aug 20 22:32:08 2019 -0700
Add missing import to checks/rules.pm.
An error message appeared when each test associated with a check ran
only that check. That was presumably because another check imported
the module, and allowed this one to use it, but was no longer being
run.
Gbp-Dch: ignore
commit 71d551c1cb2bb59b4f3de06a0fa8aa7be5ffadd2
Author: Chris Lamb <lamby@debian.org>
Date: Wed Aug 21 16:11:37 2019 -0700
Correct a typo in the changelog; thanks Guillem Jover.
Gbp-Dch: ignore
commit 8c74ed54362d27e8adfdcc8c73de4ba7ad8e5322
Author: Chris Lamb <lamby@debian.org>
Date: Wed Aug 21 16:10:01 2019 -0700
Avoid package-does-not-use-debhelper-or-cdbs false-positives for packages using the pkg-kde-tools CDBS routines. (Closes: #933901)
commit 302ec1e279df170117326baa24f21c9b34dc90dc
Author: Chris Lamb <lamby@debian.org>
Date: Wed Aug 21 16:08:07 2019 -0700
Avoid a large number of false-positives for package-does-not-use-debhelper-or-cdbs by actually taking into account whether the package uses CDBS or not. (Closes: #933902, #933903)
commit 31ec5e030db527e55cb0d9b3e418c3f6cc81b17b
Author: Chris Lamb <lamby@debian.org>
Date: Wed Aug 21 16:04:54 2019 -0700
Ignore Python scripts that are shipped under /usr/lib/python3/dist-packages as these files aren't supposed to be called as scripts. (Closes: #933167)
commit c82bd0684fc4aa8f1d44c2dbba2c34bb9c17e390
Author: Chris Lamb <lamby@debian.org>
Date: Wed Aug 21 09:59:19 2019 -0700
Open new changelog entry.
Gbp-Dch: ignore
