pinentry (1.1.1-1)
[PTS] [DDPO]
UNREL: VCS matches the version in the archive, but the VCS changelog is UNRELEASED. The uploader should update the changelog and tag the release.
- Git: https://salsa.debian.org/debian/pinentry.git
-
- Branch: debian/sid
- Path: debian/changelog
- Browser: https://salsa.debian.org/debian/pinentry
- Last scan: 2021-09-27 06:58:50+00
- Next scan: 2021-10-03 04:50:00+00
- Debian changelog in Git:
pinentry (1.1.1-1) UNRELEASED; urgency=medium
* new upstream release 1.1.1
* dh 13 already does --fail-missing by default
* drop --as-needed linking flag, bullseye does this by default
* move to debian/sid branch for packaging
* update upstream signing keys
* drop patches already upstream
* standards-version: bump to 4.5.1 (no changes needed)
* refresh patches
* avoid rpath for pinentry-qt
* clean up use of pkg-config for EFL pinentry
* avoid trying to build pinentry-efl
-- Daniel Kahn Gillmor <dkg@fifthhorseman.net> Wed, 17 Feb 2021 15:43:06 -0500
- This branch is 60 commits ahead of tag debian/1.1.0-4
- Git log:
commit 335f6cde86d81270e09d5a8ba5c3687a37e2cc6f
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:10:02 2021 -0500
prep debian faux-release
commit 418abf87e1b0363870735129529a1317f56503d7
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 15:19:28 2021 -0500
avoid trying to build pinentry-efl
commit 1d50f00e70eed493770741069fe17988e1faecdd
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 15:11:58 2021 -0500
clean up use of pkg-config for EFL pinentry
commit ec6590d9d9106dd0b7e53ed54551deda275ff297
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:23:55 2021 -0500
avoid rpath for pinentry-qt
commit 6fec4decfbc50214c0c22de3ff0283fb0a90a9c8
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:23:05 2021 -0500
refresh patches
commit 1d63e8b764afa41033986970b3b003bcd2362e17
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:15:03 2021 -0500
standards-version: bump to 4.5.1 (no changes needed)
commit 0f3c883341a2daeec783ec68844866b11d9e89ac
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:12:33 2021 -0500
drop patches already upstream
commit b2d29644c60e30eeaa6d9136a08dfd40aeb50d42
Merge: a7ac957 4174f86
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:09:26 2021 -0500
Update upstream source from tag 'upstream/1.1.1'
Update to upstream version '1.1.1'
with Debian dir 7323a94f6fa6ba48db5b8bd74d01bb6565f32651
commit 4174f8694fcc57faf806bf1f60a1716b55a7518e
Merge: 217eeae c6202b2
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:09:25 2021 -0500
New upstream version 1.1.1
commit a7ac9572a7adb684e6f6a8273de3b6b8b5820948
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 14:07:09 2021 -0500
update upstream signing keys
This is pretty messy. both Werner and Damien Goutte-Gattat are
potential upstream authors.
Werner changed OpenPGP certificates recently, and Damien's default
certificate is kind of a mess -- lots of subkeys (that we don't care
about because they're not signature-capable) and some expired/revoked
user IDs that are not filtered out by gpg's "export-minimal".
The new list of signing keys was generated with:
gpg --armor --export-options export-minimal,no-export-attributes --export-filter 'drop-subkey=usage!~s' --export-filter 'keep-uid=mbox=~incenp.org || mbox =~ fsfe.org || uid=~Werner' --export 6DAA6E64A76D2840571B4902528897B826403ADA 80CC1B8D04C262DDFEE1980C6F7F0F91D138FC7B > debian/upstream/signing-key.asc
commit b4e26024a62dfb59f9df2a1a692fe3cd9064cc83
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Feb 17 13:53:01 2021 -0500
move to debian/sid branch for packaging
commit c6202b29cf60454d2560debea0371818f26c3f07
Author: Damien Goutte-Gattat <dgouttegattat@incenp.org>
Date: Thu Jan 21 21:56:06 2021 +0000
Release 1.1.1.
--
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit b3e83681119e74a7a084310cd1ab14170cb549d5
Author: Damien Goutte-Gattat <dgouttegattat@incenp.org>
Date: Mon Jan 18 21:57:35 2021 +0000
build: Fix make dist with newer Automake.
* qt/Makefile.am: Make sure .moc files are only built if needed.
* tqt/Makefile.am: Likewise.
--
With Automake 1.16 and newer, source files listed in BUILT_SOURCES
are unconditionally built upon calling `make dist`, even if those
files are also listed in a `nodist_*_SOURCES` variable.
This causes an issue with the Qt pinentry: if pinentry-qt has not
been configured (either because Qt was not found or because the user
explicitly disabled it), `make dist` will nonetheless attempt to
build the .moc files, which will fail due to the `MOC` variable
being undefined in the generated Makefile. Likewise for the TQt
pinentry.
As a result, `make dist` will fail on any machine where Qt and TQt
are absent.
The workaround is to declare the .moc files in the BUILT_SOURCES
variable only if we are actually building the corresponding Qt or
TQt pinentry.
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit de1829f81f31df37912198dda4a0c31c75a79c01
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Mon Dec 21 14:02:08 2020 +0900
gtk+-2: Avoid use of deprecated API.
* gtk+-2/pinentry-gtk-2.c (create_window): Use
gtk_widget_set_can_default.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 52c78386fd54a476a389960bbfc690f90c542b73
Merge: 749529c 5c83f63
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri Nov 20 13:28:00 2020 +0100
Merge branch 'master' of git://git.gnupg.org/pinentry
commit 749529cac2b050586518d8de145a55901d6158cd
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri Nov 20 13:27:23 2020 +0100
qt: Disable generate button for now
* qt/pinentrydialog.cpp: Disable generate until we make it
prettier.
commit 5c83f6314e3fe6cb78d92e353263ac519821c927
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Wed Nov 18 14:42:51 2020 +0900
build: Update to newer autoconf constructs.
* configure.ac: Use AC_USE_SYSTEM_EXTENSIONS instead of AC_GNU_SOURCE.
Use AS_HELP_STRING instead of AC_HELP_STRING.
* m4/gpg-error.m4: Update from libgpg-error.
* m4/libassuan.m4: Update from libassuan.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit a421ae8c4d2a0ce182e099e634e49ccdad454627
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri Nov 6 16:01:41 2020 +0100
qt: Improve focus and frontness
* qt/pinentrydialog.cpp (raiseWindow): Use QtWindowsWindowFunctions
to get a more agressive bring to frontness.
(PinEntryDialog::PinEntryDialog): Start minimized.
--
Weirdly enough this works much better then the old code because
we now start minimized and then bring us to front when the
event loop is fully listening. This way we have the
allowsetforegroundwindow right because we are restored from
minimized state. This helps even in cases where
the QtWindowsWindow Behaviror did not activate the window
besides the requested behavior change.
GnuPG-Bug-Id: T4123
commit cd2e69bfcf2630d7a61c4499b49c21790a1821d1
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri Nov 6 15:10:49 2020 +0100
qt: Fix crash when generate icon was not found
* qt/pinentrydialog.cpp (PinEntryDialog::setGenpinLabel)
(PinEntryDialog::setGenpinTT): Check for NULL.
--
We don't have an action in that case.
commit e4f1681550b1c42c062bc0e209947f13351cf02c
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri Nov 6 14:46:52 2020 +0100
qt: Silence deprecation warning
* qt/pinentrydialog.cpp (PinEntryDialog::setDescription): QString::null
is deprecated.
commit 340e3ef6f4fc1136bc38691745aeb651cbf263a1
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri Nov 6 14:13:08 2020 +0100
qt: Add genpin suppport
* pinentry/pinentry.c (pinentry_inq_genpin): New. Based on
inq_quality.
(cmd_setgenpin_tt, cmd_setgenpin_label): New string helpers.
(register_commands): Register stringhelper commands.
* pinentry/pinentry.h (struct pinentry): Add new variables for
label and tooltips.
* qt/main.cpp (qt_cmd_handler): Set up labels.
* qt/pinentrydialog.cpp (PinEntryDialog::PinEntryDialog): Add
generate action if label is provided.
(PinEntryDialog::setGenpinLabel): New.
(PinEntryDialog::setGenpinTT): New.
(PinEntryDialog::textChanged): Hide generate action if text
is entered.
(PinEntryDialog::generatePin): Inquire generate.
(PinEntryDialog::toggleVisibility): Allow calls from other
senders.
--
This adds some basic support to have gpg-agent generate a
passphrase. This helps espcially in the symmetric encryption
use case. It could be nicer of course how we present the
generated pin regarding printing etc but it is better then nothing.
It also gives us future options to improve the GENPIN
in the gpg-agent without changes to pinentry.
commit 2076ac61d218286e11ce9e6f9ce2af1e28f32c31
Author: Werner Koch <wk@gnupg.org>
Date: Mon Oct 26 14:32:45 2020 +0100
doc: Minor typo fix in example
--
commit 174c46d865e14e5b6f6c0f7b3efaa201210fb166
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Fri May 8 13:20:05 2020 -0400
drop --as-needed linking flag, bullseye does this by default
commit e37cbf39fbbddec1d9f1c20fdcb8f55c613a1f6e
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Fri May 8 13:18:26 2020 -0400
dh 13 already does --fail-missing by default
commit ae584040d14a4d7d6eed8be77844126130ef0118
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Fri May 8 12:03:24 2020 +0200
curses: Fix build with ncurses 6.2
* pinentry/pinentry-curses.c (curses_cmd_handler): Use
renamed variable.
* pinentry/pinentry.c (pinentry_reset, pinentry_parse_opts)
(option_handler, cmd_getinfo) Use renamed variable.
* pinentry/pinentry.h (struct pinentry): Rename ttytype to
ttytype_l.
--
This fixes the build with ncurses 6.2 which defines ttytpe
as a preprocessor variable.
To avoid problems with that we don't use that name as a
variable anymore.
GnuPG-Bug-Id: T4927
commit 971d1365ab16279bb33312583c320008e391f26e
Author: David Faure <faure@kde.org>
Date: Sat Dec 21 21:04:35 2019 +0100
qt: Add rpath so the Qt libs are found at runtime
* configure.ac: Add PINENTRY_QT_LDFLAGS variable.
* m4/qt.m4: Check qt libdir and add it to LDFLAGS.
* qt/Makefile.am: Use PINENTRY_QT_LDFLAGS.
--
This is necessary when Qt is installed into a custom prefix.
commit 099b79fc2d6638598b94161e1162a55af8a95531
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Thu Dec 5 09:46:29 2019 +0900
build: Require newer GTK+2 (>= 2.12.0).
* configure.ac: Check gtk+-2.0 >= 2.12.0.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit edbd0d61b35fe7408cb879c0bd81daf42accb5ed
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Thu Dec 5 09:41:09 2019 +0900
gtk: Remove support of old GTK+2 (< 2.12.0).
* gtk+-2/pinentry-gtk-2.c (tooltips): Remove
(create_window): Remove use of tooltips, but use
gtk_widget_set_tooltip_text.
--
The commit 1590b664d88be8386a4664c2994b685187d1eb25 requires newer
GTK+.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 02a4f2fa0d8c8a63e72b9b9924b2817bfacce09a
Author: Werner Koch <wk@gnupg.org>
Date: Thu Nov 14 10:40:49 2019 +0100
core: Allow to query info about the emacn integration.
* pinentry/pinentry-emacs.c (pinentry_emacs_status): New.
* pinentry/pinentry.c (cmd_getinfo): Add emacs info getinfo.
--
With this patch the pinentry launched info of gpg coveys an additional
item. For example:
gpg: pinentry launched (2850 gtk2 1.1.1-beta29 \
/dev/pts/42 xterm localhost:10.0 20620/1000/5 1450/2450 -)
The last item "-" is new with the follwing meaning:
- = No support for emacs at all in pinentry
(configure --disable-inside-emacns)
0 = INSIDE_EMACS envvar not set, allow-emacs-pinentry not
in gpg-agent.conf, or emacs pinentry server not started.
1 = Prepared for connecting to Emacs but may fallback to
standard pinentry on connection failure
2 = Connection to Emacs pinnetry server has been established.
Signed-off-by: Werner Koch <wk@gnupg.org>
commit 248e1e79231f7346a2273a5169890e568a877455
Author: Werner Koch <wk@gnupg.org>
Date: Thu Nov 14 10:30:51 2019 +0100
gtk: Fix compiler warning.
--
commit f4b896ab75ba6536e78c56d377ad5ab6ff69b944
Author: Werner Koch <wk@gnupg.org>
Date: Thu Nov 14 10:30:33 2019 +0100
emacs: Handle options before trying to conenct to emacs.
* emacs/pinentry-emacs.c (main): Parse options first.
Signed-off-by: Werner Koch <wk@gnupg.org>
commit 0e2e53c8987d6f236aaef515eb005e8e86397fbc
Author: Andre Heinecke <aheinecke@gnupg.org>
Date: Thu Jul 25 14:20:51 2019 +0200
qt: Fix use of dangling pointer in QApplication
* qt/main.cpp (main): Use a new variable for argc that stays
valid.
--
The QApplication constructor takes argc as a reference and the referenced
integer has to stay alive for at least as long as the QApplication.
GnuPG-Bug-Id: T4658
Based on a Patch from: Fabian Vogt <fvogt@suse.com>
Thanks!
commit dad35d65f05eb1c15589a7e4755dcae6aed2d6cf
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Wed Jul 10 09:13:18 2019 +0900
curses: Fix more.
* pinentry/pinentry-curses.c (dialog_create): Reverting was not
enough. Correctly check with the character at len - 1.
GnuPG-bug-id: 4598
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit a03f3920714830b1f09b48f41be5a0aa8177f11a
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Tue Jul 9 16:23:48 2019 +0900
curses: Fix handling of newline in description.
* pinentry/pinentry-curses.c (collect_line): LEN including the
newline/null character.
(dialog_create): Fix the caluculation.
GnuPG-bug-id: 4598
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 67a7cfa12d1525097d9822124c9bd05207204a60
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Tue Jul 9 16:07:52 2019 +0900
curses: Fix width calculation.
* pinentry/pinentry-curses.c (collect_line): Fix caluculation
where skipping the first character and adding 1 column.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 9298cca67742df946efb9ba268a04904339454f1
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Tue Jul 9 14:20:06 2019 +0900
curses: Fix calculation of columns for CJK text.
* pinentry/pinentry-curses.c (STRWIDTH): New.
(collect_line): Let return value for columns width.
LEN minus one.
(dialog_create): Calculate for the columns with STRWIDTH.
GnuPG-bug-id: 4598
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit f6e84ce0a34c5314999ac9af2f1d360c157b1ed5
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Thu Jun 27 16:43:37 2019 +0900
tty: Confirmation is not by line edit mode.
* tty/pinentry-tty.c (terminal_setup): Support single char mode.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 531b92300c58aee665b55d1dffa7ffb4027cba20
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Thu Jun 27 15:55:05 2019 +0900
tty: Support line editing by system.
* tty/pinentry-tty.c (terminal_setup): Not cbreak, but only no echo.
(confirm, read_password): Don't do editing here.
[HAVE_DOSISH_SYSTEM] (confirm, read_password): Return
GPG_ERR_FULLY_CANCELED when EINTR and it's not timed out.
(tty_cmd_handler): Call sigaction for SIGINT.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit b176a8ac0dcd682549084cbf02876a550226d722
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Thu Jun 27 15:54:09 2019 +0900
Exit the loop on an error with GPG_ERR_FULLY_CANCELED.
* pinentry/pinentry.c (cmd_getpin, cmd_confirm): Set
ASSUAN_FORCE_CLOSE flag when GPG_ERR_FULLY_CANCELED.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 89add7b733138d7fe86d348be57873936cab3112
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Thu Jun 27 15:33:45 2019 +0900
tty: Factor out terminal setup into tty_cmd_handler.
* tty/pinentry-tty.c (terminal_save, terminal_restore): New.
(terminal_setup): Rename from cbreak.
(confirm, read_password): Don't touch terminal setting here.
(tty_cmd_handler): Do terminal setting/restore here.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 95743b2cd7361aab10c5eb4f430928d09ce9c214
Author: Ineiev <ineiev@gnu.org>
Date: Fri Apr 8 15:29:08 2016 +0300
tty: Show supplied message when using default
* tty/pinentry-tty.c (fputs_highlighted): New function.
(button): Display the supplied text when falling back to default; the
default text is shown in braces and provides the accelerator.
--
This allows using button texts written with non-ASCII characters.
Signed-off-by: Ineiev <ineiev@gnu.org>
commit 42c32e08d5a428627e5f74e0ab2bf4102e511b40
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Mon May 13 15:19:00 2019 +0900
build: Update m4/iconv.m4.
* m4/iconv.m4: Update from gettext 0.20.1.
--
This includes fixes of file descriptor leaks.
GnuPG-bug-id: 4504
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit f74c4673e6b60508012c14f7574dbc3215345210
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed Apr 17 14:23:18 2019 -0400
gnome3: correctly detect when no GNOME screenlock exists
* gnome3/pinentry-gnome3.c (pe_gnome_screen_locked): skip
G_IO_ERROR_IS_DIRECTORY responses, not G_IO_ERROR_TIMED_OUT responses
from dbus.
--
After the previous commit, testing demonstrates that the normal
response when no screenlock is running is G_IO_ERROR_IS_DIRECTORY, not
G_IO_ERROR_TIMED_OUT.
Debian-bug-id: 927105
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
commit 65d2c6d5911ab04b19f953153d01116198cc4cb8
Author: Zephaniah E. Loss-Cutler-Hull <zephaniah@gmail.com>
Date: Wed Apr 17 14:08:48 2019 -0400
gnome3: Use the default dbus timeout when checking for screenlock
* gnome3/pinentry-gnome3.c (pe_gnome_screen_locked): use default dbus
timeout instead of 0ms.
--
At the moment, every single check to see if the screen is locked fails
immediately with a timeout, which is then silently ignored.
This is happening because the definition of the timeout argument is a
millisecond count, with -1 as the (unspecified) default, and G_MAXINT for no
timeout.
This means 0 times out immediately, and that leads to a complete inability for
pinentry-gnome3 to fallback to curses input when the screen is locked.
(Which then prevents a remote session from ever asking for a PIN, even when
the local session is locked.)
Debian-bug-id: 927105
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
commit 6ddcc92cf6e9a904a5c98982709edeb42034843d
Author: NIIBE Yutaka <gniibe@fsij.org>
Date: Mon Mar 4 16:17:46 2019 +0900
Update gpg-error.m4 and libassuan.m4 from corresponding repos.
* m4/gpg-error.m4: Update.
* m4/libassuan.m4: Update.
--
GnuPG-bug-id: 3949
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
commit 8f8d907f53b2749642ee273e2cec28f7d68f26ff
Author: Damien Goutte-Gattat <dgouttegattat@incenp.org>
Date: Tue Nov 20 12:48:43 2018 +0000
build: Add --disable-doc option.
* configure.ac (BUILD_DOC): Add new am_conditional.
* Makefile.am: Skip doc subdir if BUILD_DOC is not set.
GnuPG-bug-id: 4263
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>.
commit 21f0883059c84de7145d402877cd178fcfed44e3
Author: Damien Goutte-Gattat <dgouttegattat@incenp.org>
Date: Thu Feb 7 23:03:03 2019 +0000
fltk: Handle '_' in button labels as keyboard shortcuts.
* fltk/main.cxx (convert_accel_utf8): New method.
(fltk_cmd_handler): Calls previous method to escape button labels.
GnuPG-bug-id: 4336
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
Co-authored-by: Michael Bäuerle
commit a60e4f8142159b3e2df10d8d725b9680be5b4616
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Thu Feb 7 23:11:19 2019 +0000
fltk: Fix formatting escapes.
* fltk/main.cxx (fltk_cmd_handler): Fix calls to fl_message()
and fl_choice() functions.
--
The fl_message and fl_choice functions expect a format string as
their first argument; passing the message directly might cause a
crash (or worse) if the message happens to contain formatting
escape chars.
GnuPG-bug-id: 4337
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit d0eaec8ef60be9b4d1aa5993c11d261a35202a2e
Author: Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>
Date: Tue Aug 21 20:31:53 2018 +0100
Disallow echo disabling when prompting for a PIN.
* gtk+-2/pinentry-gtk-2.c (create_window): Do not setup
the backspace handler when prompting for a PIN.
callback only when not prompting for a PIN.
* qt/pinentrydialog.h (_got_input): Rename field to
_disable_echo_allowed.
* qt/pinentrydialog.cpp (PinEntryDialog::setPrompt): Disallow
echo disabling when prompting for a PIN.
* tqt/pinentrydialog.h (_got_input): Rename field to
_disable_echo_allowed.
* tqt/pinentrydialog.cpp (PinEntryDialog::setPrompt): Disallow
echo disabling when prompting for a PIN.
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit 0fb3392f61569cb93e52c81465bc8e4636bca3b7
Author: Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>
Date: Sat Aug 4 22:24:11 2018 +0100
tqt: Disable echoing if backspace is pressed first.
* tqt/secqlineedit.h (backspacePressed): New signal.
* tqt/secqinternal.cpp (SecTQLineEdit::backspace): Emit new signal.
* tqt/pinentrydialog.h (_got_input): New member field.
(onBackspace): New slot.
* tqt/pinentrydialog.cpp (onBackspace): New slot.
(PinEntryDialog::updateQuality): Prevent echo disabling as soon as
the text has been edited.
GnuPG-bug-id: 3428
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit a75786a11666a080cae67f6e386163fcf93ff233
Author: Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>
Date: Sat Aug 4 22:24:10 2018 +0100
qt: Disable echoing if backspace is pressed first.
* qt/pinlineedit.h: New file.
* qt/pinlineedit.cpp: New file.
* qt/Makefile.am: Add new source files.
* qt/pinentrydialog.cpp (PinEntryDialog): New member _got_input;
Type of _edit member changed to PinLineEdit.
(PinEntryDialog::onBackspace): New slot.
GnuPG-bug-id: 3428
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit 4b06bc6009011a84e5e8d4da2f01659f35e5a2d5
Author: Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>
Date: Sat Aug 4 22:24:09 2018 +0100
gtk: Disable echoing if backspace is pressed first.
* gtk+-2/pinentry-gtk-2.c (backspace_handler): New callback.
(create_window): Attach previous callback to "backspace" signal.
GnuPG-bug-id: 3428
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit fd22facabd784586f72eeecc72830620a534929c
Author: Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>
Date: Sat Aug 4 22:24:08 2018 +0100
curses: Disable echoing if backspace is pressed first.
* pinentry/pinentry-curses.c (struct dialog): New fields got_input,
no_echo.
(dialog_input): Disable echoing and display instead "[no echo]" if
the backspace key is pressed first.
GnuPG-bug-id: 3428
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit 779b8e6df7d2678d40bc61ba9e9ff35324a40d03
Author: Werner Koch <wk@gnupg.org>
Date: Wed Jun 13 16:10:53 2018 +0200
core: Add info about tty mode etc to 'getinfo ttyinfo'
* configure.ac: Check for 'stat'.
* pinentry/pinentry.c: Include types.h and stat.h.
(device_stat_string): New.
(cmd_getinfo): Print more info.
Signed-off-by: Werner Koch <wk@gnupg.org>
commit 948105b7a34ec9a9e5479d376b7c86bafee50a01
Author: William L. Thomson Jr <wlt@o-sinc.com>
Date: Tue May 29 22:50:47 2018 +0100
efl: Add an EFL-based pinentry.
* NEWS: Update.
* Makefile.am: Add new efl subdirectory.
* configure.ac: Add --enable-pinentry-efl option.
* efl/Makefile.am: New file.
* efl/pinentry-efl.c: New file.
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
commit fa817f00363cdc305728ece6139d76361c77f361
Author: Andre Heinecke <aheinecke@intevation.de>
Date: Mon Mar 5 12:16:44 2018 +0100
qt: Try again to fix Windows Window Management
* qt/pinentrydialog.cpp (raiseWindow): Activate Window and
disable windows hacks.
(PinEntryDialog::PinEntryDialog): Delay setFocus after the
event loop returns.
--
This fixes getting the input focus on Windows without the
Buggy AttachThreadInput hacks.
commit 141fd941a58f70692cb6244f011e54b005d2195c
Author: Andre Heinecke <aheinecke@intevation.de>
Date: Thu Mar 1 16:12:28 2018 +0100
qt: Renable Windows Foreground Window hacks
* qt/main.cpp, qt/pinentryconfirm.cpp: Use raiseWindow again.
* qt/pinentrydialog.cpp: Renable Foreground Window hacks.
--
Enabled this again because the focus did
not change to the pinentry window without the attach
thread input stuff. The setup_foreground_window helps though,
so that stays. Either Qt Windows foreign Window Management
is a mess and does not really work or I don't understand it.
commit 84d473f5c323a3001374b0db736af9be4e3478a3
Author: Andre Heinecke <aheinecke@intevation.de>
Date: Wed Feb 28 12:05:02 2018 +0100
qt: Clean up foreground window code
* qt/main.cpp (ForeignWidget): Remove. This did nothing
with Qt 5.
(setup_foreground_window): New helper to set parent and
window flags.
(qt_cmd_handler): Use setup_foreground_window.
* qt/pinentrydialog.cpp: Disable Windows API hacks.
--
This should hopefully work a bit cleaner then the old code.
Setting us as transient to the Desktop is the same what
Gtk 2 does.
commit 822c66815b5072281563fc4faa055493d20d660d
Author: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Mon Feb 5 20:43:32 2018 -0500
tqt: use UTF-8 instead of ISO-8859-1
commit 0499975e76752601cbab4eb06ebf3303ddaad30c
Author: Werner Koch <wk@gnupg.org>
Date: Sun Dec 3 18:56:30 2017 +0100
Post release updates
--
