Git log: commit ee97bb2ed99bbbc444c79c14b346d6409710deb3
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Sun Jun 9 11:01:55 2019 +0200
debian/rules - avoid manual building of manpage - done by upstream now - run tests using installed under debian/tmp version of vw
commit 5bb34e14f7009e4c70714f2df8a32afcb79dbd88
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Sun Jun 9 11:00:37 2019 +0200
debian/patches - deb_system_rapidjson to avoid rapidjson submodule installation
commit 2753ab439e53b16af16863c70ec97b0b41a1a187
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Sat Jun 8 17:27:38 2019 +0200
changelog and refreshed patch
commit 70e7ec385384b2741e000911d6276d8696cafae3
Merge: df6c6c6b 2baf726d
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Sat Jun 8 17:17:10 2019 +0200
Merge branch 'dfsg' into debian
* dfsg: (354 commits)
Update version to 8.7.0 (#1926)
Fix misconfiguration (#1925)
Ataymano ataymano/warnings fixes (#1924)
Update new version script (#1922)
Run clang-format over codebase (#1921)
change semantics of lambda (#1920)
Bremen79 fix save ftrl (#1919)
fix for daemon race condition (#1918)
Revert "Fix to save the state of FTRL models (#1912)" (#1916)
fix static library build (#1913)
more warnings (#1915)
Fix to save the state of FTRL models (#1912)
remove warnings (#1911)
fix closing invalid file descriptor with memory_io_buf (#1910)
Optional exception (#1906)
Contextual Memory Tree (#1799)
Coin betting (#1903)
Ataymano/c wrapper fix2 (#1859)
Use Appveyor MSBuildLogger (#1904)
fix for no label confidence (#1901)
...
commit 2baf726d1ae172a9fb1b8216a69a94551875c2c2
Merge: e787742f fc384e83
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Sat Jun 8 17:15:51 2019 +0200
Merge branch 'releases' into dfsg
* releases: (354 commits)
Update version to 8.7.0 (#1926)
Fix misconfiguration (#1925)
Ataymano ataymano/warnings fixes (#1924)
Update new version script (#1922)
Run clang-format over codebase (#1921)
change semantics of lambda (#1920)
Bremen79 fix save ftrl (#1919)
fix for daemon race condition (#1918)
Revert "Fix to save the state of FTRL models (#1912)" (#1916)
fix static library build (#1913)
more warnings (#1915)
Fix to save the state of FTRL models (#1912)
remove warnings (#1911)
fix closing invalid file descriptor with memory_io_buf (#1910)
Optional exception (#1906)
Contextual Memory Tree (#1799)
Coin betting (#1903)
Ataymano/c wrapper fix2 (#1859)
Use Appveyor MSBuildLogger (#1904)
fix for no label confidence (#1901)
...
commit fc384e83330d8966c70968471933d1f70ddcfaf5
Merge: 5dbf76b0 e63abfb6
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Sat Jun 8 17:13:54 2019 +0200
Merge tag '8.7.0' into releases
* tag '8.7.0': (354 commits)
Update version to 8.7.0 (#1926)
Fix misconfiguration (#1925)
Ataymano ataymano/warnings fixes (#1924)
Update new version script (#1922)
Run clang-format over codebase (#1921)
change semantics of lambda (#1920)
Bremen79 fix save ftrl (#1919)
fix for daemon race condition (#1918)
Revert "Fix to save the state of FTRL models (#1912)" (#1916)
fix static library build (#1913)
more warnings (#1915)
Fix to save the state of FTRL models (#1912)
remove warnings (#1911)
fix closing invalid file descriptor with memory_io_buf (#1910)
Optional exception (#1906)
Contextual Memory Tree (#1799)
Coin betting (#1903)
Ataymano/c wrapper fix2 (#1859)
Use Appveyor MSBuildLogger (#1904)
fix for no label confidence (#1901)
...
commit e63abfb6d76d8df9060ecd932dbb3d81216fe338
Author: John <jl@hunch.net>
Date: Thu Jun 6 22:58:48 2019 -0400
Update version to 8.7.0 (#1926)
* change semantics of lambda
* Fix style with clang-format (before releasing 8.7.0)
* Update verson.txt for release 8.7.0
* Revert "Fix style with clang-format (before releasing 8.7.0)"
This reverts commit 22ad6283267e4173ab28783d47f915e245d3a03a.
commit 17217045e88cbeced850f4e8805021d38a93a4ce
Author: John <jl@hunch.net>
Date: Thu Jun 6 21:49:11 2019 -0400
Fix misconfiguration (#1925)
* change semantics of lambda
* force correct mtr
commit e9f6b18cef10ccd830b19d8be9bc40872658ec1d
Author: John <jl@hunch.net>
Date: Thu Jun 6 17:48:45 2019 -0400
Ataymano ataymano/warnings fixes (#1924)
* change semantics of lambda
* namespace hash type fix
* leaf id type fix
* re-fixing hash types
commit b0273d08598474465e1c195c3a21b47dfdc0dd84
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Thu Jun 6 16:46:44 2019 -0400
Update new version script (#1922)
commit 312a699851c6750c3dfa6cd588ffa25f83537c7f
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Thu Jun 6 15:47:07 2019 -0400
Run clang-format over codebase (#1921)
commit 170bba585b012db74e7e6949692141bade933c9e
Author: John <jl@hunch.net>
Date: Thu Jun 6 09:53:13 2019 -0400
change semantics of lambda (#1920)
commit cb3019b8176180e5a4c32633ca9763a3eb563e16
Author: John <jl@hunch.net>
Date: Thu Jun 6 08:55:16 2019 -0400
Bremen79 fix save ftrl (#1919)
From @bremen79
* first version of the KT algorithm
* changed from 'kt' to 'approximate cocob' and implemented normalization by average lenght of the feature vectors
* variant that works with squared loss
* fixed all bugs: works great in binary classification, slightly worse than default one in ooa and cbify
* cleaned version, no bias used
* bias and fix bug
* another bug fix
* removed bias and added default params for logistic
* prediction is now stateless
* added comments
* added tests
* fix to ftrl state saving
* moved ftrl_size to a parameter of save_load_online_state
* fixed all the bugs related to resume models
* removed comments
* remove dependence on global
commit 47be22d8ec20779c5335dd6aed33e766870c45cd
Author: John <jl@hunch.net>
Date: Wed Jun 5 22:54:25 2019 -0400
fix for daemon race condition (#1918)
commit 2cbe61b26a0ad0b563f217dacc0fbddc9a3967fc
Author: John <jl@hunch.net>
Date: Wed Jun 5 20:13:52 2019 -0400
Revert "Fix to save the state of FTRL models (#1912)" (#1916)
This reverts commit 538e9bbbccc15eccbe72ad46e608fd08b4bb1f43.
commit 71627e713b964efb9f332b56f2d6d3703f8e3bb0
Author: Jamie Markle <jrmarkle@users.noreply.github.com>
Date: Wed Jun 5 19:43:02 2019 -0400
fix static library build (#1913)
commit beeb74816fd7c964c3d6937c920457a9cb5569e7
Author: John <jl@hunch.net>
Date: Wed Jun 5 18:59:41 2019 -0400
more warnings (#1915)
* more warnings
* fix build error
commit 538e9bbbccc15eccbe72ad46e608fd08b4bb1f43
Author: Francesco Orabona <bremen79@gmail.com>
Date: Wed Jun 5 18:06:16 2019 -0400
Fix to save the state of FTRL models (#1912)
* first version of the KT algorithm
* changed from 'kt' to 'approximate cocob' and implemented normalization by average lenght of the feature vectors
* variant that works with squared loss
* fixed all bugs: works great in binary classification, slightly worse than default one in ooa and cbify
* cleaned version, no bias used
* bias and fix bug
* another bug fix
* removed bias and added default params for logistic
* prediction is now stateless
* added comments
* added tests
* fix to ftrl state saving
* moved ftrl_size to a parameter of save_load_online_state
commit 61aafc8e2df52fb1730c5e05887e04d2c1982678
Author: John <jl@hunch.net>
Date: Wed Jun 5 17:22:49 2019 -0400
remove warnings (#1911)
* remove warnings
* fix warnings and undefined parse_mask
* fix various warnings
* fix more issues
* update tests to reflect change to boolean switch
* fix warnings
* more warnings
commit 3ca448ccfb4b8d00cff8abdf554f13549b6c4629
Author: Jamie Markle <jrmarkle@users.noreply.github.com>
Date: Wed Jun 5 12:51:42 2019 -0400
fix closing invalid file descriptor with memory_io_buf (#1910)
commit c9be7015dac81245d0c18a77c56ea60d50e4eddc
Author: John <jl@hunch.net>
Date: Wed Jun 5 11:05:07 2019 -0400
Optional exception (#1906)
* Add strict_parse flag
* Thread new flag value through parser initialization
* Call THROW in parserWarning if strict_parse set
* Add dataset that exercises malformed example branch
* Throw non-VW exception; vw_exception exits are graceful?
* Add exception_ptr to parser and use to rethrow
* Add unit tests
- negative test for single-threaded mode
- negative test for regular mode
- positive test for regular mode
The two negative tests are to make sure that any parser threading
still interacts with exception_ptr correctly
* Create and use a negative-test.sh wrapper script
* Daemon test flake?
* C# test flake?
* Try adding negative-test.sh tests to Windows blacklist
* Add strict_parse_exception and use in place of domain_error
* fixup! Try adding negative-test.sh tests to Windows blacklist
* disable test case in windows
* fix nonwindows tests
* Update to vw_exception (#1907)
* Change to vw_exception and bubble up
* fix negate, change file to just name, put back rethrow
* undo change
* Fix negation (#1909)
commit a4475d5bfa4d2e69f0e07b242a30bcb2fe94efb3
Author: Wen Sun <wensun@andrew.cmu.edu>
Date: Wed Jun 5 07:22:43 2019 -0700
Contextual Memory Tree (#1799)
* setup with the latest vw; online and offline aloi results can be reproduced here
* wiki online script
* wiki offline few shots script
* readme
* .
* .
* scripts updated
* seperated multilabel and multiclass
* updated xml part
* .
* multilabel classification scripts
* fixed loaded bug in multilabel setting
* a fix of nan prediction: initialized the ec.l.simple
* update readme
* scripts added to demo
* updates on scripts
* fixed some comments
* remove the unique feature function and added sort feature to wikipara scripts
* sort namespace indices and then walk through two sorted indices to avoid double for loop
* avoided double loop in computing hamming loss
* random seed, name changed on descent and insert example rew
* add memory tree cc in cmakelist
* got rid of write it define in memory tree file, putted it in io buf header
* allocated a space in memory tree for designing kprod example, and free it at the end of the learning
* Update vowpalwabbit/memory_tree.cc
for windows build
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update vowpalwabbit/memory_tree.cc
for windows build
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update vowpalwabbit/memory_tree.cc
for windows build
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update vowpalwabbit/memory_tree.cc
for windows build
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* typo
* Update vowpalwabbit/memory_tree.cc
supply default value in option memory_tree
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update vowpalwabbit/memory_tree.cc
fix off-by-epsilon issue in windows unit tests
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update vowpalwabbit/memory_tree.cc
alpha lower case
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* lower case alpha in demo scripts
* added two tests (online and offline) for cmt
* Update test/RunTests
extra line
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update test/RunTests
stderr
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update test/RunTests
stderr
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update test/RunTests
test upper case
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update test/RunTests
test upper case
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* staged stderr files in train set ref folder and deleted time output in memory_tree.cc
* decrease problem (smaller rcv1) and solution size (bit 15)
* updates on stderr files
* ignore cache file
* dealt with some initilization
* .
* memory leak
* memory leak..
* Update test/RunTests
Co-Authored-By: Jacob Alber <jalber@fernir.com>
* Update test/RunTests
Co-Authored-By: Jacob Alber <jalber@fernir.com>
commit 407673f6d1bbc4a7a0075f8820aba6e54446fd4d
Author: Francesco Orabona <bremen79@gmail.com>
Date: Tue Jun 4 20:11:12 2019 -0400
Coin betting (#1903)
* first version of the KT algorithm
* changed from 'kt' to 'approximate cocob' and implemented normalization by average lenght of the feature vectors
* variant that works with squared loss
* fixed all bugs: works great in binary classification, slightly worse than default one in ooa and cbify
* cleaned version, no bias used
* bias and fix bug
* another bug fix
* removed bias and added default params for logistic
* prediction is now stateless
* added comments
* added tests
commit 599f4d3facb8651048542240c543428688a82000
Author: Alexey Taymanov <41013086+ataymano@users.noreply.github.com>
Date: Tue Jun 4 19:41:44 2019 -0400
Ataymano/c wrapper fix2 (#1859)
* vwdll example construction update. first version
* cleanup
* parse_mask usage unification
* wrapper test
* deprecation comment
* test fix
* travis unit test build fix
* unit test 151 fix
* vw.h example construction helpers first version
* get rid of initializers
* get rid of initializers 2
* Revert "get rid of initializers 2"
This reverts commit f24bb6dabbd3663250b6a592636a16968fefa050.
* Revert "get rid of initializers"
This reverts commit 36bf448ddfbb1f536f16257a4e64a300045a604d.
* Revert "vw.h example construction helpers first version"
This reverts commit b9c334a4c1e7056b3b5c2c85d981728653110e35.
* adding init / set features methods to vw.h
* fix lrq test
commit 935fa86fea30231a8d86b2717242377e48f4e148
Author: Eduardo Salinas <edus@microsoft.com>
Date: Tue Jun 4 18:26:55 2019 -0400
Use Appveyor MSBuildLogger (#1904)
* Use Appveyor MSBuildLogger
* Add appveyor log to vstest
commit be4f242fe6d90916ed8daf663999a8bbfb7a614c
Author: John <jl@hunch.net>
Date: Tue Jun 4 10:41:07 2019 -0400
fix for no label confidence (#1901)
commit fa5c3dfbcf689d72bc9795d7c0e59967eea866d3
Author: Markus Cozowicz <marcozo@microsoft.com>
Date: Tue Jun 4 14:13:14 2019 +0200
Bare Java JNI Bindings optimized for Apache Spark (#1798)
* working version for Spark
* package natives up with Java code. This includes boost program options
* added dynamic port allocation to spanning tree to allow for parallel hyper-parameter tuning on Spark
* extracting VW command line args from model
* removed java header generation and checked in the headers just like the classic headers
* expose native hashing for testing
* fixed Java hashing
* formatted code
* improved Spanning Tree error message
commit 7b1fd30be710683e10ce4a565679bcecbc89c645
Author: John <jl@hunch.net>
Date: Mon Jun 3 23:17:07 2019 -0400
memory leaks and warnings (#1898)
* memory leaks and warnings
* more tweaks
* fix last memory leak
* test old parse_example_json.h
* fix warnings
* fix double free
commit bad1ce79b1201fd31bc4d0c1adad171d912244fd
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Mon Jun 3 22:01:17 2019 -0400
Change to absolute https path for submodule (#1900)
commit 4ffe6e79664ca72cc2ad6e623fa555653f24f930
Author: Jacob Alber <jaalber@microsoft.com>
Date: Mon Jun 3 18:14:31 2019 -0400
Change version-generation for C# bindings to use version.txt (#1899)
* Update version generation to source from version.txt
* This does not touch projects that are not built as part of the CI
workflows
* Update checked in version-bearing files
commit 5d4676c57ead1d5ace849af4a41e67b4071980b2
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Mon Jun 3 17:17:36 2019 -0400
Shared example merge reduction (#1873)
* pre-merge and remove shared features before sending examples down the reduction stack
* copy-paste error in vcxproj file
* fixing bad iterator dereference
* Enable Version and Tag override for NuGet pack (#1870)
* First attempt at softmax learner for cbadf (#1839)
* First attempt at softmax learner for cbadf
* some bugfixes and proper handling of shared and non-shared examples
* add test for cb_adf softmax
* Removing redundant safe_probability definition
* Update gd_mf_weights.cc right namespace (#1874)
* Update gd_mf_weights.cc
Use right indices to write out features for the right namespace, correcting bug found in https://github.com/VowpalWabbit/vowpal_wabbit/issues/1871
* Update gd_mf_weights.cc
Add back rank to the right quadratic calculation
* Fixed warning message ips -> mtr (#1875)
* Fix dsjson parser regression and add smoke-test (#1878)
* Fix dsjson parser regression and add smoke-test
Note: The test is ignored under the C# Unit Tests, because the test
driver is not set up to run the native parser. This is an area we should
improve outside of the bugfix.
* Suppress test for softmax learner
* fixing bugs, finding/fixing wrong tests
* fixing finish_example, unit tests
* cleaning up CB reductions
* copying predictions up and down the stack
* removing shared example in place. Disabling finish_example
* modify unit tests to match outputs. Add patch file to undo this change later
* moving patch file to test directory
* Removing unused variables, function
commit 92064660a778d343285e92620fa8077d41db841c
Author: Jacob Alber <jaalber@microsoft.com>
Date: Fri May 31 09:04:20 2019 -0400
Treat resource files as binary (#1896)
commit d00d8fb8222da3109f2fcc1ccb4e08fa0ddddf12
Author: agroh1 <42010767+agroh1@users.noreply.github.com>
Date: Tue May 28 11:48:01 2019 -0400
fix to make invert_hash work with bfgs (#1892)
commit d533941739b4c6a56d17df3ff99468e99d74a723
Author: Alexey Taymanov <41013086+ataymano@users.noreply.github.com>
Date: Sun May 26 19:23:06 2019 -0400
do not output progressive validation loss for oaa with subsampling (#1880)
* do not output progressive validation loss for oaa with subsampling
* oaa_subsample test
* oaa_subsample unit test fix
* tests reordering
* tests fix
commit 07cd90a268d63c3e772e83593547f9d47f77ef34
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Thu May 23 10:22:20 2019 -0400
Clean up some options warnings and remove some extra copies (#1888)
commit 697d4fce57ee3269e299c7e87a2fbe8e1dcc2f7f
Author: Eduardo Salinas <eduardosalinas@hotmail.com>
Date: Mon May 20 09:01:54 2019 -0400
Change references from SolutionDir to ProjectDir (#1886)
vw.vcxprojx has wrong references, they get exposed when
added to another Visual Studio Solution.
commit c68abd6793da2833707eac64247736914c233e14
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Sun May 19 18:07:00 2019 -0400
Update python documentation theme and index (#1885)
* Add python documentation generation
* Update theme and index
commit 06e6fc1582a53efd0b05367be1c82596244c1c07
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri May 17 13:23:23 2019 -0400
Add python documentation generation (#1884)
commit ea4051292efd943a720108648935991a36e9cd09
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri May 17 12:57:26 2019 -0400
Remove reinforcement_learning folder (#1883)
commit 1e46ee4188ba47febb939958357e14407c818104
Author: Jacob Alber <jacob.alber@microsoft.com>
Date: Thu May 16 11:34:15 2019 -0400
Fix dsjson parser regression and add smoke-test (#1878)
* Fix dsjson parser regression and add smoke-test
Note: The test is ignored under the C# Unit Tests, because the test
driver is not set up to run the native parser. This is an area we should
improve outside of the bugfix.
* Suppress test for softmax learner
commit ae3ca52d71c951223cab75b1c524e06303363796
Author: Marco Rossi <marco.rossi@microsoft.com>
Date: Tue May 14 14:08:03 2019 -0400
Fixed warning message ips -> mtr (#1875)
commit 8e00eba196f3b2a870bd1dea227eb068eb7fd4bd
Author: szipkin <31328582+szipkin@users.noreply.github.com>
Date: Tue May 14 10:42:21 2019 -0700
Update gd_mf_weights.cc right namespace (#1874)
* Update gd_mf_weights.cc
Use right indices to write out features for the right namespace, correcting bug found in https://github.com/VowpalWabbit/vowpal_wabbit/issues/1871
* Update gd_mf_weights.cc
Add back rank to the right quadratic calculation
commit 45a8a7f5507015a17d585f7698eab20c963b592b
Author: adith387 <adith387@gmail.com>
Date: Fri May 10 13:34:01 2019 -0700
First attempt at softmax learner for cbadf (#1839)
* First attempt at softmax learner for cbadf
* some bugfixes and proper handling of shared and non-shared examples
* add test for cb_adf softmax
* Removing redundant safe_probability definition
commit a10ae965b71d59d159d767cff8b4c12190c8cbcd
Author: Jacob Alber <jacob.alber@microsoft.com>
Date: Fri May 10 10:28:44 2019 -0400
Enable Version and Tag override for NuGet pack (#1870)
commit 98d4bd87fadecf8cf2d21310e6b705240f675c2d
Author: Jacob Alber <jalber@fernir.com>
Date: Wed May 8 14:26:13 2019 -0400
Fix Azure Pipeline build-break (#1867)
* We removed the Python3 Windows bindings project, becaues the bindings now build on CMake - this breaks the Azure DevOps pipeline, which validates that restore.cmd worked properly.
commit 04cb225a8b031f1ff475bdfe34a48d3fef0901f1
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Mon May 6 13:03:53 2019 -0400
cleaning up broken python3 vcxproj files (#1854)
* cleaning up broken python3 vcxproj files
* Update URL to wiki instead of README
* merging with master
* Revert "merging with master"
This reverts commit d474b3ee8a7f01974ab58a47bcdecb515b55719e.
commit aeb90b0f97759443c68dd094b6afe32019e2ee2f
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Thu May 2 09:18:25 2019 -0700
Consume RapidJson through submodule (#1828)
* Move rapid json to a consumed dependency
* Remove rapidjson
* Update dockerfile definition
* move to consume through submodule
* Remove shallow_clone
* revert dockerfile change
* undo nuget change
* actually revert change
* Fix bad revert of vw_core.vcxproj
* Fix bad merge error
* Use absolute url because LGTM isnt working
* Revert "Use absolute url because LGTM isnt working"
This reverts commit 163cc085382f222cd45f8bd038e5794401cd31a6.
commit 7161aaa6f94216cf7f16015bcb9e7d0f35fa5392
Author: Jacob Alber <jacob.alber@microsoft.com>
Date: Thu May 2 10:52:21 2019 -0400
Azure Pipeline for Windows CI (#1853)
* Update Clarius.TransformOnBuild to work with VS2017
* Simplify vw_core.vcxproj
* Simplify libvw.vcxproj
* Update NuGet.exe to support SemVer
* Add explicit project dependencies to the solution
Solution files offer a way to code-in build dependencies which do not get resolved properly by MsBuild.
It was necessary to add the dependencies for vw_core and libvw (and vw_clr as a precaution) so that the managed projects do not kicked off until the unmanaged dependencies were done. Otherwise the unmanaged projects get kicked off immediately when the build starts and chain to a second, parallel build of vw_core. This breaks the build when the same files (e.g. vw_core.lib, or .obj files) are being written concurrently.
* Enable finding VS2017 MSBuild automatically
* Fix init.cmd to also find vstest.console when it is not provided
* Enable a way to suppres c smoke test
Currently c_test breaks CI/CD that rely on stderror spew due to vw using cerr for info
* Fix c_test.vcxproj dependency
The project was incorrectly referencing vw_core rather than libvw; unfortunately, due to explicit ordering in the soultion and an explicit reference to the lib, this was not detected until trying to fix the solution dependencies.
* Disable node reuse to avoid keeping stale MSBuild.exe processes around after build
* Fix CodeAnalysis rule files location
* Disable it for vw_clr because the rules file does not contain compatible rules for this kind of project
* Unify C# outputs
* Fix NuGet pack binary search paths
* Make package.cmd more robust
* Move output into a separate /package folder under /out
* Make the script agnostic of where we invoke it from
* Ensure output directory is generated before calling nuget pack
* Remove in-build NuGet restore
* Remove DebugLeakCheck configuration
* This was removed a long time ago, but some projects did not get cleaned up properly
* Simplify cluster.vcxproj and unify output paths
* Normalize usage of $(SolutionDir)
* Simplify cs_unittest.csproj and unify outputs
* Switch to using exit codes to perform test validation
* Create Azure Pipeline configuration for Windows CI
* Bring set closer to check for envvars
commit cfef09c53f0dd6941bf783a4b707e26b924e5806
Author: Yaroslav Halchenko <debian@onerussian.com>
Date: Wed May 1 11:27:28 2019 -0400
BF: add cmake to installed dependencies in unstable singularity images (#1857)
commit f96e5fb01b7416ef1d15a74605f9089d0b3ad714
Author: Marco Rossi <marco.rossi@microsoft.com>
Date: Wed May 1 07:36:04 2019 -0700
cb_adf and cb_explore_adf: Setting --cb_type mtr as default (#1838)
* cb_adf: Setting --cb_type mtr as default
* cb_explore_adf.cc: default cb_type mtr
* Removed dm from cb_type help, since dm is not supported
* Fixed test 84
* cb_adf: fixed test 87
* cb_explore_adf: Fixed test 129
* cb_explore_adf: Fixed test 138
* cb_explore_adf: Fixed test 158
* Fixing Java tests errors
* Update tests
* Precision
* Precision
* ordering
* precision
* Fix ips->mtr in comment + adding spaces in cmd
commit f159ff65b536f5ac9512ff6fe91169988301d564
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Tue Apr 30 11:19:21 2019 -0400
Implement finish_example, update scripts to match (#1837)
commit 822158d0fcd6bd35b59ad540c07f3f0a5ac51a4b
Merge: bed5b80a ca279749
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Thu Apr 25 09:45:05 2019 -0400
Merge pull request #1849 from peterychang/windows_cmake_build
Cmake build on Windows
commit ca279749f147a999b2517ee869db6670b2cd5fbb
Author: peterychang <petchang.microsoft.com>
Date: Wed Apr 24 18:01:44 2019 -0400
updating documentation
commit 995b99d007410afbe6d5ac8644e2879637e20a4e
Merge: 12bc1b83 dbe71715
Author: peterychang <petchang.microsoft.com>
Date: Wed Apr 24 17:59:05 2019 -0400
Merge branch 'windows_cmake_build' of github.com:peterychang/vowpal_wabbit into windows_cmake_build
commit 12bc1b83960584244733b4c8aed3cc3dca1058cb
Author: peterychang <petchang.microsoft.com>
Date: Wed Apr 24 17:58:24 2019 -0400
incorporating pull request comments
commit dbe717159c0cd56003a19eff6325ff2a2f9f0ae8
Merge: ee4c06d3 bed5b80a
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Tue Apr 23 14:44:09 2019 -0400
Merge branch 'master' into windows_cmake_build
commit ee4c06d32230a1ea6752d36805ad3ae12639d788
Author: peterychang <petchang.microsoft.com>
Date: Tue Apr 23 10:02:08 2019 -0400
Python module building on Windows using setup.py via cmake/vcpkg
updating docs, making vcpkg-root option optional and Windows-only
clean up unused import
Current python build on Windows links against boost statically
commit bed5b80aa8cb46490a0ad06bb4e45458ab3a870f
Merge: aeddf739 df66c063
Author: yannstad <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 18 14:44:51 2019 -0400
Merge pull request #1850 from yannstad/fix-readme
Fix coveralls badge URL in README
commit df66c0638429a258a509a0518874160b773c2450
Author: Yann Stadnicki <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 18 14:11:17 2019 -0400
fix coverall badge in readme
commit aeddf7391197bbd202d347bba45b882ce6f00c6c
Author: yannstad <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 18 14:04:27 2019 -0400
Run coveralls inside docker (#1847)
* Run coveralls inside docker
* simplify docker arguments
* report coverage for vw and explore lib only
* Update coveralls badge in README
commit 70ca7d7a0c21c0115a8d920afa73fe2741b387e1
Author: Marco Rossi <marco.rossi@microsoft.com>
Date: Thu Apr 18 07:14:48 2019 -0700
Fix "average loss" bug in cb_explore.cc (#1825)
* Fix bug in cb_explore.cc
action and observation->action were one 1-index and 0-index based
* cb_explore: expected output
commit dad3f8d1ae4c567a8c0daf6375d0634e0dcaa3ae
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Wed Apr 17 11:29:53 2019 -0400
Update README.Windows.md
commit 9d6fc4e0581268d2e17be0f73a0dc5debb4d740c
Author: peterychang <petchang.microsoft.com>
Date: Wed Apr 17 11:17:56 2019 -0400
fixing cmake file, adding cmake settings json
add build helper script
extend windows build script to use vcpkg
Adding check for invalid windows options
commit 6c065483194c36f0337f184b267486bb865938be
Merge: 561a63e7 19c5e3fa
Author: yannstad <4194615+yannstad@users.noreply.github.com>
Date: Fri Apr 12 14:49:07 2019 -0400
Merge pull request #1844 from yannstad/bug-1608
Fix counting issue with --holdout_after option
commit 19c5e3fac89e7287353172bfc2aee843b27bfb66
Merge: e7cb0978 561a63e7
Author: yannstad <4194615+yannstad@users.noreply.github.com>
Date: Fri Apr 12 14:28:35 2019 -0400
Merge branch 'master' into bug-1608
commit 561a63e73349308ee1d7b1dafd92d4c100ed55e0
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Fri Apr 12 12:59:20 2019 -0400
Fix conda_install.sh script (#1843)
commit e7cb0978b5538143b08c90dbfefb4af88e34f013
Author: Yann Stadnicki <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 11 17:10:11 2019 -0400
add tests
commit 9ca2b5f704e0dd72560f14ba9ec9b9e05af0b125
Merge: 903e993e 17ae1cde
Author: yannstad <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 11 16:53:42 2019 -0400
Merge branch 'master' into bug-1608
commit 903e993e41516983701ec18be74b0df19c72beff
Author: Yann Stadnicki <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 11 15:46:03 2019 -0400
Fix counting issue with --holdout_after option
commit 17ae1cde478405fdd794d24d4f33cc334d69d7ea
Author: yannstad <4194615+yannstad@users.noreply.github.com>
Date: Thu Apr 11 11:51:00 2019 -0400
Fix NaN issue in box-muller tranform (#1833)
* Fix NaN issue in box-muller tranform
* Check for 0.f instead of FLOAT_MIN
* replace while loop with do..while
commit 640a057dd8a98d65f2621b7210cc463704c4b4c3
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Thu Apr 11 10:42:02 2019 -0400
Fix v142 toolchain (#1834)
commit d55d83cf73e4a87159c3dd10a54d60390f028a8d
Author: peterychang <49209570+peterychang@users.noreply.github.com>
Date: Wed Apr 10 09:55:29 2019 -0400
Fix build scripts for python3 (#1823)
commit 6ef7676bb222d8f11edaf89165fdb9e925e7b247
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Mon Apr 8 13:21:01 2019 -0400
Fix else statement (#1832)
commit 01e6bb05c99c044ce03bea3e770affa642fe5bf9
Author: pavithraks <pavithraks@users.noreply.github.com>
Date: Fri Apr 5 14:38:45 2019 -0400
fix bug 1784: return probabilities for actions in the correct order (#1830)
commit a845b12055175df10f50f643e70d510a4e6062e1
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri Apr 5 11:23:39 2019 -0400
Fix README.Windows.md link (#1827)
commit 6eff2f0eb0f20a1bbac63930d46c1a9e7788f2bf
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri Apr 5 09:51:30 2019 -0400
Add gitter chat badge to readme (#1826)
commit f2fd541b5247ec952473d1df5d03c417968d65b0
Author: Jacob Alber <jalber@fernir.com>
Date: Thu Apr 4 17:11:51 2019 -0400
Fix L2S HookTask in c-library and Python bindings (#1818)
* Remove code to disable hook task
* Make test_search build under Windows
* Also update for API-level changes (search now takes in multi_ex as
input rather than example*)
* Fix search::setup to put right data into all.searchstr
The change to free_ptr<search> for the local variable broke the code to
register the search pointer, as it started putting the pointer to the
free_ptr, rather than to the search object.
* Fix libsearch.h to use the multi_ex interface correctly
* Fix test_search.cc to do string concatenation correctly
* Enable test_search to build under Windows
* Fix Python L2S HookTask binding to use multi_ex properly
* Set the options_i pointer in HookTask::task_data properly
commit 5f7fcdbfc1770d1374feb8914f10482a403f2aa6
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Thu Apr 4 10:56:48 2019 -0400
Clear cb labels when returning to pool (#1822)
* Default labels after using them
* Move to just clearing labels for cb reduction
commit 7c221a4b82421ae8eaab61941e47e824944a92b7
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Wed Apr 3 10:30:40 2019 -0400
Update Python readme to reflect latest way to consume bindings from source (#1817)
* Update Python readme to reflect latest way to consume bindings from source
* Update script snippets
commit 31859a32385c17511eecf6bf7d0a04f12774a41e
Author: Chicheng Zhang <zcc1307@gmail.com>
Date: Tue Apr 2 10:34:43 2019 -0400
Warm start for cbify (#1534)
* /
* not sure if the cost vector retrieved is correct
* not sure if the cost vector retrieved is correct
* added cbify warm start code
* commented out the multiple lambda code in cbify
* commented out the multiple lambda code in cbify
* the cbexplore approach seems not working, as the first stage cannot prepare multiple copies of weights
* .
* properly store the temp labels
* back
* .
* fixed the bug with assigning cb label before cost sensitive prediction - the ec.l field is anunion
* the cumulative cost become diverse
* modified csoaa so that it can take example weights now.
* .
* added some results of warm starting
* added some results of warm starting
* before modifying cbify adf code
* start modifying cbify adf code
* unkwown segfault error
* everything good except for the cost sensitive learn part
* .
* .
* fixed the bug of empty example cost wrongly set
* fixed the bug of empty example cost wrongly set
* partially fix the importance weight issue
* fixed memory leak bug
* start changing the sample size paramters
* adding the bandit period as an explicit option
* file reorg
* tweak the python script
* added scatterplot script
* retracted the matplotlib inclusion
* .
* .
* regexp based line parsing for vw output (not tested yet)
* .
* .
* tweaked the scripts
* .
* .
* label corruption code
* supervised dataset validation
* lambda script
* weighting scheme
* .
* start properly copying the examples
* model is not updating in the supervised phase
* change to using proper copy example functions. Memory leak issues persist.
* .
* updated the lambda tuning scheme
* .
* fixed bug on zero warm start examples on small datasets
* added a refined weighting scheme and cumulative var calculation (not tested yet)
* warm start = 0 does not work
* fixed the csl label zero problem - now the label is set properly: 1,2,..K
* .
* make the lambda weighting more modular
* make adf modular
* the version where there is an error on memory free
* finished cleanup (need to double check the cb label swap in the adf case)
* adjusted the output of the script so that it is more systematic
* a more complete summary file
* bring back the pairwise comparison plot
* added type 3 noise
* (warm start type = 2, adf) setting gives wrong results
* (warm start type = 2, adf) setting gives wrong results
* fixed the place of weight multiplier calculation
* force the changes
* before modifying the baseline of no update
* a new parameter enumeration scheme
* .
* .
* updated scripts
* cleaned up the run vw script; need more tests on more choices of param settings
* fixed memory lost problems; still reachable problems still not resolved
* started cleaning up the cost-sensitive mc to cs conversion
* begin changing the cb learning w/o adf part
* finished cleaning up the no adf part
* before cleaning up adf
* mwt explorer kept outputting action 0
* roll back to a state before reorg that is working
* intermediate state
* fixed a problem in noadf:lambda selection now happens before update
* there is still a memory leak issue for ecs[0].pred.a_s
* lines for respective validation methods
* commented out matplotlib
* commented out matplotlib
* rename running script
* trial on compiling vw in one of the subtasks
* before merging
* cleaned up all errors except for calling cost sensitive learning
* fixed offset bugs in cb_explore and multiline_predict_or_learn
* fixed error on split/nosplit swapping
* fixed all memory leaks in warm start ground truth
* fixed memory leaks in supervised ground truth
* added cbify warm start test cases
* removed unnecessary include path prefix
* cleaning up script
* finished updating the running vw script
* .
* removed running scripts
* removed spurious changes
* removed spurious changes
* undoing the weight scaling by 1/k in mtr
* updated tests
* added warm_cb as a separate file
* .
* removed part on non-adf
* redoing the importance weight scaling by a factor of 1/k
* .
* comma typo
* removed redundant comments
* resolve conflicts
* compile error on peeking epsilon in warm_cb.cc
* fixed sim-bandit option, disallow cost-sensitive corruption
* begin fixing importance weight in cs examples
* revert cost_sensitive.cc
* fixed the weighting issue in cs examples
* .
* edited vw_core.vcxproj
* added new warm cb test cases
* overwrote regcb test results, as we further divide importance weights of each example in the mtr reduction by 1/num_actions
* corrected a mistake in new regcb test result
* reorder reduction stack
* changed the weight scaling back without 1/K; changed the central value of lambda
* changed back regcbopt test results; undo changes in cb_adf.cc
commit 1263807db180c546c1da21fd3a75c11df81fc798
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Mon Apr 1 11:17:31 2019 -0400
Fix example constructor (#1814)
commit 7a5ffbee7e969f0834f5fa1adde35b833697242d
Author: Rodrigo Kumpera <kumpera@users.noreply.github.com>
Date: Mon Apr 1 09:58:15 2019 -0400
[python] Fix packaging so it's possible to produce a wheels package on linux. (#1815)
commit d4cac03c6fee89253e6732d3f9c15164fb7579c4
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri Mar 29 13:20:29 2019 -0400
Enable JSON example parsing in Python bindings (#1809)
* Add text_reader, enable json parsing in python bindings
* Strip \r, raise error on len > 1 single examples
commit 72a4f949f3afd1d01d0cf8fdeddcb751e519f41e
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri Mar 29 12:55:12 2019 -0400
Add example C# Simulator (#1790)
* add simulator
* Appveyor uses VS2017
* Bump msbuild version
* Update msbuild detection
* Fix image
* try changing call
* Add echo
* Fix quoting of strings
* Add back echo
* Add delayed expansion
* remove extra quotes
* move back to hard coded path
* Revert solution upgrade, remove C# explore code
* Add restore
* Add sampling, fix small bugs
commit 04b3f605e45ebadbc75f10abe313784ee9bc5ac0
Author: Rodrigo Kumpera <kumpera@users.noreply.github.com>
Date: Tue Mar 26 00:39:42 2019 -0400
Use std::stable_sort when computing interactions. (#1804)
This fixes test 92 on OSX where it was producing a different set of interactions.
commit e2ae576e9291ffc386442b86b6ff2b72bb7c45d5
Author: Rodrigo Kumpera <kumpera@users.noreply.github.com>
Date: Mon Mar 25 20:16:05 2019 -0400
[OSX] Improve support for static linking. (#1807)
On OSX, it's not possible to statically link against system libraries as they are closed source and Apple doesn't provide `.a` versions of them.
So we do the best thing we can given those constraints. We fix the build and eliminate all dependencies we can.
The resulting binaries should work on factory reset OSX machines, which is as good as we can aim for.
commit ecccfe8563aadfca19728b1c42b1dd4224394461
Author: Rodrigo Kumpera <kumpera@users.noreply.github.com>
Date: Mon Mar 25 10:10:32 2019 -0400
[audit] Make sure --audit output is reproducible across systems. (#1788)
* [audit] Make sure --audit output is reproducible across systems.
Interactions output was using std::sort which triggered issues when values were the same.
* [unitest] Disable acceptance test that can't be processed by RunTests.tt
* [tests] Disable 176 as well since it was being silently ignored until 177 was added.
commit edfc0ba8e0c792c65e7732a8cbe03b0de4e7d501
Author: Jamie Markle <jrmarkle@users.noreply.github.com>
Date: Fri Mar 22 13:33:15 2019 -0400
expand Boost_LIBRARIES for pkg-config libs (#1801)
commit 5a8c49572325e9065a15af50e4231339609a2993
Author: pavithraks <pavithraks@users.noreply.github.com>
Date: Wed Mar 20 14:36:14 2019 -0400
Fix to bug 1729: no bias regularization for BFGS not working (#1794)
* fix to bug 1729
* fix to bug 1729
commit 4c8d6d201392534aa27a9a13e66d0f31bf741db8
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Wed Mar 20 13:19:54 2019 -0400
Parser now uses object and prod/cons queue and object pool for example parsing (#1777)
* WIP parser pool and queue
implement in ring
Fix counting
revert counter changes
reduce changes
Add fixed size pool
tests passing
Fix incorrect merge conflict
Fix deletion of new objects
Add test for object pool, fix incorrect handling of multiline example for now variable sized pool
* WIP
* move initialization
* Add destructor
* Move to chunk based object pooling
* Revert "Move to chunk based object pooling"
This reverts commit 68c256d2d7733cbe1e0960cfd90332d9a4ba7b1a.
* Trigger ci for potential flaky test
* Revert "Revert "Move to chunk based object pooling""
This reverts commit 10485479e0a720b49f769b82a695cc31a63d7297.
* improvements for example intialization
* Utilize setup_example
* Further init fixes, still don't have counters right
* test fix
* Fix double setup
* Remove available, move lock into object pool, fix deadlock
commit e0ad15e6cdc4eac8c375be567bae7f0660eded6b
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Tue Mar 19 10:04:30 2019 -0400
Fix usage of char instead of unsigned char for namespace index (#1791)
commit f0912e228f2892a7a473e278b2f6877a89ed38bb
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Mon Mar 18 14:52:22 2019 -0400
Fix resetting of cb_type (#1779)
commit eb63f84a6c99e9e98a221189912babd236f14d89
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Tue Mar 12 18:57:04 2019 -0400
Allow spanning_tree to be a static executable (#1787)
commit 112f9fe03101e7e3f64b731b033b2a6ffc3ebdc9
Author: Yuhan GUO <guoyuhan819@gmail.com>
Date: Wed Mar 6 17:19:00 2019 +0100
Fix weighted average on cluster mode (#1781)
* Fix weighted average on cluster mode
* Add test for model consistency
commit 018dbd1f13d602e8ffa03b350ba5aaa0dd96eb03
Merge: a6f6cb2f 99d826cb
Author: Rodrigo Kumpera <kumpera@users.noreply.github.com>
Date: Thu Feb 28 12:53:06 2019 -0500
Merge pull request #1776 from kumpera/fix_unit_test_on_osx
On OSX, we need to catch boost::program_options::ambiguous_option directly. Probably due to different boost versions.
commit 99d826cbca30d116f10705e3f47c13ba3a70f9e1
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Wed Feb 27 16:57:40 2019 -0500
On OSX, we need to catch boost::program_options::ambiguous_option directly. Probably due to different boost versions.
commit a6f6cb2f99eda6481b81edebc3a4acc9cfe61a98
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Mon Feb 25 13:56:57 2019 -0500
Migrate from v_array to std::vector in some places + other changes (#1765)
* - Migrate some usages of v_array to std:vector where possible
- Use std::stack for reduction stack
- Make tokenize templated to allow any container type
* Revert to existing behavior
* Update parser.cc
commit ecb130592465cfb084b87eabdd4a103f9ddeb891
Author: Alberto Bietti <alberto.bietti@gmail.com>
Date: Wed Feb 20 22:24:44 2019 +0100
RunTests: use test label number instead of counter (#1753)
* RunTests: use test label # instead of counter
* RunTests: mention test_id in doc
commit 4d181a421f9db5d281ea99cf8e56ad4b2e9cc66b
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri Feb 15 10:48:55 2019 -0500
Small Json parser cleanup (#1759)
* Small fixes to json parser
* Use std::find
* remove unused function
* Make file sync variable const
commit a73bc48c2f7eaa1a04ba36ad3600bc8cc35eee1b
Author: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Fri Feb 15 09:54:23 2019 -0500
Type erase json parser context for easier deletion (#1760)
* Allow for a reduction to override the json parser used
* remove override
* revert back to original naming
