Git log: commit 018bc66329d443edb2d07867263593282b18f2eb
Author: Héctor Orón Martínez <zumbi@debian.org>
Date: Thu Jul 18 06:29:04 2019 +0200
Release Debian version weston-6.0.1-1
Signed-off-by: Héctor Orón Martínez <zumbi@debian.org>
commit 2fd2e684bd5f317ae9afe4b4dc8a1faa91680bd2
Merge: cfdb9fd 7a600c0
Author: Héctor Orón Martínez <zumbi@debian.org>
Date: Thu Jul 18 04:17:23 2019 +0000
Merge branch 'debian-unstable' into 'debian-unstable'
Update weston to 6.0.1
See merge request xorg-team/wayland/weston!1
commit 7a600c0b0e2d50cb20b5e979a66943c69ee49103
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:31:23 2019 +0200
wrap-and-sort
commit 55066f3d118a67d60984afee0856c1555cf927e4
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:29:40 2019 +0200
Add weston.manpages to install man pages
commit beab05381c785147678287be0f21a9e87922fb15
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:29:05 2019 +0200
Update symbols
commit 0cc51fbac81ad3d29e361bd7c2631d22b2c8dc99
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:27:19 2019 +0200
Configuration file is no longer installed
commit d59fb51935d6a6266a2a1364a185b659a0df5a81
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:26:35 2019 +0200
Update install files
commit 39828491c8ff2fafd8731d0732fc4d8c0dc6c3f4
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:26:06 2019 +0200
Switch to the meson build system and update deps for 6.0.1
commit edc30b2b5634daecfb267e3609a93c52d8d655f4
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:21:20 2019 +0200
New upstream release
commit f1c57b1d35d62a208029bc89e27f6e3eb0525544
Merge: cfdb9fd 8757261
Author: Rohan Garg <rohan.garg@collabora.com>
Date: Wed Jul 10 17:19:20 2019 +0200
Merge tag '6.0.1' into debian-unstable
6.0.1
commit 8757261c05bf5ef266520924191a68dd923bf188
Author: Simon Ser <contact@emersion.fr>
Date: Mon Jun 24 18:15:22 2019 +0300
build: bump to version 6.0.1 for the point release
commit 9c001fca5aa2d24a3a42a8a7666c9d3b6af7dd2a
Author: Daniel Stone <daniels@collabora.com>
Date: Fri Mar 22 12:26:19 2019 +0000
compositor: Don't ignore --use-pixman for Wayland backend
We loaded the use-pixman configuration value from both the command line
and the configuration file, but completely ignored the former. Make sure
we actually use both.
Tested with all permutations of config/command line.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Tested-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
(cherry picked from commit 8a4585c27f5fa88511dbfafe4ae7403df3f83edc)
commit a219af3858e4c0a208647f6863e530b739f9b583
Author: Daniel Stone <daniels@collabora.com>
Date: Tue Jun 11 11:32:14 2019 +0100
weston: Properly test for output-creation failure
We were testing the wrong variable to see if output creation had failed:
instead of testing the return of the function we'd just called, we were
testing something we'd already checked earlier.
Signed-off-by: Daniel Stone <daniels@collabora.com>
(cherry picked from commit 814335821eb0fb5e74ec031c0cf68399e1dd370a)
commit 89a105444eac850aa383bc8d4c3d36cd5d926451
Author: Scott Anderson <scott.anderson@collabora.com>
Date: Wed May 29 18:27:30 2019 +1200
compositor: Fix incorrect use of bool options
WESTON_OPTION_BOOLEAN takes a pointer to an int as an argument, but
there were several cases of being passed a pointer to a bool instead.
This changes it to use a local int instead, and then write that value to
the bool.
Signed-off-by: Scott Anderson <scott.anderson@collabora.com>
(cherry picked from commit 2edbcbd9cdd30e00556e9618570234ea68d89b11)
commit 611fe36d24402a82ff0f7520eb31fed1efaab90f
Author: Antonio Borneo <borneo.antonio@gmail.com>
Date: Fri Apr 26 23:57:31 2019 +0200
log: remove "%m" from format strings by using strerror(errno)
The printf() format specifier "%m" is a glibc extension to print
the string returned by strerror(errno). While supported by other
libraries (e.g. uClibc and musl), it is not widely portable.
In Weston code the format string is often passed to a logging
function that calls other syscalls before the conversion of "%m"
takes place. If one of such syscall modifies the value in errno,
the conversion of "%m" will incorrectly report the error string
corresponding to the new value of errno.
Remove all the occurrences of the specifier "%m" in Weston code
by using directly the string returned by strerror(errno).
While there, fix some minor indentation issue.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
(cherry picked from commit 3957863667c15bc5f1984ddc6c5967a323f41e7a)
commit 45720b34e2037cb82600a0e21d8f17eae170060f
Author: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Date: Mon Jun 10 12:02:03 2019 +0200
Fix build with kernel < 4.4
weston includes input-event-codes.h since version 5.0.91 and
https://github.com/wayland-project/weston/commit/6e229ca26381bc8191fd9af1e439c311da709aff
input-event-codes.h is available only since kernel 4.4 and
https://github.com/torvalds/linux/commit/f902dd893427eade90f7eaf858e5ff8b150a5a12
To fix this build failure, replace include on linux/input-event-codes.h
by linux/input.h
Fixes:
- http://autobuild.buildroot.org/results/210c2759900f15ea0030d088f6f45cd8bb199b29
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
(cherry picked from commit 137b811ecd566086f7eb42c1e49e7c0cf27fb85e)
commit 066f669d8d92b374f8d383e1663b157b3ba72c59
Author: Silva Alejandro Ismael <silva.alejandro.ismael@gmail.com>
Date: Fri May 31 16:39:43 2019 -0300
compositor: fix segfaults if wl_display_create fails
Added check to log the error if wl_display_create return NULL.
Fixes: #101
Signed-off-by: Silva Alejandro Ismael <silva.alejandro.ismael@gmail.com>
(cherry picked from commit 21a1f40760f2da174fa52399fa0d9a8c1f772e68)
commit 9618f65c3d342614cdf4c90e9926f91e5be94dac
Author: - <makepost@firemail.cc>
Date: Thu May 2 17:35:29 2019 +0000
zunitc: Fix undeclared identifier 'NULL'
Since v6 release, -Dtest-junit-xml=false build regressed because its
ifdef branch no longer includes stddef.h and thus NULL, either directly
or through another header. Using musl-1.1.22 and llvm-8.0.0.
(cherry picked from commit 45d38856c8856b5550bb5656bda60ea674ca52c0)
commit ffb78089ba58a9ff5c9b4c8c6db7a63fd4aacdd3
Author: Antonio Borneo <borneo.antonio@gmail.com>
Date: Mon Apr 29 17:54:10 2019 +0200
clients: close unused keymap fd
In the simple examples in which keymap is not handled, the open
descriptor has to be properly closed.
After each suspend/resume sequence the keymap is send again to
every client. On client weston-simple-egl the leak causes a
segfault when no more file descriptors can be opened.
Close the file descriptor and lazily copy/paste the comment
already available in simple-dmabuf-v4l.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
(cherry picked from commit 4071225cdc12a36a08ddd3102a3dd17d4006c320)
commit 5b1bf9724501e541e3880fa21c61d84385a5c1c5
Author: Sebastian Wick <sebastian@sebastianwick.net>
Date: Tue Apr 9 12:18:25 2019 +0200
weston-terminal: Fix weston-terminal crash on mutter
Set up handlers for wl_data_source v3 events
Signed-off-by: Sebastian Wick <sebastian@sebastianwick.net>
(cherry picked from commit 1bdf36329557e6c846d5e51856eb8da00504212a)
commit f76cf8a5b775c637657c0bfbd7334e46001ac405
Author: Harish Krupo <harishkrupo@gmail.com>
Date: Fri Apr 19 22:06:44 2019 +0530
Fix: clients/window: Premature finish request when copy-pasting
As per the wl_data_offer::finish documentation, the request is only
valid for drag n drop operations and signifies that a dnd is completed.
Send finish request only when we have a dnd operation active.
Signed-off-by: Harish Krupo <harishkrupo@gmail.com>
(cherry picked from commit 43152a3a8fa1e3164db33ac7ace105186c5e8ac8)
commit 2e5ad9252e0ba20c5c547552788fb6ac585c2a84
Author: Harish Krupo <harishkrupo@gmail.com>
Date: Fri Apr 19 22:06:37 2019 +0530
data-device: send INVALID_FINISH when operation != dnd
The documentation of wl_data_offer::finish states that it should be
used to signify that a drag and drop operation is completed. So send
WL_DATA_OFFER_ERROR_INVALID_FINISH when the client calls the finish
request but the operation isn't dnd.
Signed-off-by: Harish Krupo <harishkrupo@gmail.com>
(cherry picked from commit 737ac0d4b3f7b40c345b61ff62dea0550217f063)
commit 48e1c4278442ef2d59696d996f921cc23b13d539
Author: Harish Krupo <harishkrupo@gmail.com>
Date: Fri Apr 19 01:53:27 2019 +0530
window.c: Don't assume registry advertisement order
The toytoolkit assumes that wl_seats are advertised after
wl_data_device_manager and creates a data_device during wl_seat
registry binding. This patch removes this assumption by creating
data_devices for all the wl_seats created up until then.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/201
Signed-off-by: Harish Krupo <harishkrupo@gmail.com>
(cherry picked from commit ee4c7a24dd8e2f52edc3ee4a9245f316e8261367)
commit 3e7a9c94eb9fb5bb26d7eca0349f8092525f154d
Author: Luca Weiss <luca@z3ntu.xyz>
Date: Sun Apr 14 10:38:25 2019 +0000
Fix incorrect include
In file included from ../clients/multi-resource.c:38:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
#warning redirecting incorrect #include <sys/poll.h> to <poll.h>
^~~~~~~
(cherry picked from commit 923a1e9688c7f9a16cb5195e1bc22deff3f43e39)
commit df842e64a2de7392b72c7907082860263fc508e7
Author: Kamal Pandey <kamal.pandey@ifm.com>
Date: Thu Apr 4 19:45:45 2019 +0530
FIX: weston: clients: typo in simple-dmabuf-egl.c
Fix variable EGL_NO_IMAGE to EGL_NO_IMAGE_KHR in
clients/simple-dmabuf-egl.c
Signed-off-by: Kamal Pandey <pandeykamal13526@gmail.com>
(cherry picked from commit 53d7c243ba0baa052081735b8effff4e2679ce65)
commit 8ba1302951919dda1f1b1ab6234dd038b5f60e04
Author: Tomohito Esaki <etom@igel.co.jp>
Date: Mon Apr 1 17:51:35 2019 +0900
cairo-util: Don't set title string to Pango layout if the title is NULL
If buttons list isn't empty and title is NULL, SEGV is occured in
pango_layout_set_text(). This patch fixes this problem.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
(cherry picked from commit 6f9db6c4a16d853bbc5889ad5ff0d9c75e21d69c)
commit e9dbb0d437a8ea67ac36393951bc10cefafe2926
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Sun Mar 17 18:22:21 2019 +0200
compositor: Fix missing new line when displaying buffer type for EGL buffer
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
(cherry picked from commit 253ba9a6db38aaf92955d32aac044d4d7d3a076a)
commit 1bbdafd2a7fe053756f7121c2e807885c8162c3f
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Sun Mar 17 18:10:09 2019 +0200
compositor: Fix invalid view numbering in scene-graph
With the addition of patch 433f4e77b7729 we display the same view id (0)
for every view as we're modifying the local variable.
Displaying sub-surfaces based views is also problematic. The caller need
to modify the view number as well, so we instead we pass the address as
to allow that to happen. Otherwise we end up repeating the same number
for views without sub-subrfaces once those have been printed.
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
(cherry picked from commit a6acfa83460d4f1e9f59fd5e52a8e39e1b8d4167)
commit 384210be5a17d63a3673ec8cc943465dacc42b36
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Wed Mar 13 12:16:29 2019 +0200
clients/simple-dmabuf-egl: Properly check for error in gbm_bo_get_handle_for_plane
gbm_bo_get_handle_for_plane returns handle.s32 == -1 on error, at least
for the Mesa dri implementation.
Reported-by: Marius Vlad <marius.vlad@collabora.com>
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
(cherry picked from commit ff98a9080fcc1e8689bb5996dd03fc4f1c313983)
commit 91a6a37d459fc5c6c8cab00a7edc18c1dcb6c735
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Thu Mar 28 14:45:40 2019 +0200
libweston: fix protocol install path
These protocols are from libweston, not weston.
Even the pkg-config files is called libweston-6-protocols.pc.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 4ab901ebb0cc18aab8af34263e91c352b6a4e29f)
commit a2aedba5317040bc3257ada5278bd28c6386228e
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Tue Apr 16 17:37:10 2019 +0300
meson.build/libweston: Fix clang warning for export-dynamic
Identical to 8a8558dd, where we need to pass `-Wl` as linker args.
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
(cherry picked from commit 3a28bd66ff35c75e174bde1fe9dce0791f90a087)
commit efe845a8af9efaa198e1b71879c6050e08a624ef
Author: Harish Krupo <harish.krupo.kps@intel.com>
Date: Tue Apr 16 10:41:01 2019 +0530
meson.build: Fix warning for configure_file
We claim to support meson versions >= 0.47 but the `install:` argument
in configure_file was introduced in version 0.50. This produces the
following meson warning:
WARNING: Project specifies a minimum meson_version '>= 0.47' but uses
features which were added in newer versions:
* 0.50.0: {'install arg in configure_file'}
From the documentation for the install argument [1]:
" When omitted it (install) defaults to true when install_dir is set and
not empty, false otherwise."
So, remove the `install:` argument and just depend on `install_dir` for
installing.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/225
[1] https://mesonbuild.com/Reference-manual.html#configure_file
Signed-off-by: Harish Krupo <harish.krupo.kps@intel.com>
(cherry picked from commit b81fc517d87eecf2df6ec80c0a317656d611f9b3)
commit a11bcedec34dd977970ca4dadd826ac27c113008
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Mar 29 13:37:56 2019 +0200
build: add missing dep to x11 backend
All other backends already link to libweston, x11 backend should too.
This fixes a build failure:
[1/50] Compiling C object 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o'.
FAILED: libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o
cc -Ilibweston/2b98b6d@@x11-backend@sha -Ilibweston -I../../git/weston/libweston -Ilibweston/.. -I../../git/weston/libweston/.. -Ilibweston/../shared -I../../git/weston/libweston/../shared -Iprotocol -I/home/pq/local/include -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/libdrm -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -g -Wno-unused-parameter -Wno-shift-negative-value -Wno-missing-field-initializers -fvisibility=hidden -fPIC -MD -MQ 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o' -MF 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o.d' -o 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o' -c ../../git/weston/libweston/compositor-x11.c
../../git/weston/libweston/compositor-x11.c:51:10: fatal error: xkbcommon/xkbcommon.h: No such file or directory
#include <xkbcommon/xkbcommon.h>
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 651566af2d937a8889ddda0ecc71e93b4091842a)
commit bfa2b2c24df868ae8307327323c8889295b0fd27
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Thu Mar 28 12:26:47 2019 +0200
meson: dep fix for compositor.h needing xkbcommon.h
This fixes:
[ 5s] cc -Ilibweston/2b98b6d@@session-helper@sta -Ilibweston -I../libweston -Ilibweston/.. -I../libweston/.. -Ilibwes
ton/../shared -I../libweston/../shared -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/dbus-1.0 -I/usr/lib6
4/dbus-1.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu99 -Wno-unused-parameter -Wno-shift-n
egative-value -Wno-missing-field-initializers -fvisibility=hidden -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIC -MD -MQ 'libweston/2b98b6d@@session-hel
per@sta/launcher-util.c.o' -MF 'libweston/2b98b6d@@session-helper@sta/launcher-util.c.o.d' -o 'libweston/2b98b6d@@sessio
n-helper@sta/launcher-util.c.o' -c ../libweston/launcher-util.c
[ 5s] In file included from ../libweston/launcher-util.c:29:
[ 5s] ../libweston/compositor.h:39:10: fatal error: xkbcommon/xkbcommon.h: No such file or directory
[ 5s] #include <xkbcommon/xkbcommon.h>
For completeness, also add the same for wayland-server.h.
Reported-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 779db046b91f28458b6bd79e07818ae20b49ba8b)
commit 3dc04bcf6ccd985bc6c001ae0f2d444f4d624f26
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Mar 22 17:05:11 2019 +0200
meson: DRM-backend demands GBM
All the GBM code is unconditional in compositor-drm.c, so while disabling the
GL-renderer would stop GBM from being used, GBM headers would still be needed
for building and GBM library for linking.
Leave a note to fix it properly later. At least we now check for GBM and do not
mislead with the error message.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit fe6dd7bcefa6a073f28bae778059a915328e3849)
commit ee5b6f256d99533d89424a1c55f7358be66046c0
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Mar 22 14:37:39 2019 +0200
meson: link remoting with glib and gobject
remoting-plugin.c calls things like g_error_free() and g_object_set(), so it
needs to link glib-2.0 and gobject-2.0 explicitly, instead of relying on
GStreamer pkg-config bringing them in.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 292aaf930832f152efabf0e6314d17dbbe70271d)
commit a60ebf2bd3ffbd8c1de61525114ad54d58f6d1be
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Mar 22 14:20:51 2019 +0200
meson: link cms-colord with glib and gobject
cms-colord.c calls things like g_string_free() and g_object_unref(), so it
needs to link glib-2.0 and gobject-2.0 explicitly, instead of relying on colord
pkg-config bringing them in.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 191c453f831d3c955cec9beb8d9f1fc8fafc0e59)
commit 0f4d31cefd12fad6f8deabf128439931910e96e5
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Mar 22 13:58:30 2019 +0200
meson: link editor with gobject-2.0
editor.c calls g_clear_object(), so it should link to gobject directly instead
of relying on pangocairo pulling it in in its pkg-config.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/211
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit cbffca980b19fd6a6de14d9f2b4dca6a7711d9e0)
commit ea5ea00d5884cda5d8d16374136a2889d412b828
Author: Derek Foreman <derekf@osg.samsung.com>
Date: Wed Mar 27 20:11:52 2019 -0500
configure.ac/meson.build: bump version to 6.0.0 for the official release
commit 825077d5916ab4cfa5716dcc6b9658495ec8a295
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Wed Mar 27 11:15:53 2019 +0200
autotools: Fix tags/cscope targets with autools
This was introduced with a95bb6f7e554c1a7 (clients: Support explicit
synchronization)
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
commit cc64cc3717ab39882df37bc244d1ac6cf8526f93
Author: Derek Foreman <derekf@osg.samsung.com>
Date: Wed Mar 20 19:49:58 2019 -0500
configure.ac/meson.build: bump to version 5.0.94 for the RC2 release
commit 483c6d4d06c16807042111043d62a58af0457076
Author: Stefan Agner <stefan@agner.ch>
Date: Wed Mar 20 00:09:51 2019 +0100
meson: fix building screen-share module
When building screen-share module with meson loading the module
fails with:
[00:01:28.604] Failed to load module: /usr/local/lib/weston/screen-share.so: undefined symbol: os_create_anonymous_file
Failed to process Wayland connection: Broken pipe
failed to create display: Broken pipe
The function os_create_anonymous_file is defined in libshared,
adding libshared to the dependency makes sure the function gets
compiled into screen-share.so.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/208
Signed-off-by: Stefan Agner <stefan@agner.ch>
commit 6f897960cb12bc161430f546ccdb51eb505b09f6
Author: Derek Foreman <derekf@osg.samsung.com>
Date: Wed Mar 13 21:27:12 2019 -0500
configure.ac: bump version to 5.0.93 for the RC1 release
commit 5c8eef147c27a95ebb8ba79e19ebb190b025cbe0
Author: Philipp Zabel <philipp.zabel@gmail.com>
Date: Wed Mar 6 11:12:47 2019 +0100
compositor-drm: clear gbm_surface pointer after destroying the GBM surface
Since commit ee1d968e641e ("compositor-drm: Fall back if GBM surface fails with
modifiers"), drm_output_init_egl requires output->gbm_surface to be NULL, or
gbm_surface_create will not be called if HAVE_GBM_MODIFIERS is enabled but no
modifiers are supported by the plane. This could happen if _init_egl is called
after drm_ouptut_fini_egl drom drm_output_switch_mode.
Add an assert to guarantee the requirement and clears the gbm_surface pointer
after the surface is destroyed.
Signed-off-by: Philipp Zabel <p.pzabel@pengutronix.de>
commit 2293cb42384e0297e53fb876697342528926a710
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Tue Mar 5 17:28:08 2019 +0100
meson: allow to build weston-simple-dmabuf-egl
It is all hooked up in clients/meson.build, just the option to enable it
was missing.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
commit 7825f141ad7bdc0a8d875b45a7928bae29326182
Author: Derek Foreman <derekf@osg.samsung.com>
Date: Tue Mar 5 17:21:49 2019 -0600
configure.ac: bump to version 5.0.92 for the beta release
commit 10a733961108f1495894e6143d5281d40ef84ff3
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Tue Mar 5 12:51:14 2019 +0200
clients/simple-dmabuf-egl: Create the EGL display using the GBM platform
Since we are managing and rendering to buffers on our own with GBM,
create the EGL display using the GBM platform with the DRM render node,
instead of using the Wayland EGL platform.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit 1c49b5445ebeb84f1767811b6400a0fe87897acf
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Fri Feb 15 14:52:00 2019 +0100
compositor-drm: fix gbm_bo_get_handle_for_plane error handling
gbm_bo_get_handle_for_plane returns -1 on error, not 0.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
commit 2914a6da8b73e4e49d781b8db60f9179fa08fe45
Author: Daniel Stone <daniels@collabora.com>
Date: Sat Feb 16 16:16:10 2019 +0000
compositor-drm: Add missing newline to debug print
The 'created new mode blob' print was missing a newline, unlike all the
others.
Signed-off-by: Daniel Stone <daniels@collabora.com>
commit 426c24673f2f5c4e3f0e388e87d2a355b82cd4e7
Author: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Date: Wed Feb 20 16:33:32 2019 +0100
Fix typos all around (thanks codespell!)
commit e578004b3c3584079d41d7e7f7f1f46245a9774d
Author: Derek Foreman <derekf@osg.samsung.com>
Date: Tue Feb 19 12:48:10 2019 -0600
configure.ac: bump to version 5.0.91 for the alpha release
commit 433f4e77b77297148ea1143d49b7e62a0bfb7a97
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Sun Feb 17 22:14:23 2019 +0200
compositor: Fix scene-graph debug scope missing views based on sub-surfaces
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
commit d4c7bc58ab95b593d074123952585aa502e9c98f
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Sat Feb 16 21:19:51 2019 +0200
compositor-drm: Print pixel format in human-friendly form when failing to assign view to a overlay plane
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
commit 0a9c95382520e39c5400f49426a298df23af7b26
Author: Marius Vlad <marius.vlad@collabora.com>
Date: Sat Feb 16 20:43:24 2019 +0200
meson: Remove freerdp1 as it no longer builds
../libweston/compositor-rdp.c: In function ‘rdp_peer_refresh_rfx’:
../libweston/compositor-rdp.c:213:25: error: invalid type argument of unary ‘*’ (have ‘SURFACE_BITS_COMMAND’ {aka ‘struct _SURFACE_BITS_COMMAND’})
memset(&cmd, 0, sizeof(*cmd));
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
commit 438de4f5592606b8111ff060aeacdd8d128d6f44
Author: emersion <contact@emersion.fr>
Date: Mon Feb 18 11:21:07 2019 +0100
Fix .editorconfig: use tabs for Meson files
commit ee1d968e641ecd0aa672faafcdb37a780cb96ef0
Author: Daniel Stone <daniels@collabora.com>
Date: Thu Jan 31 00:02:25 2019 +0000
compositor-drm: Fall back if GBM surface fails with modifiers
If we cannot create a gbm_surface using a list of modifiers, fall back
to using the old pre-modifier version.
This fixes initialisation on systems where KMS supports modifiers but
the GBM driver does not, such as old i915 systems like Pine View using
the unified KMS driver but the old i915 Mesa driver.
Signed-off-by: Daniel Stone <daniels@collabora.com>
commit 521056b37b674ef0a7b66017c8bc7c429f1a42d1
Author: emersion <contact@emersion.fr>
Date: Fri Feb 15 22:51:31 2019 +0100
Add .editorconfig
commit 14ef201295724f5c9ed254979845d0a2d5988bd3
Author: Sergey Bugaev <bugaevc@gmail.com>
Date: Mon Feb 11 22:55:09 2019 +0300
desktop-shell: don't crash if a surface disappears while grabbed
A surface can get destroyed while a shell grab is active, which can
for example happen if the command running in weston-terminal exits.
When a surface gets destroyed, grab->shsurf is reset to NULL by
destroy_shell_grab_shsurf(), but otherwise the grab remains active and
its callbacks continue to be called. Thus, dereferencing grab->shsurf
in a callback without checking it for NULL first can lead to undefined
behavior, including crashes.
Several functions were already properly checking grab->shsurf for NULL,
move_grab_motion() being one example. Others, however, were not, which
is what this commit fixes.
Related to https://gitlab.freedesktop.org/wayland/weston/issues/192
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
commit 15d3d3004b0c5344be3b3f7fa99381be392dfc4a
Author: Greg V <greg@unrelenting.technology>
Date: Fri Dec 7 01:33:34 2018 +0300
desktop-shell: remove surface destroy listener when focus state is destroyed
Changing the focused surface did remove the surface_destroy_listener from the wl_signal list,
but destroying the focus state did not. As a result, sometimes the same listener would be added
to two surfaces, which would join their wl_signal lists together, which would cause infinite
loops and use-after-frees when closing desktop surfaces.
commit ec3f779aa76332b4087e1bc882e83e11a073e478
Author: Greg V <greg@unrelenting.technology>
Date: Thu Nov 8 00:24:56 2018 +0300
desktop-shell: fix resize grab related crash
This crash was happening when *releasing* a pointer button on a window
that was being resized and got destroyed during the grab.
[@daniels: Cosmetic fixes; apply same fix to grab cancel.]
commit dce10bd1416adecca8cca8bab1d1b8e5fc09f791
Author: Greg V <greg@unrelenting.technology>
Date: Thu Nov 8 00:27:04 2018 +0300
xwm: fix resize grab related crash
This crash was happening *during resizing* of an xwayland window that was destroyed.
Discovered by: John Good @archiesix
[@daniels: Moved tests below declarations.]
commit 4253f2357686e7bb2d44fd9259ea21306060a6a6
Author: Greg V <greg@unrelenting.technology>
Date: Thu Nov 8 00:24:15 2018 +0300
xwayland: fix clipboard related crash
commit b68847a8bc8f73e5518285d927e7426005eeaaad
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed Feb 13 15:59:59 2019 +0100
meson: fix compositor build with xwayland disabled
If xwayland is disabled, compositor/weston is built without
compositor/xwayland.c, which defines wet_load_xwayland.
compositor/fb12c4d@@weston@exe/main.c.o: In function `main':
../weston-5.0.0-169-g2d4cc4f4dd6a/compositor/main.c:3103: undefined reference to `wet_load_xwayland'
Provide an empty stub for wet_load_xwayland if xwayland is disabled.
With that we also have to remove xwayland.c from the autotools build
if xwayland is disabled, to avoid a multiple definition error.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
commit cca734655764d0d05543653aa37d288e64ba3304
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed Feb 13 15:10:35 2019 +0100
meson: add missing libweston EGL dependency if renderer-gl is enabled
If the 'renderer-gl' option is enabled, ENABLE_EGL is defined, and
libweston/pixel-formats.c includes EGL/egl.h. This requires an egl
dependency, as X11-less platforms need the MESA_EGL_NO_X11_HEADERS
define from egl.pc cflags:
In file included from /usr/include/EGL/egl.h:39:0,
from ../libweston/pixel-formats.c:42:
/usr/include/EGL/eglplatform.h:124:10: fatal error: X11/Xlib.h: No such file or directory
compilation terminated.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
commit c58648b0df60410bbb731aef28999eefa020778f
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed Feb 6 14:03:21 2019 +0200
meson: IVI plugin tests do not use config
If Weston is not installed, running ivi-layout test would fail on lots of image
files not found which presumably causes the creation of some ivi surfaces to
fail, leading to an assert failure.
Looking at the test setup in weston-tests-env, these IVI plugin tests are
supposed to run with --no-config instead.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/195
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit fcd9f674674731c7d37871034c5e9fe5166e248b
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed Feb 6 13:51:55 2019 +0200
meson: set WESTON_DATA_DIR for tests
It seems WESTON_DATA_DIR was missed. If you have already installed Weston, then
the files will be found in the install location, but if not, they were not
found at all.
This caused the xwayland test to SEGV the compositor in
weston_wm_window_create_frame() when frame_crate() returned NULL.
This patch fixes the test suite only.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit cd6bf210a44ecb2abb4aec91a84cbc167e894e06
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Feb 8 15:10:48 2019 +0200
libweston: bump major to 6
At least the following commits break the libweston ABI, strictly speaking:
- a5630eafec4f139adf1da4a5ba54894715d7b50f
- ce62cb3d05505777893ccdfacbf2a013c82e4ce2
- 195dadeb2add729735c32b9e394d7d1397cf065c
- c18ffd3939499897fb3eefc6ff3627140d88a23d
- ea54c2fda65aacd87c6385461dc7e7f7fb0d425d
- 27d7c395c7600e9bf6b13dd8b3d06ee19aab1aba
- acff29b3b3c3ab804db54fcc8524df53b6b9e1fb
- 676296749a5ddb82d2f378829f419398602e5ce4
- c9c247730b37a0101570f7a2596b1fb8b6ac66b5
- 65e1be1234fcbb7455fc9b41ac9916d258cf39f8
Furhtermore, 64fbd0f41f4eb175b772a2eddba8bfccb66e016a break the weston
executable exported ABI.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit 30a285748dbdcf35242176d7eb035f9c6c8df012
Author: ant8me <ant8me@gmail.com>
Date: Wed Nov 28 22:46:37 2018 +0100
compositor-wayland: use xdg_shell stable instead of v6
Better to excercise the current rather than outdated protocol.
Pekka:
- split the patch, rewrote commit message
- rename xdg_shell_ping to xdg_wm_base_ping
- rename xdg_shell_listener to wm_base_listener
- fix continued line alignment
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit f99fac22ab5c348a5a786b7cf2f48fb8b2dd3435
Author: ant8me <ant8me@gmail.com>
Date: Wed Nov 28 22:46:37 2018 +0100
clients: use xdg_shell stable instead of v6
Now that Weston supports the stable revision, use it. Better to excercise the
current rather than outdated protocol.
Pekka:
- split the patch, rewrote commit message
- rename xdg_shell_ping to xdg_wm_base_ping
- rename xdg_shell_listener to wm_base_listener
- rename shell to wm_base
- fix continued line alignment
- drop unrelated change of adding parentheses around bit-wise and
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit d8d9f5e6e16c8f6a3c06763d5f56c27dc9a6e52e
Author: ant8me <ant8me@gmail.com>
Date: Wed Nov 28 22:46:37 2018 +0100
libweston-desktop: implement the new xdg_shell (stable) protocol
Some clients like the mpv video player now request the xdg_shell
protocol so these will fail if the compositor only provides the
xdg_shell_unstable_v6 protocol. Compositors like mir and gnome provide
both protocols.
The two protocols are very similar therefore the code in xdg-shell-v6.c
has been refactored to work with the new xdg_shell protocol and now
resides in xdg-shell.c.
Pekka:
- split the patch
- fix continued line alignment
Daniel
- allow anchor_rect to initially have zero dimensions
- account for get_popup allowing NULL parent surface
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Signed-off-by: Daniel Stone <daniels@collabora.com>
commit 2d4cc4f4dd6a039eebbb6dfca9ae4522d83dc90b
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Feb 1 17:05:00 2019 +0200
configure: require opt-in to autotools
Autotools is going away. Break the autotools build so that people are
guaranteed to notice before it is gone. If they have problems with Meson, they
can still use --enable-autotools to build with autotools, but we really want to
hear about any problems.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit 68da919f849b39a69158741a680bdcb5e585e4e3
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Fri Feb 1 17:01:14 2019 +0200
README: Meson for build
Explain how to use with Meson, as autotools is going away.
The instructions have been copied from
https://wayland.freedesktop.org/building.html .
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit 4c347b8ee0236c2ce8f85f216f4386e70026178c
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date: Mon Oct 8 16:04:44 2018 +0200
config-parser: export functions to open a config file
The in-tree clients can access the functions via libshared, but they are
currently not available for external clients, such as custom shell helper
applications similar to weston-desktop-shell or
weston-ivi-shell-user-interface.
The functions to read the content of the config are already exported.
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
commit d6371b5a6a837486b45c92d2da94ac83b1be3b8b
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Wed Oct 11 17:17:29 2017 +0200
window client: remove ivi-application support
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit a232b7e22ce502bf9351bfa9788ac6e5408195bb
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Wed Oct 11 17:09:57 2017 +0200
simple-shm: remove ivi-application support
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 111d3d8fb474d02744a9e04d93ccaab8d3e11308
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 11:13:02 2017 +0200
simple-egl: remove ivi-application support
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit e894b3e4a3fe2cab2151fe439502b4379e69b52d
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Mon Apr 9 14:14:50 2018 +0200
hmi-controller: register for desktop_surface_configured
Since ivi-shell now supports xdg-protocol, the surface_created listener
can be removed and the desktop_surface_configured listener is needed.
ivi-layout: libweston-desktop api is used to send configure event to
application.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 2763b66d31594ff30102b6d791d499531f38a0cc
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 11:10:58 2017 +0200
ivi-shell: create weston_desktop in wet_shell_init
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit ed28f020b8dabc10655c238d41474efae9ce7036
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 11:10:18 2017 +0200
ivi-shell: remove surface_destroy_listener
Since the surface_destroy_listener is only registered for ivi-shell
applications, it should only be removed for ivi-shell applications.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 62d6d56a83793f8f9d2f2594815d96c45735dcf8
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Feb 5 15:25:56 2019 +0100
ivi-shell: added libweston-desktop-api implementation
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit c04188e5461280e666a89876c43a15b43c6868a3
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Wed Feb 6 16:10:09 2019 +0100
ivi-layout: use libweston-desktop api for configure event
The libweston-desktop api is used to send configure
event to application.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 831e58f8e69d41cfcb78342f028275015ad60166
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Mon Nov 6 12:55:07 2017 +0100
ivi-layout: use libweston-desktop api for views
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 8f9e92e8e32d1a0d53a8891e102cd78dca07509e
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Fri Feb 1 15:17:35 2019 +0100
ivi-shell: linked libweston-desktop and added structs
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 4d886d605828f35975af94e3b5889f08a1451ed5
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Feb 5 15:15:22 2019 +0100
ivi-layout: introduced surface create and configure
Introduced surface create and configure function for xdg-apps.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 65e1be1234fcbb7455fc9b41ac9916d258cf39f8
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 11:03:38 2017 +0200
ivi-layout: introduced configure_desktop_changed
Introduced signal configure_desktop_changed with interface. This signal
should be sent, when a desktop-surface is configured.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit c9c247730b37a0101570f7a2596b1fb8b6ac66b5
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 10:35:47 2017 +0200
layout-interface: added interface to change surface id
This interface enables an id-agent to change the surface ids of an
ivi-layout-surface once.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 7419dc26e0e81dfc7547b919f9663cd685af972c
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 10:31:09 2017 +0200
ivi-shell: introduction of IVI_INVALID_ID
Introduction of IVI_INVALID_ID for xdg-shell applications.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 8b6fb14871f066063e26938ec499085b03a8a58e
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Oct 17 10:29:21 2017 +0200
ivi-shell: removed assert
Removed assert, that checks if ivi-surface is not available, since this
can now happen with xdg-shell support.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit f2042e132e589fb5915d1caa2072edbed21105f4
Author: Michael Teyfel <mteyfel@de.adit-jv.com>
Date: Tue Sep 26 17:12:08 2017 +0200
ivi-shell: rework goto labels to avoid memory leaks
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
commit 1ed3506b70d988493b91861c5761e8a7ed88e772
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed Feb 6 16:42:09 2019 +0200
libweston: export weston_config API
Make it official that libweston will export the weston_config API, as requested
in https://gitlab.freedesktop.org/wayland/weston/merge_requests/29 .
There is no other way third party helper clients could access the API.
The autotools build has been accidentally exporting it all the time, but the
Meson build needed fixing.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit 7261edfe363482e140162cc18534a8e46f01915c
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Tue Jan 29 16:22:45 2019 +0200
clients: Add a mandelbrot set shader to simple-dmabuf-egl
Support drawing a mandelbrot set in the fragment shader, rendering it
with separate draw calls, one for each cell in a virtual 4x4 grid. This
more complex and heavy drawing will potentially help us to visually
discover any present or future explicit synchronization issues.
The mandelbrot set rendering is enabled with the -m/--mandelbrot
command-line switch.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit a95bb6f7e554c1a7ae52e87391f86944a3ba9461
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Tue Oct 30 14:26:47 2018 +0200
clients: Support explicit synchronization in simple-dmabuf-egl
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Changes in v7:
- Merge acquire fence and release fence code blocks in redraw().
- Use 1 << n to define option bitflags.
- Remove redundant statement involving OPT_IMPLICIT_SYNC.
Changes in v6:
- Add option for window size.
- Add option for enabling/disabling explicit sync.
Changes in v5:
- Meson support.
commit c715c750f641c8efc85865694845c8070b93128d
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Mon Nov 12 18:33:54 2018 +0200
tests: Add tests for per commit zwp_buffer_release_v1 behavior
Add tests to check that the zwp_buffer_release_v1 events are emitted per
surface commit.
To be able to test this we need to use a renderer that holds the buffer
until the next buffer is committed, hence we use the pixman renderer.
Changes in v7:
- Remove references to obsolete noop-hold renderer.
Changes in v5:
- Meson support.
Changes in v4:
- Use the pixman renderer instead of the (now gone) noop-hold
renderer.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit 676296749a5ddb82d2f378829f419398602e5ce4
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Fri Oct 19 12:14:11 2018 +0300
libweston: Support zwp_surface_synchronization_v1.get_release
Implement the get_release request of the zwp_surface_synchronization_v1
interface.
This commit implements the zwp_buffer_release_v1 interface. It supports
the zwp_buffer_release_v1.fenced_release event for surfaces rendered by
the GL renderer, and the zwp_buffer_release_v1.immediate_release event
for other cases.
Note that the immediate_release event is safe to be used for surface
buffers used as planes in the DRM backend, since the backend releases
them only after the next page flip that doesn't use the buffers has
finished.
Changes in v7:
- Remove "partial" from commit title and description.
- Fix inverted check when clearing used_in_output_repaint flag.
Changes in v5:
- Use the new, generic explicit sync server error reporting function.
- Introduce and use weston_buffer_release_move.
- Introduce internally and use weston_buffer_release_destroy.
Changes in v4:
- Support the zwp_buffer_release_v1.fenced_release event.
- Support release fences in the GL renderer.
- Assert that pending state buffer_release is always NULL after a
commit.
- Simplify weston_buffer_release_reference.
- Move removal of destroy listener before resource destruction to
avoid concerns about use-after-free in
weston_buffer_release_reference
- Rename weston_buffer_release_reference.busy_count to ref_count.
- Add documentation for weston_buffer_release and ..._reference.
Changes in v3:
- Raise NO_BUFFER for get_release if no buffer has been committed,
don't raise UNSUPPORTED_BUFFER for non-dmabuf buffers,
so get_release works for all valid buffers.
- Destroy the buffer_release object after sending an event.
- Track lifetime of buffer_release objects per commit, independently
of any buffers.
- Use updated protocol interface names.
- Use correct format specifier for resource ids.
Changes in v2:
- Raise UNSUPPORTED_BUFFER at commit if client has requested a
buffer_release, but the committed buffer is not a valid linux_dmabuf.
- Remove tests that are not viable anymore due to our inability to
create dmabuf buffers and fences in a unit-test environment.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit acff29b3b3c3ab804db54fcc8524df53b6b9e1fb
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Fri Oct 19 12:14:11 2018 +0300
libweston: Support zwp_surface_synchronization_v1.set_acquire_fence
Implement the set_acquire_fence request of the
zwp_surface_synchronization_v1 interface.
The implementation uses the acquire fence in two ways:
1. If the associated buffer is used as GL render source, an
EGLSyncKHR is created from the fence and used to synchronize
access.
2. If the associated buffer is used as a plane framebuffer,
the acquire fence is treated as an in-fence for the atomic
commit operation. If in-fences are not supported and the buffer
has an acquire fence, we don't consider it for plane placement.
If the used compositor/renderer doesn't support explicit
synchronization, we don't advertise the protocol at all. Currently only
the DRM and X11 backends when using the GL renderer advertise the
protocol for production use.
Issues for discussion
---------------------
a. Currently, a server-side wait of EGLSyncKHR is performed before
using the EGLImage/texture during rendering. Unfortunately, it's not clear
from the specs whether this is generally safe to do, or we need to
sync before glEGLImageTargetTexture2DOES. The exception is
TEXTURE_EXTERNAL_OES where the spec mentions it's enough to sync
and then glBindTexture for any changes to take effect.
Changes in v5:
- Meson support.
- Make explicit sync server error reporting more generic, supporting
all explicit sync related interfaces not just
wp_linux_surface_synchronization.
- Fix typo in warning for missing EGL_KHR_wait_sync extension.
- Support minor version 2 of the explicit sync protocol (i.e., support
fences for opaque EGL buffers).
Changes in v4:
- Introduce and use fd_clear and and fd_move helpers.
- Don't check for a valid buffer when updating surface acquire fence fd
from state.
- Assert that pending state acquire fence fd is always clear
after a commit.
- Clarify that WESTON_CAP_EXPLICIT_SYNC applies to just the
renderer.
- Check for EGL_KHR_wait_sync before using eglWaitSyncKHR.
- Dup the acquire fence before passing to EGL.
Changes in v3:
- Keep acquire_fence_fd in surface instead of buffer.
- Clarify that WESTON_CAP_EXPLICIT_SYNC applies to both backend and
renderer.
- Move comment about non-ownership of in_fence_fd to struct
drm_plane_state definition.
- Assert that we don't try to use planes with in-fences when using the
legacy KMS API.
- Remove unnecessary info from wayland error messages.
- Handle acquire fence for subsurface commits.
- Guard against self-update in fd_update.
- Disconnect the client if acquire fence EGLSyncKHR creation or wait
fails.
- Use updated protocol interface names.
- User correct format specifier for resource ids.
- Advertise protocol for X11 backend with GL renderer.
Changes in v2:
- Remove sync file wait fallbacks.
- Raise UNSUPPORTED_BUFFER error at commit if we have an acquire
fence, but the committed buffer is not a valid linux_dmabuf.
- Don't put buffers with in-fences on planes that don't support
in-fences.
- Don't advertise explicit sync protocol if backend does not
support explicit sync.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit c0e2f9261ff4653ed8f530f38e71c62043f4c1d9
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Fri Oct 19 12:14:11 2018 +0300
libweston: Introduce an internal linux sync file API
Introduce an internal API for dealing with linux sync files,
and use it in the codebase to replace ad-hoc sync file management.
The linux_sync_file_is_valid function is not currently used, but will be
utilized in upcoming commits to implement the
zwp_linux_explicit_synchronization_unstable_v1 protocol.
Changes in v5:
- Meson support.
Changes in v3:
- Use parameter name in function documentation.
- Move kernel UAPI to separate header file.
Changes in v2:
- Add function documentation
- Remove linux_sync_file_wait()
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit 27d7c395c7600e9bf6b13dd8b3d06ee19aab1aba
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Fri Oct 19 12:14:11 2018 +0300
libweston: Introduce zwp_linux_explicit_synchronization_v1
Introduce support for the zwp_linux_explicit_synchronization_unstable_v1
protocol with an implementation of the zwp_linux_explicit_synchronization_v1
interface.
Explicit synchronization provides a more versatile notification
mechanism for buffer readiness and availability, and can be used to
improve efficiency by integrating with related functionality in display
and graphics APIs.
In addition, the per-commit nature of the release events provided by
this protocol potentially offers a solution to a deficiency of the
wl_buffer.release event (see
https://gitlab.freedesktop.org/wayland/wayland/issues/46).
Support for this protocol depends on the capabilities of the backend, so
we don't register it by default but provide a function which each
backend will need to call. In this commit only the headless backend when
using the noop renderer supports this to enable testing.
Note that the zwp_surface_synchronization_v1 interface, which contains
the core functionality of the protocol, is not implemented in this
commit. Support for it will be added in future commits.
Changes in v7:
- Added some information in the commit message about the benefits of
the explicit sync protocol.
Changes in v6:
- Fall back to advertising minor version 1 of the explicit sync protocol,
although we support minor version 2 features, until the new
wayland-protocols version is released.
Changes in v5:
- Meson support.
- Advertise minor version 2 of the explicit sync protocol.
Changes in v4:
- Enable explicit sync support in the headless backend for all
renderers.
Changes in v3:
- Use wl_resource_get_version() instead of hardcoding version 1.
- Use updated protocol interface names.
- Use correct format specifier for resource id.
- Change test name to 'linux-explicit-synchronization.weston'
(s/_/-/g).
Changes in v2:
- Move implementation to separate file so protocol can be registered
on demand by backends.
- Register protocol in headless+noop backend for testing purposes.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
commit a37920e77c1ca8bb5252da38e165cc0da2acadf1
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed Feb 6 10:53:35 2019 +0200
tests: use weston_compositor_exit
Use the proper function to exit instead of the libwayland one, to allow main
handle_exit() to be called.
This is just to unify the exit paths.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit 818c20e78bc1ab7d3a5cd58f14a0a66498fde7ba
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed Feb 6 10:48:51 2019 +0200
ivi-shell: use weston_compositor_exit
Use the proper function to exit instead of the libwayland one, to allow main
handle_exit() to be called.
This is just to unify the exit paths.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
commit 052032d7306ca745670547870dfe0bdce65647af
Author: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed Feb 6 10:44:37 2019 +0200
desktop-shell: use weston_compositor_exit
Use the proper weston_compositor_exit API instead of wl_display_terminate() to
allow the compositor main to prepare for exit, and most importantly to set the
exit error code as appropriate.
I have some brokenness in my test suite running, and weston-desktop-shell was
crashing at start, yet the tests did not notice. With this patch, the tests
where the helper crashes are properly marked as failed.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
